You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by trancee <gi...@git.apache.org> on 2015/08/07 04:52:17 UTC
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
GitHub user trancee opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52
Set scale type to CENTER_INSIDE.
Before the scale type was set to CENTER_CROP which centered the image but stretched it outside the width of the view. By using CENTER_INSIDE the image is scaled correctly to the dimension of the ImageView.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trancee/cordova-plugin-splashscreen scale-type-CENTER_INSIDE
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit ff2426787c93662abb76d5da74e9250e411d7ea8
Author: Philipp Grosswiler <ph...@ruma.co.id>
Date: 2015-08-05T07:40:34Z
Set scale type to CENTER_INSIDE.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by Abszissex <gi...@git.apache.org>.
Github user Abszissex commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-144003579
Same here. I think CENTER_INSIDE would be the better way to go. With CENTER_CROP some parts of my splash screen image are cutted off...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165710372
@trancee, the current implementation will also work if you have 'large margins (safe areas)' according to the docs:
> "SplashMaintainAspectRatio" preference is optional. If set to true, splash screen drawable is not stretched to fit screen, but instead simply "covers" the screen, like CSS "background-size:cover". This is very useful when splash screen images cannot be distorted in any way, for example when they contain scenery or text. This setting works best with images that have large margins (safe areas) that can be safely cropped on screens with different aspect ratios.
I agree regarding the preference-way; could you take a look at #57 and rework this to be optional and defined by string constant for example (defaulting to `CENTER_CROP` to be a non-breaking change)?
`<preference name="SplashScaleType" value="CENTER_CROP|CENTER_INSIDE" />`
You should probably send this proposal to the dev-list (dev@cordova.apache.org) so that people could vote and discuss.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165715932
Added a Jira issue: https://issues.apache.org/jira/browse/CB-10222 Add scaletype preference for Android splashscreen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-167639086
dev-list discussion thread: http://callback.markmail.org/thread/n42b7xoawqyn2vpv
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by trancee <gi...@git.apache.org>.
Github user trancee commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165635319
@daserge, that is correct, but that is why you can set a background color to fill out the area around it. at least there should be an option if you want it to stretch and cut off, or centered inside.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165483853
@trancee, if the image is smaller than the screen size it will not be scaled so there will be black area/stripes around it - I believe it is not the way it supposed to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org