You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/09/07 01:33:56 UTC

[GitHub] [nifi] mattyb149 edited a comment on issue #3645: NIFI-6543 Add support for onUnscheduled method in ExecuteGroovyScript Processor

mattyb149 edited a comment on issue #3645: NIFI-6543 Add support for onUnscheduled method in ExecuteGroovyScript Processor
URL: https://github.com/apache/nifi/pull/3645#issuecomment-529059498
 
 
   This should have a unit test and documentation to go along with it. A great addition would be unit test(s) for all the "onXYZ" lifecycle events, this was overlooked during the original contribution but we should have them for regression purposes. Having said that, only a test for `onUnscheduled()` is needed for this PR. Also please add a section to the `additionalDetails.html` near the discussion of the other lifecycle methods such as `onStart` and `onStop`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services