You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/02/20 07:14:03 UTC
Re: [PR] feat: add partner attribution for Snowflake [superset]
hainenber commented on code in PR #21364:
URL: https://github.com/apache/superset/pull/21364#discussion_r1962975392
##########
superset/db_engine_specs/snowflake.py:
##########
@@ -274,6 +275,7 @@ def build_sqlalchemy_uri(
query={
"role": parameters.get("role"),
"warehouse": parameters.get("warehouse"),
+ "application": os.environ.get("SF_PARTNER", "SUPERSET"),
Review Comment:
can we rename the env var to something more self-explained, like `SNOWFLAKE_PARTNER_APPLICATION_ID`. A bit verbose but I think everybody can understand straightaway what it means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org