You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/05 21:37:15 UTC
[GitHub] williaster commented on a change in pull request #5762: [SIP-5]
Refactor Paired t-test
williaster commented on a change in pull request #5762: [SIP-5] Refactor Paired t-test
URL: https://github.com/apache/incubator-superset/pull/5762#discussion_r215429434
##########
File path: superset/assets/src/visualizations/PairedTTest/TTestTable.jsx
##########
@@ -1,15 +1,24 @@
-import d3 from 'd3';
import dist from 'distributions';
-
import React from 'react';
import { Table, Tr, Td, Thead, Th } from 'reactable';
-import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
-import './paired_ttest.css';
+const propTypes = {
+ metric: PropTypes.string.isRequired,
+ groups: PropTypes.array.isRequired,
Review comment:
is this also `PropTypes.arrayOf(PropTypes.string).isRequired`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org