You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/09/07 18:45:50 UTC
[kudu-CR] [tools] Fix help text for replica type
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11400
Change subject: [tools] Fix help text for replica_type
......................................................................
[tools] Fix help text for replica_type
'kudu tablet change_config [add_replica|change_replica_type]' take an
argument for 'replica type', which the help text said had to be "VOTER"
or "NON-VOTER", but actually it has to be "VOTER" or "NON_VOTER",
because it is parsed into an enum by a generated PB function, and the PB
enum names are "VOTER" and "NON_VOTER". This fixes the help text.
Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/11400/1
--
To view, visit http://gerrit.cloudera.org:8080/11400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Fix help text for replica type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11400 )
Change subject: [tools] Fix help text for replica_type
......................................................................
[tools] Fix help text for replica_type
'kudu tablet change_config [add_replica|change_replica_type]' take an
argument for 'replica type', which the help text said had to be "VOTER"
or "NON-VOTER", but actually it has to be "VOTER" or "NON_VOTER",
because it is parsed into an enum by a generated PB function, and the PB
enum names are "VOTER" and "NON_VOTER". This fixes the help text.
Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
Reviewed-on: http://gerrit.cloudera.org:8080/11400
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tools] Fix help text for replica type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11400 )
Change subject: [tools] Fix help text for replica_type
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 07 Sep 2018 20:29:28 +0000
Gerrit-HasComments: No