You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smengcl (via GitHub)" <gi...@apache.org> on 2023/02/02 18:05:41 UTC
[GitHub] [ozone] smengcl commented on a diff in pull request #4125: HDDS-7277. [Snapshot] Implement snapshot key listing in Ozone Shell
smengcl commented on code in PR #4125:
URL: https://github.com/apache/ozone/pull/4125#discussion_r1094894719
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java:
##########
@@ -88,8 +88,10 @@ public void onMessage(final IncrementalContainerReportFromDatanode report,
// Ensure we reuse the same ContainerID instance in containerInfo
id = container.containerID();
} finally {
- if (!replicaProto.getState().equals(
+ if (replicaProto.getState().equals(
ContainerReplicaProto.State.DELETED)) {
+ nodeManager.removeContainer(dd, id);
+ } else {
Review Comment:
Is this change brought in accidentally by the merge conflict resolution?
https://github.com/apache/ozone/pull/4125/commits/b2bac5584d575dbf02eb1d52628a19a6034f2a81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org