You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/08/09 20:13:50 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7011: Remove imports from Traffic Router source files that were never used
ocket8888 opened a new pull request, #7011:
URL: https://github.com/apache/trafficcontrol/pull/7011
This just removes some imports that were never used from some Java files.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Router
## What is the best way to verify this PR?
Make sure all existing tests still pass. If anything was actually needed I'd expect compilation to fail.
## PR submission checklist
- [x] This PR utilizes existing tests
- [x] This PR doesn't need documentation
- [x] This PR doesn't need a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7011: Remove imports from Traffic Router source files that were never used
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman merged PR #7011:
URL: https://github.com/apache/trafficcontrol/pull/7011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7011: Remove imports from Traffic Router source files that were never used
Posted by codecov.
codecov[bot] commented on PR #7011:
URL: https://github.com/apache/trafficcontrol/pull/7011#issuecomment-1402146044
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7011?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7011](https://codecov.io/gh/apache/trafficcontrol/pull/7011?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (809ce23) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/0a30f458ac0ff2ca4e653cae01b81cb39aa5a06e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a30f45) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7011 +/- ##
=========================================
Coverage 26.11% 26.11%
Complexity 98 98
=========================================
Files 648 648
Lines 76057 76057
Branches 90 90
=========================================
Hits 19862 19862
Misses 54362 54362
Partials 1833 1833
```
| Flag | Coverage Δ | |
|---|---|---|
| traffic_router_unit | `29.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rol/traffic\_router/protocol/RouterNioEndpoint.java](https://codecov.io/gh/apache/trafficcontrol/pull/7011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvY29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvcHJvdG9jb2wvUm91dGVyTmlvRW5kcG9pbnQuamF2YQ==) | `1.66% <ø> (ø)` | |
| [...control/traffic\_router/shared/ZoneTestRecords.java](https://codecov.io/gh/apache/trafficcontrol/pull/7011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19yb3V0ZXIvc2hhcmVkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90cmFmZmljX2NvbnRyb2wvdHJhZmZpY19yb3V0ZXIvc2hhcmVkL1pvbmVUZXN0UmVjb3Jkcy5qYXZh) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org