[jira] [Comment Edited] (AIRFLOW-6851) Logging level: inconsistency between doc/implementation/tests

["Noël BARDELOT (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041132#comment-17041132 ] 

Noël BARDELOT edited comment on AIRFLOW-6851 at 2/20/20 4:55 PM:
-----------------------------------------------------------------

After analyzing the configuration.py behaviour I understand that the new [Logging] section's logging_level is deprecating the [Core] similar options. This is undocumented (those options do not appear as “deprecated” in the configuration reference).

 

Plus, the behaviour of logging_level is not consistent with the gunicorn logs that are INFO whatever airflow's logging level is. This should be documented as well, and probably clearly stated in the logging_level option's comment in the config file in my opinion.

 


was (Author: nbardelot):
After analyzing the configuration.py behaviour I understand that the [Logging] section's logging_level is deprecated (as are several other options). This is undocumented (those options do not appear as “deprecated” in the configuration reference, though they still work).

 

Plus, the behaviour of [Core]'s logging_level is not consistent with the gunicorn logs that are INFO whatever airflow's logging level is. This should be documented as well, and probably clearly stated in the [Core] logging_level option comment in the config file in my opinion.

 

> Logging level: inconsistency between doc/implementation/tests
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-6851
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6851
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 1.10.9
>            Reporter: Noël BARDELOT
>            Priority: Minor
>
> The documentation at [https://airflow.apache.org/docs/stable/configurations-ref.html] only states that there is a configuration for the logging level for Core (corresponding to AIRFLOW__CORE__LOGGING_LEVEL).
>  
> But in the tests (tests/test_configuration.py) and the default configuration file another logging level option exists under Logging :
>  
>  @conf_vars({
>         ('logging', 'logging_level'): None,
>         ('core', 'logging_level'): None,
>     })
>  
> And when following the documentation and setting AIRFLOW__CORE__LOGGING_LEVEL to WARN there are INFO lines in the logs.
>  
> Those inconsistencies should be clarified in the doc, and fixed in the code if need be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)