You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ChenjunZou <gi...@git.apache.org> on 2018/06/22 10:26:16 UTC

[GitHub] spark pull request #21613: [SPARK-24629][SQL]thrift server memory leaks when...

GitHub user ChenjunZou opened a pull request:

    https://github.com/apache/spark/pull/21613

    [SPARK-24629][SQL]thrift server memory leaks when Beeline session is closed

    ## What changes were proposed in this pull request?
    
    Maintaining a running statement map.
    When the session is closed, the relative statements should receive a cancel event. 
    
    ## How was this patch tested?
    the attached UI show statements is successfully cancelled in UI.
    <img width="1263" alt="3333" src="https://user-images.githubusercontent.com/2654887/41772001-94117874-7649-11e8-9701-6edf13593b9d.png">
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ChenjunZou/spark mem-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21613.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21613
    
----
commit bc647cc135edb7f05a47a1eccbd33a8faa410253
Author: zouchenjun <zo...@...>
Date:   2018-06-15T08:53:45Z

    add cancel status

commit 31a3d3fb22c6231622489c3fdbd6b282775c6b93
Author: zouchenjun <zo...@...>
Date:   2018-06-22T08:35:30Z

    fix memory leak when beeline close connection to thrift server

commit 4a6d2e9d52e097f2ecd9c27a5b85253451341874
Author: zouchenjun <zo...@...>
Date:   2018-06-22T09:51:03Z

    bug fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21613: [SPARK-24629][SQL]thrift server memory leaks when Beelin...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21613
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21613: [SPARK-24629][SQL]thrift server memory leaks when Beelin...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21613
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21613: [SPARK-24629][SQL]thrift server memory leaks when Beelin...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21613
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21613: [SPARK-24629][SQL]thrift server memory leaks when Beelin...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/21613
  
    cc @liufengdb 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org