[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9168: Add healthcheck metric to pinot-server

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9168:
URL: https://github.com/apache/pinot/pull/9168#discussion_r939319837


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -75,6 +75,9 @@ public enum ServerMeter implements AbstractMetrics.Meter {
   INDEXING_FAILURES("attributeValues", true),
   QUERY_HAS_MV_SELECTION_ORDER_BY("queryHasMVSelectionOrderBy", false),
 
+  HEALTHCHECK_OK_CALLS("healthcheck", true),

Review Comment:
   Should we separate the liveness check and readiness check? Currently we are adding the readiness check meter, so suggest naming them `READINESS_CHECK_OK_CALLS`



##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/HealthCheckResource.java:
##########
@@ -90,11 +95,13 @@ public String checkReadiness() {
     return getReadinessStatus(_instanceId);
   }
 
-  private static String getReadinessStatus(String instanceId) throws WebApplicationException {
+  private String getReadinessStatus(String instanceId) throws WebApplicationException {

Review Comment:
   (minor) No need to pass in the member variable
   ```suggestion
     private String getReadinessStatus() throws WebApplicationException {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org