You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2024/04/26 12:35:00 UTC

[jira] [Updated] (HDDS-10762) Review/discuss SchemaV3's prefix_seek optimization

     [ https://issues.apache.org/jira/browse/HDDS-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Doroszlai updated HDDS-10762:
------------------------------------
    Issue Type: Task  (was: Test)

> Review/discuss SchemaV3's prefix_seek optimization
> --------------------------------------------------
>
>                 Key: HDDS-10762
>                 URL: https://issues.apache.org/jira/browse/HDDS-10762
>             Project: Apache Ozone
>          Issue Type: Task
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: István Fajth
>            Priority: Major
>
> As part of HDDS-10744, I ran into the prefix_seek optimization in RocksDB, and the changes in how we access the DB in order to have this optimization.
> The cost side of it is that we have a String key for the column families in the DataNode's RocksDB, starting with the container id, then a separator, then the same key we had in schema_v2 as I understand.
> In order to deal with this, we need to do a lot of conversions, and copies along the lines as it seems, we have the FixedLengthStringCodec class, and we also have the StringUtils class, and we may also have a few other used conversion methods, with which during accessing the RocksDB, we convert from long to byte[] to String or from String to byte[] or byte[] to String, or in some code paths we do multiple conversions combining these conversions together.
> Prefix_seek promises to spare some I/O cycles and some CPU cycles with workloads that are a good fit for the feature (ours seems to be one of them), but looking at our code and the things that are there to have this, I am not sure we have an overall benefit from the prefix_seek optimization considering maintainability, understandability, and the cost of that many runtime conversions.
> I wanted to have a note on this concern.
> CC: [~ritesh], [~szetszwo], [~markgui]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org