[GitHub] gianm commented on issue #6302: Add SQL id, request logs, and metrics

[GitBox <gi...@apache.org>]

gianm commented on issue #6302: Add SQL id, request logs, and metrics
URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-454437930
 
 
   @gaodayue thanks for merging with master. We'll need to fix the inspection report since otherwise it will start failing for master as well. Could you look into it? There are three I see:
   
   > "QueryMetrics.java:210: sqlQueryId() Parameter query is not used in either this method or any of its derived methods."
   
   It's an extension point, not meant to be used by Druid production code. Annotating it with `@PublicApi` (or `@SuppressWarnings("unused")`) will tell that to the static analyzer, & it should stop complaining.
   
   > "QueryMetrics.java:210: sqlQueryId() Method is never used as a member of this interface, but only as a member of the implementation class(es). The project will stay compilable if the method is removed from the interface."
   
   I think doing (1) should fix this too.
   
   > "ComposingRequestLoggerProvider.java:128: accept() The declared exception IOException is never thrown in method implementations"
   
   This looks like a bug in the inspection. It looks like RequestLogLineConsumer declares `throws IOException` and its implementations do too, so there is no issue with the code. If that's right, then try working around this by adding `//noinspection RedundantThrows` before the `void accept(...` line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org