You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/09/09 04:20:56 UTC
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1996
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
[ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Update docs to reflect the new enforcement of semicolon
after every statement.
- Add missing semicolons to SET statements in examples.
Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1996/1
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
index 99954f7..658190b 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
@@ -19,7 +19,7 @@
# <a id="DDL_and_DML_statements">5. DDL and DML statements</a>
- Statement ::= ( SingleStatement ( ";" )? )* <EOF>
+ Statement ::= ( ( SingleStatement )? ( ";" )+ )* <EOF>
SingleStatement ::= DatabaseDeclaration
| FunctionDeclaration
| CreateStatement
@@ -28,7 +28,7 @@
| SetStatement
| InsertStatement
| DeleteStatement
- | Query ";"
+ | Query
In addition to queries, an implementation of SQL++ needs to support statements for data definition
and manipulation purposes as well as controlling the context to be used in evaluating SQL++ expressions.
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
index 9d42b00..1b392fe 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
@@ -44,7 +44,7 @@
##### Example
- SET `compiler.parallelism` "16"
+ SET `compiler.parallelism` "16";
SELECT u.name AS uname, m.message AS message
FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;
@@ -71,7 +71,7 @@
##### Example
- SET `compiler.groupmemory` "64MB"
+ SET `compiler.groupmemory` "64MB";
SELECT msg.authorId, COUNT(*)
FROM GleambookMessages msg
@@ -79,7 +79,7 @@
##### Example
- SET `compiler.sortmemory` "67108864"
+ SET `compiler.sortmemory` "67108864";
SELECT VALUE user
FROM GleambookUsers AS user
@@ -87,7 +87,7 @@
##### Example
- SET `compiler.joinmemory` "132000KB"
+ SET `compiler.joinmemory` "132000KB";
SELECT u.name AS uname, m.message AS message
FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3908/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1: Contrib-1
Analytics Compatibility Tests Failed Build 2543
: UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/830/ (8/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
[ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Update docs to reflect the new enforcement of semicolon
after every statement.
- Add missing semicolons to SET statements in examples.
Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1996
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Objections:
Anon. E. Moose #1000171:
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
index 99954f7..658190b 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
@@ -19,7 +19,7 @@
# <a id="DDL_and_DML_statements">5. DDL and DML statements</a>
- Statement ::= ( SingleStatement ( ";" )? )* <EOF>
+ Statement ::= ( ( SingleStatement )? ( ";" )+ )* <EOF>
SingleStatement ::= DatabaseDeclaration
| FunctionDeclaration
| CreateStatement
@@ -28,7 +28,7 @@
| SetStatement
| InsertStatement
| DeleteStatement
- | Query ";"
+ | Query
In addition to queries, an implementation of SQL++ needs to support statements for data definition
and manipulation purposes as well as controlling the context to be used in evaluating SQL++ expressions.
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
index 9d42b00..1b392fe 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
@@ -44,7 +44,7 @@
##### Example
- SET `compiler.parallelism` "16"
+ SET `compiler.parallelism` "16";
SELECT u.name AS uname, m.message AS message
FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;
@@ -71,7 +71,7 @@
##### Example
- SET `compiler.groupmemory` "64MB"
+ SET `compiler.groupmemory` "64MB";
SELECT msg.authorId, COUNT(*)
FROM GleambookMessages msg
@@ -79,7 +79,7 @@
##### Example
- SET `compiler.sortmemory` "67108864"
+ SET `compiler.sortmemory` "67108864";
SELECT VALUE user
FROM GleambookUsers AS user
@@ -87,7 +87,7 @@
##### Example
- SET `compiler.joinmemory` "132000KB"
+ SET `compiler.joinmemory` "132000KB";
SELECT u.name AS uname, m.message AS message
FROM GleambookUsers u JOIN GleambookMessages m ON m.authorId = u.id;
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md:
PS1, Line 22: <STRING_LITERAL>
> I believe this should be implicit since the new syntax of Statement enforce
OK, that should be fine then.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1749/ (5/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3908/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1443/ (6/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1: Contrib+1
BAD Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1734/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/831/ (7/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1506/ (10/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md:
PS1, Line 22: <STRING_LITERAL>
Have semi-colon after this?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md:
PS1, Line 22: <STRING_LITERAL>
> Have semi-colon after this?
I believe this should be implicit since the new syntax of Statement enforces ";" after every SingleStatement. Since SetStatement is a SingleStatement, maybe we shouldn't add ";" here. Otherwise we will have to update all statements in the docs and end them with ";". What do you think?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4901/ (3/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/825/ (9/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1166/ (2/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1562/ (4/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1734/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6382/ (1/10)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No