You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/06 20:27:28 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #12142: Bugfix: Make doc_md field nullable and raise json for non-existing dag in dag detail endpoint
ephraimbuddy opened a new pull request #12142:
URL: https://github.com/apache/airflow/pull/12142
This PR fixes 2 of the 3 issues in #12121
Issues fixed:
1. Calling this endpoint dags/{dag_id}/details returns an error due to doc_md field that's not nullable.
2. The dag details endpoint GET /dags/{dag_id}/details does not return a json if dag does not exist.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12142: Bugfix: Make doc_md field nullable and raise json for non-existing dag in dag detail endpoint
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12142:
URL: https://github.com/apache/airflow/pull/12142#issuecomment-723420994
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #12142: Bugfix: Make doc_md field nullable and raise json for non-existing dag in dag detail endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #12142:
URL: https://github.com/apache/airflow/pull/12142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #12142: Bugfix: Make doc_md field nullable and raise json for non-existing dag in dag detail endpoint
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #12142:
URL: https://github.com/apache/airflow/pull/12142#issuecomment-723426742
For some reasons that I don't know, within the unit test code, it was not raising SerialisedDagNotFound exception but raises it in postman, so I have the two checks in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #12142: Bugfix: Make doc_md field nullable and raise json for non-existing dag in dag detail endpoint
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #12142:
URL: https://github.com/apache/airflow/pull/12142#issuecomment-723421440
> Would it be possible to add test for it? Not a blocker, so I approve it now, but would be nice to add it
Ah, I forgot that. I will add it now. Thanks 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org