You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/15 01:49:36 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #35854: [SPARK-38549][SS] Add numRowsDroppedByWatermark to SessionWindowStateStoreRestoreExec

HeartSaVioR commented on pull request #35854:
URL: https://github.com/apache/spark/pull/35854#issuecomment-1067476924


   Thanks for the fix! 
   
   Would you mind adding the actual tests or steps you've gone through manual tests?
   And given state store write is the operator in charge to report the metrics in streaming listener, would it be coupled with the metric "numRowsDroppedByWatermark" in SessionWindowStateStoreSaveExec? If not, shall we spend time a bit to see whether it is feasible or not?
   
   Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org