[GitHub] [hbase] virajjasani commented on a change in pull request #4092: HBASE-26712 Balancer encounters NPE in rare case

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #4092:
URL: https://github.com/apache/hbase/pull/4092#discussion_r797571153



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -4095,4 +4095,17 @@ public String getClusterId() {
   public Collection<ServerName> getLiveRegionServers() {
     return regionServerTracker.getRegionServers();
   }
+
+  @RestrictedApi(explanation = "Should only be called in tests", link = "",
+      allowedOnPath = ".*/src/test/.*")
+  void setLoadBalancer(RSGroupBasedLoadBalancer loadBalancer) {

Review comment:
       Good to add explicit comments for both of these methods that they are only supposed to be used by test code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org