You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/09 02:36:50 UTC
[GitHub] [skywalking] wayilau opened a new pull request #4467: Remove &
Simplfy redundancy code.
wayilau opened a new pull request #4467: Remove & Simplfy redundancy code.
URL: https://github.com/apache/skywalking/pull/4467
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- [x] Refactor
- Related issues
Remove & Simplfy redundancy code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4467: Remove & Simplfy
redundancy code.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4467: Remove & Simplfy redundancy code.
URL: https://github.com/apache/skywalking/pull/4467#issuecomment-596312581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=h1) Report
> Merging [#4467](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cbc692908fae97d44b4520eaa334efbd0c7f00f1?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4467 +/- ##
==========================================
+ Coverage 24.94% 24.97% +0.03%
==========================================
Files 1231 1231
Lines 28504 28496 -8
Branches 3907 3905 -2
==========================================
+ Hits 7111 7118 +7
+ Misses 20734 20719 -15
Partials 659 659
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...rage/plugin/jdbc/h2/dao/H2AggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWdncmVnYXRpb25RdWVyeURBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=footer). Last update [cbc6929...2bffdfc](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4467: Remove & Simplfy
redundancy code.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4467: Remove & Simplfy redundancy code.
URL: https://github.com/apache/skywalking/pull/4467
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4467: Remove &
Simplfy redundancy code.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4467: Remove & Simplfy redundancy code.
URL: https://github.com/apache/skywalking/pull/4467#issuecomment-596312581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=h1) Report
> Merging [#4467](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cbc692908fae97d44b4520eaa334efbd0c7f00f1?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4467 +/- ##
==========================================
+ Coverage 24.94% 24.97% +0.03%
==========================================
Files 1231 1231
Lines 28504 28496 -8
Branches 3907 3905 -2
==========================================
+ Hits 7111 7118 +7
+ Misses 20734 20719 -15
Partials 659 659
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...rage/plugin/jdbc/h2/dao/H2AggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWdncmVnYXRpb25RdWVyeURBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4467/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=footer). Last update [cbc6929...2bffdfc](https://codecov.io/gh/apache/skywalking/pull/4467?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services