Re: tz encoding

[Steve Loughran <st...@iseran.com>]

Steve Loughran wrote:

> I dont think I can fix this in the next 15 minutes of code-time left 
> this year, but will write some more tests with more explicit TZ and 
> month options.

Glen,

I see you have commented out the tests that I added because they break 
the system.

Even before those tests were added, the unit tests do not work on my box 
in GMT0BST time zone, so commenting them out does not fix the build on 
my system. All you are doing is hiding the problem from the main build, 
when it is still out there.

If we have tests that fail, I dont think commenting them out is the best 
way of avoiding running them. The alternate solution is to exclude them 
from the main build and then use a special ant target to run 
tests-that-fail. But commenting them out is not test-first development, 
and makes it too easy to forget that the defect exists.

(This is a situation that XP doesnt cover: what if you have defects you 
can test for but not fix)

-steve