You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/27 05:15:30 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #17849: fix: delete sqlite files after jdbc connection closed
tisonkun opened a new pull request, #17849:
URL: https://github.com/apache/pulsar/pull/17849
This closes #17713.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17849: fix: SqliteJdbcSinkTest close in order
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17849:
URL: https://github.com/apache/pulsar/pull/17849#issuecomment-1259077978
cc @lhotari @poorbarcode
The root cause is that we run `connection.commit` concurrently in `flush` and `close` so it's possible that:
```
db.exec("commit;") // in flush
db.exec("commit;") // in close
db.exec("begin;") // in flush
```
so the second call failed with "no transaction is active".
The last commit in this patch can be overkill but it's a strong guarantee that we don't run into this situation. I'm glad to learn if we have a more lightweight solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17849: fix: SqliteJdbcSinkTest close in order
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17849:
URL: https://github.com/apache/pulsar/pull/17849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17849: fix: SqliteJdbcSinkTest close in order
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17849:
URL: https://github.com/apache/pulsar/pull/17849#issuecomment-1259100390
I think I can use `shutdown` + `awaitTermination` here to simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17849: fix: SqliteJdbcSinkTest close in order
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17849:
URL: https://github.com/apache/pulsar/pull/17849#issuecomment-1260337465
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17849: fix: SqliteJdbcSinkTest close in order
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17849:
URL: https://github.com/apache/pulsar/pull/17849#issuecomment-1259178599
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org