You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/20 18:57:08 UTC

[kudu-CR] tsan: remove two old suppressions 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3411

to review the following change.

Change subject: tsan: remove two old suppressions
......................................................................

tsan: remove two old suppressions

This removes two TSAN suppressions which have been in the list since the
very first TSAN commit. I went back and looked at that code review and
can't find any explanation for them, and initial local testing with them
removed doesn't seem to turn anything up.

Maybe we've since addressed these and just didn't remove them. Let's
remove them, and if we start to see any TSAN flakes due to them, we can
add them back with an appropriate comment explaining why they're
required.

Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
---
M build-support/tsan-suppressions.txt
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3411/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] tsan: remove two old suppressions

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: tsan: remove two old suppressions
......................................................................


Patch Set 1: Code-Review+2

Okay, sure.

-- 
To view, visit http://gerrit.cloudera.org:8080/3411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] tsan: remove two old suppressions

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: tsan: remove two old suppressions
......................................................................


tsan: remove two old suppressions

This removes two TSAN suppressions which have been in the list since the
very first TSAN commit. I went back and looked at that code review and
can't find any explanation for them, and initial local testing with them
removed doesn't seem to turn anything up.

Maybe we've since addressed these and just didn't remove them. Let's
remove them, and if we start to see any TSAN flakes due to them, we can
add them back with an appropriate comment explaining why they're
required.

Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Reviewed-on: http://gerrit.cloudera.org:8080/3411
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/tsan-suppressions.txt
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] tsan: remove two old suppressions

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: tsan: remove two old suppressions
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1888/

-- 
To view, visit http://gerrit.cloudera.org:8080/3411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No