You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2004/03/25 02:07:34 UTC
DO NOT REPLY [Bug 20380] -
AccessLogValve incorrectly calculates timezone
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=20380>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=20380
AccessLogValve incorrectly calculates timezone
jt@essential.com.au changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jt@essential.com.au
Status|RESOLVED |REOPENED
Resolution|FIXED |
Version|4.1.24 |4.1.30
------- Additional Comments From jt@essential.com.au 2004-03-25 01:07 -------
The offset still appears to be incorrect, though for a different reason that
that originally reported: the timezone offset output does not include daylight
saving. At the moment:
x.x.x.x - - [25/Mar/2004:10:17:07 +0930] "GET / HTTP/1.1" 304 -
should be reported as:
x.x.x.x - - [25/Mar/2004:10:17:07 +1030] "GET / HTTP/1.1" 304 -
Looking at org.apache.catalina.valves.AccessLogValve (4.1.30), line 1128 is:
timeZone = calculateTimeZoneOffset(tz.getRawOffset());
I think this should use the TimeZone.getOffset() method instead, which returns
the offset including DST. AFAICS from the CVS history the getRawOffset() method
has always been used.
Considering the length of time this has been in the source, either (a) I'm
wrong, or (b) few people care.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org