You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Joshua Slive <jo...@slive.ca> on 2005/11/16 16:55:03 UTC
AuthBasicProvider Off
From a quick reading of the code,
AuthBasicProvider Off
and
AuthBasicProvider On
have exactly the same effect. This is silly. "Off" should probably be
removed and "On" renamed to "default".
Joshua.
Re: AuthBasicProvider Off
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Wed, Nov 16, 2005 at 11:20:53AM -0500, Joshua Slive wrote:
> >How does that sound? -- justin
>
> Yes, that's a better idea.
Done in trunk and branches/2.2.x now. Thanks. -- justin
Re: AuthBasicProvider Off
Posted by Joshua Slive <jo...@slive.ca>.
Justin Erenkrantz wrote:
> On Wed, Nov 16, 2005 at 10:55:03AM -0500, Joshua Slive wrote:
>> From a quick reading of the code,
>> AuthBasicProvider Off
>> and
>> AuthBasicProvider On
>> have exactly the same effect. This is silly. "Off" should probably be
>> removed and "On" renamed to "default".
>
> Oh. I see. Because our backwards-compatiblity code kicks in when there
> isn't a provider specified. Heh.
>
> FWIW, mod_dav has this same syntax (which is where this code
> originated). I wouldn't have any serious problems just removing those
> checks around line 59 (making that last else clause be unconditional).
> This would lead to rejecting On and Off as values for those directives.
>
> How does that sound? -- justin
Yes, that's a better idea.
Joshua.
Re: AuthBasicProvider Off
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Wed, Nov 16, 2005 at 10:55:03AM -0500, Joshua Slive wrote:
> From a quick reading of the code,
> AuthBasicProvider Off
> and
> AuthBasicProvider On
> have exactly the same effect. This is silly. "Off" should probably be
> removed and "On" renamed to "default".
Oh. I see. Because our backwards-compatiblity code kicks in when there
isn't a provider specified. Heh.
FWIW, mod_dav has this same syntax (which is where this code
originated). I wouldn't have any serious problems just removing those
checks around line 59 (making that last else clause be unconditional).
This would lead to rejecting On and Off as values for those directives.
How does that sound? -- justin