You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by goya <gi...@git.apache.org> on 2017/06/14 02:17:17 UTC
[GitHub] cordova-lib pull request #563: Cb 11713 11961
GitHub user goya opened a pull request:
https://github.com/apache/cordova-lib/pull/563
Cb 11713 11961
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
N/A
### What does this PR do?
Fixes for the following issues:
CB-11961 do a shallow clone if git_ref is a remote ref
CB-11713 no CLI feedback on plugin version installed during plugin install
### What testing has been done on this change?
jasmine tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/goya/cordova-lib CB-11713_11961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #563
----
commit 60fd1c44f23687ac15a1f880eebc1e5798af58de
Author: brett rudd <br...@gmail.com>
Date: 2017-06-13T22:01:31Z
CB-11713 no CLI feedback on plugin version installed during plugin install
commit f3e90fc6e37fc5c9efde161d4353bec2258dc201
Author: Brett Rudd <br...@gmail.com>
Date: 2016-11-28T21:38:09Z
CB-11961 do a shallow clone if git_ref is a remote ref
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #563: CB-11713 and CB-11961
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/563
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=h1) Report
> Merging [#563](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/e69b9e4efc69054e22b40d89db9f310ec4ec3ba9?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 80.12% 80.17% +0.04%
==========================================
Files 57 57
Lines 3960 3969 +9
Branches 832 832
==========================================
+ Hits 3173 3182 +9
Misses 787 787
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/gitclone.js](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=tree#diff-c3JjL2dpdGNsb25lLmpz) | `100% <100%> (ø)` | :arrow_up: |
| [src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `84.59% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=footer). Last update [e69b9e4...1c820da](https://codecov.io/gh/apache/cordova-lib/pull/563?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #563: CB-11713 and CB-11961
Posted by goya <gi...@git.apache.org>.
Github user goya commented on the issue:
https://github.com/apache/cordova-lib/pull/563
oh well ill just leave this here until master gets working tests again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #563: CB-11713 and CB-11961
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/563
Thanks for waiting @goya ! @stevengill, @audreyso and I are working on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #563: CB-11713 and CB-11961
Posted by goya <gi...@git.apache.org>.
Github user goya closed the pull request at:
https://github.com/apache/cordova-lib/pull/563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #563: CB-11713 and CB-11961
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/563
@goya CI should be passing now, you'll need to rebase as a bunch of files moved around as part of the plugin command refactor and test speed improvements we landed.
The `spec-plugman/fetch.spec.js` file moved to `integration-tests/plugman_fetch.spec.js` now I believe. Worth noting that we are doing a big push to move away from I/O-heavy integration tests as much as possible, and instead write out unit tests for each module. It'd be nice if you could follow that pattern in this PR as well. I'm also happy to help with that if you want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #563: CB-11713 and CB-11961
Posted by goya <gi...@git.apache.org>.
Github user goya commented on the issue:
https://github.com/apache/cordova-lib/pull/563
should be fixed now. got bit by false git documentation on git < 2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org