You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/03/28 16:02:26 UTC

[GitHub] [camel-k] gansheer commented on a diff in pull request #4182: add startup probes into the health trait

gansheer commented on code in PR #4182:
URL: https://github.com/apache/camel-k/pull/4182#discussion_r1150849243


##########
pkg/apis/camel/v1/trait/health.go:
##########
@@ -54,4 +54,19 @@ type HealthTrait struct {
 	ReadinessSuccessThreshold int32 `property:"readiness-success-threshold" json:"readinessSuccessThreshold,omitempty"`
 	// Minimum consecutive failures for the readiness probe to be considered failed after having succeeded.
 	ReadinessFailureThreshold int32 `property:"readiness-failure-threshold" json:"readinessFailureThreshold,omitempty"`
+
+	// Configures the startup probe for the integration container (default `true`).
+	StartupProbeEnabled *bool `property:"startup-probe-enabled" json:"startupProbeEnabled,omitempty"`

Review Comment:
   It could also be linked to what is written at the beginning of this PR https://github.com/apache/camel-k/pull/2719, it is preferable to have it enabled to use it to reconcile the Integration phase and readiness condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org