[GitHub] [geode] mivanac opened pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["mivanac (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [*] Is your initial contribution a single, squashed commit?

- [*] Does `gradlew build` run cleanly?

- [*] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["mivanac (GitHub)" <gi...@apache.org>]

I introduced logic simular to borrowConnection, because if connectins in pool are not up to maximum, why we could not create new connection. And if "onlyUseExistingCnx" is set to false, we will create new connection, even if we exceed maximum.
But, I can return to previous implementation.

[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["agingade (GitHub)" <gi...@apache.org>]

If the tryCreate() is true, and for any reason, unable to create connection, it should be in the loop till the specified timeout (server-timeout), right? throwing an exception here will return before the specified wait time. 

[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["agingade (GitHub)" <gi...@apache.org>]

Agree with your thinking in relation to max-connection; but this arguments seems to enforce that only existing connection needs to be used.

[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac closed pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["mivanac (GitHub)" <gi...@apache.org>]

[ pull request closed by mivanac ]

[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4833: Feature/geode 6536 2: Added retry in borrowConnection/single hop

["mivanac (GitHub)" <gi...@apache.org>]

As I said, logic is the same as for borrowConnection(), so I would not change this logic.

[ Full content available at: https://github.com/apache/geode/pull/4833 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org