[GitHub] [commons-pool] psteitz commented on pull request #199: [POOL-393] Improve BaseGenericObjectPool's JMX Register performance

[GitBox <gi...@apache.org>]

psteitz commented on PR #199:
URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1369218259

   Sorry to be late responding here and great to see you working on pool, Niall!  Looks good to me.  And I like it better than my previous attempt because it keeps the sequence of identifiers contiguous.  We do need to worry about concurrent access, but the only contention issue that I can see is the if name check succeeds for one thread and another grabs it, but the code catches the exception that would happen in that case and increments.  So should be fine.  One small nit is pls get rid of the system out in the unit test.  There is already too much spewage from [pool] unit tests (some of it my fault I am sure).  Sorry again to be slow to respond.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org