[GitHub] [flink] JingsongLi opened a new pull request #10183: [FLINK-14743][table-blink] Optimize BaseRowSerializer to use Projection instead of switch

[GitBox <gi...@apache.org>]

JingsongLi opened a new pull request #10183: [FLINK-14743][table-blink] Optimize BaseRowSerializer to use Projection instead of switch
URL: https://github.com/apache/flink/pull/10183
 
 
   
   ## What is the purpose of the change
   
   In BaseRowSerializer, we use `BinaryWriter.write` and `TypeGetterSetters.get` to convert BaseRow to BinaryRow. However, they use switch to select type to invoke specific method. This will cause a lot of branch prediction errors for CPU. Results in low performance.
   
   ## Brief change log
   
   Use ProjectionCodeGenerator to code generate these logical.
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services