You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2017/01/31 00:41:09 UTC
Review Request 56104: not to create AEQ for acceor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-2384
https://issues.apache.org/jira/browse/GEODE-2384
Repository: geode
Description
-------
Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot start due to AEQ has no persistent.
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java 0b6685d
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 254156f
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java PRE-CREATION
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java aaa6dbd
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java c4081c5
Diff: https://reviews.apache.org/r/56104/diff/
Testing
-------
Modified some tests and added persistent test for query.
precheckin
Thanks,
xiaojian zhou
Re: Review Request 56104: not to create AEQ for acceor
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/#review163722
-----------------------------------------------------------
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java (line 96)
<https://reviews.apache.org/r/56104/#comment235210>
These tests will pass because they throw an IllegalArgumentException here. I don't think that's what you intended.
- Dan Smith
On Jan. 31, 2017, 10:11 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56104/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:11 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-2384
> https://issues.apache.org/jira/browse/GEODE-2384
>
>
> Repository: geode
>
>
> Description
> -------
>
> Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot start due to AEQ has no persistent.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java 0b6685d
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 254156f
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java c4081c5
>
> Diff: https://reviews.apache.org/r/56104/diff/
>
>
> Testing
> -------
>
> Modified some tests and added persistent test for query.
> precheckin
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 56104: not to create AEQ for acceor
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/#review163760
-----------------------------------------------------------
Ship it!
Aggg, I'm sorry, I misread the code. You added a new test. This looks good!
- Dan Smith
On Jan. 31, 2017, 10:11 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56104/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 10:11 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-2384
> https://issues.apache.org/jira/browse/GEODE-2384
>
>
> Repository: geode
>
>
> Description
> -------
>
> Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot start due to AEQ has no persistent.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java 0b6685d
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 254156f
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java c4081c5
>
> Diff: https://reviews.apache.org/r/56104/diff/
>
>
> Testing
> -------
>
> Modified some tests and added persistent test for query.
> precheckin
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 56104: not to create AEQ for acceor
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 10:11 p.m.)
Review request for geode and Dan Smith.
Bugs: GEODE-2384
https://issues.apache.org/jira/browse/GEODE-2384
Repository: geode
Description
-------
Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot start due to AEQ has no persistent.
Diffs (updated)
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java 0b6685d
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 254156f
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java PRE-CREATION
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java c4081c5
Diff: https://reviews.apache.org/r/56104/diff/
Testing
-------
Modified some tests and added persistent test for query.
precheckin
Thanks,
xiaojian zhou
Re: Review Request 56104: not to create AEQ for acceor
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/#review163689
-----------------------------------------------------------
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java (line 99)
<https://reviews.apache.org/r/56104/#comment235165>
I think it would be better for this to throw the IllegalArgumentException or some other exception. Returning false indicates that we wait for the queue to flush and it didn't flush in the time alotted. In this case, the user called waitForFlush on an accessor, which I guess we don't support.
We should also update the javadocs for waitForFlush to indicate that it can't be called on an accessor. Although, actually, I think we may need to fix wait for flush to work from accessors and clients.
- Dan Smith
On Jan. 31, 2017, 12:41 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56104/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 12:41 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-2384
> https://issues.apache.org/jira/browse/GEODE-2384
>
>
> Repository: geode
>
>
> Description
> -------
>
> Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot start due to AEQ has no persistent.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java 0b6685d
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java 254156f
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java aaa6dbd
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java c4081c5
>
> Diff: https://reviews.apache.org/r/56104/diff/
>
>
> Testing
> -------
>
> Modified some tests and added persistent test for query.
> precheckin
>
>
> Thanks,
>
> xiaojian zhou
>
>