You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/05/26 07:48:08 UTC
[GitHub] [incubator-eventmesh] wallezhang opened a new issue, #896: [Enhancement] Add default ttl when building BatchMessage with non-cloud-event protocol
wallezhang opened a new issue, #896:
URL: https://github.com/apache/incubator-eventmesh/issues/896
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
When invoking `org.apache.eventmesh.client.grpc.util.EventMeshClientUtil#buildBatchMessages` method without `protocolType` parameter, there is no default value for `ttl` field. And `ttl` field is required for `org.apache.eventmesh.common.protocol.grpc.protos.BatchMessage.MessageItem` object, so if event mesh message has no `ttl` property, the method will throw a NPE.
<img width="672" alt="image" src="https://user-images.githubusercontent.com/33749/170442098-f58774fe-573f-4836-8d9d-c62da52e9f5a.png">
And there is another enhancement, for reducing `org.apache.eventmesh.common.protocol.grpc.protos.BatchMessage.Builder#setTopic` method calls, I think we should move this call to the outer of the loop.
### Describe the solution you'd like
If event mesh message has no `ttl` property, we should set a default value with `4000` like other building methods.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #896: [Enhancement] Add default ttl when building BatchMessage with non-cloud-event protocol
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #896:
URL: https://github.com/apache/incubator-eventmesh/issues/896#issuecomment-1138262981
Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D
Please make sure to include all the relevant context.
We will be here shortly.
If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description |Subscribe |Unsubscribe|Archive
| ---- | ---- |---- | ---- | ---- |
|Users |User support and questions mailing list| [Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
|Development |Development related discussions| [Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
|Commits |All commits to repositories| [Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #896: [Enhancement] Add default ttl when building BatchMessage with non-cloud-event protocol
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #896: [Enhancement] Add default ttl when building BatchMessage with non-cloud-event protocol
URL: https://github.com/apache/incubator-eventmesh/issues/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org