You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Harbs <ha...@gmail.com> on 2017/10/31 23:23:54 UTC
Re: [royale-asjs] branch develop updated: Fixes #24
My comment in the commit message needs discussion.
I think the change event should be removed. What do others think?
Harbs
> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 2072541 Fixes #24
> 2072541 is described below
>
> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>
> Fixes #24
>
> I’m not sure why we’re dispatching both a “selctedDateChanged” event and a “changed” event for the same action. It seems like we should dispatch one or the other.
> On the one hand, “change” is a standard name, so it’s easily discoverable. On the other hand, “change” is one of the special events which become BrowserEvents when dispatched.
> I think the change event should be removed.
> ---
> .../org/apache/royale/html/beads/DateChooserView.as | 16 ++++++++++++----
> .../html/beads/controllers/DateChooserMouseController.as | 1 -
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> index 2316f4a..17a5ef0 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
> private var daysContainer:DateChooserList;
>
> /**
> + * @royaleignorecoercion org.apache.royale.core.UIBase
> + */
> + private function getHost():UIBase
> + {
> + return _strand as UIBase;
> + }
> + /**
> * The button that causes the previous month to be displayed by the DateChooser.
> *
> * @langversion 3.0
> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
> _nextMonthButton.style.flexGrow = 0;
> monthButtonsContainer.addElement(_nextMonthButton);
>
> - UIBase(_strand).addElement(monthButtonsContainer, false);
> + getHost().addElement(monthButtonsContainer, false);
>
> // DAY NAMES
>
> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
> COMPILE::SWF {
> dayNamesContainer.percentWidth = 100;
> }
> - UIBase(_strand).addElement(dayNamesContainer, false);
> + getHost().addElement(dayNamesContainer, false);
>
> // DAYS
>
> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
> COMPILE::SWF {
> daysContainer.percentWidth = 100;
> }
> - UIBase(_strand).addElement(daysContainer, false);
> + getHost().addElement(daysContainer, false);
>
>
> IEventDispatcher(daysContainer).dispatchEvent( new Event("itemsCreated") );
> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
> var index:Number = model.getIndexForSelectedDate();
> daysContainer.selectedIndex = index;
>
> - IEventDispatcher(_strand).dispatchEvent(new Event("selectedDateChanged"));
> + getHost().dispatchEvent(new Event("selectedDateChanged"));
> + getHost().dispatchEvent( new Event("change") );
> }
>
> /**
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/DateChooserMouseController.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/DateChooserMouseController.as
> index d3ef05c..ccf3cbc 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/DateChooserMouseController.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/DateChooserMouseController.as
> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
> var list:DateChooserList = event.target as DateChooserList;
> var model:DateChooserModel = _strand.getBeadByType(IBeadModel) as DateChooserModel;
> model.selectedDate = list.selectedItem as Date;
> - IEventDispatcher(_strand).dispatchEvent( new Event("change") );
> }
>
> /**
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
No. We’re not copying the MouseEvent. There are getters, but they are specific to MouseEvent and KeyboardEvent, rather than BrowserEvent.
Whether it’s KeyboardEvent, MouseEvent or BrowserEvent, there is always going to be a constructor called which wraps the good event inside it.
Would it ultimately be less code in an app to remove MouseEvent and KeyboardEvent and use just BrowserEvent for a catch-all with getters for every property that MouseEvent and KeyboardEvent needs? Maybe, but I don’t think it would be a great user experience.
I think this is a reasonable trade-off. I think we need the MouseEvents and KeyboardEvents anyway for cross-platform compatibility. If a client wants to dispatch a MouseEvent or KeyboardEvent, smoke and mirrors will not work very well either (which is something I needed to do in my app). I actually created a “FakeMouseEvent” which subclasses MouseEvent, so I could assign my own target.
Harbs
> On Nov 1, 2017, at 10:05 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> Aren't we essentially making a copy of each MouseEvent? That doesn't
> sound right to me.
>
> Unless some code is actually checking the type:
>
> If (event is MouseEvent)
>
> it would seem to me to be far cheaper to just add new getters to
> BrowserEvent.
>
> And if we do want to support type-checking of MouseEvent, we could add a
> bead that extends Language.is/as and sees if it is a BrowserEvent and look
> inside at the native event.
>
> Smoke and mirrors...
>
> Thoughts?
> -Alex
>
> On 11/1/17, 11:22 AM, "Harbs" <ha...@gmail.com> wrote:
>
>> The only way to get MouseEvent and KeyboardEvent-specific properties was
>> by digging into the native event buried in the goog event.
>>
>> Additionally, client code is expecting KeyboardEvents and MouseEvents and
>> the expected properties was missing in the BrowserEvents. Before my
>> changes, MouseEvents and KeyboardEvents were actually never dispatched by
>> Royale.
>>
>> I don’t remember the exact details, but the impetus for me to make these
>> changes were errors and difficulties I had in my app.
>>
>> I don’t think the switch is terribly expensive, and I don’t see any
>> alternative.
>>
>>
>>> On Nov 1, 2017, at 8:10 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>>
>>> Those look like change logs, but I'm not recalling why you needed to do
>>> that. That looks pretty expensive to me.
>>>
>>> -Alex
>>>
>>> On 11/1/17, 10:33 AM, "Harbs" <harbs.lists@gmail.com
>>> <ma...@gmail.com>> wrote:
>>>
>>>> We discussed this a few months ago:
>>>>
>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
>>>> co
>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>> .co>
>>>>
>>>> m%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasi
>>>> c%
>>>>
>>>> 2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrappe
>>>> r.
>>>>
>>>> as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b
>>>> 34
>>>>
>>>> 438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4
>>>> kD
>>>> e%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0
>>>>
>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>> .c
>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>> .c>
>>>>
>>>> om%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBas
>>>> ic
>>>>
>>>> %2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapp
>>>> er
>>>>
>>>> .as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7
>>>> b3
>>>>
>>>> 4438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz
>>>> 4k
>>>> De%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0>
>>>>
>>>> Harbs
>>>>
>>>>> On Nov 1, 2017, at 7:12 PM, Alex Harui <aharui@adobe.com.INVALID
>>>>> <ma...@adobe.com.INVALID>> wrote:
>>>>>
>>>>> How did you "fix" that? The most obvious way that popped into my mind
>>>>> would be pretty expensive.
>>>>>
>>>>> Thanks,
>>>>> -Alex
>>>>>
>>>>> On 11/1/17, 8:45 AM, "Harbs" <harbs.lists@gmail.com
>>>>> <ma...@gmail.com>
>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>>>
>>>>>> FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types
>>>>>> and
>>>>>> not BrowserEvents as they are in the goog libraries.
>>>>>>
>>>>>> OK. Let’s get rid of selectedDateChanged.
>>>>>>
>>>>>>> On Nov 1, 2017, at 5:41 PM, Alex Harui <aharui@adobe.com.INVALID
>>>>>>> <ma...@adobe.com.INVALID>>
>>>>>>> wrote:
>>>>>>>
>>>>>>> AIUI, events generated by an HTMLElement are caught by Google
>>>>>>> Closure
>>>>>>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>>>>>> even
>>>>>>> things we think are MouseEvents are actually dispatched as
>>>>>>> BrowserEvents.
>>>>>>> So the actual type for lots of events on the JS side are not what
>>>>>>> the
>>>>>>> metadata says. I think only the events we dispatch directly don't
>>>>>>> get
>>>>>>> converted. So yes, that means that we are frequently lying about
>>>>>>> the
>>>>>>> event type, but since JS doesn't do runtime checking, as long as
>>>>>>> your
>>>>>>> code
>>>>>>> doesn't need to check the type (via "is" or "as") everything should
>>>>>>> "just
>>>>>>> work".
>>>>>>>
>>>>>>> I'm always interested in running less code, so dispatching two
>>>>>>> events
>>>>>>> seems unnecessary, and one should go away. I was only trying to
>>>>>>> say
>>>>>>> that
>>>>>>> I don't care about consistency that every property change event
>>>>>>> should
>>>>>>> be
>>>>>>> named "somePropertyChanged". IMO, it is ok for the most popular
>>>>>>> event
>>>>>>> to
>>>>>>> be just plain "change".
>>>>>>>
>>>>>>> My 2 cents,
>>>>>>> -Alex
>>>>>>>
>>>>>>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com
>>>>>>> <ma...@gmail.com>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> I’m not sure why/how, but I checked and the change event on the
>>>>>>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>>>>>>
>>>>>>>> Here’s what I get if I listen for both events and trace them to the
>>>>>>>> console:
>>>>>>>>
>>>>>>>> org.apache.royale.events.Event {type: "selectedDateChanged",
>>>>>>>> target:
>>>>>>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>>>>>> org.a…e.r…e.h…l.DateChooser,
>>>>>>>> propagationStopped_: false, defaultPrevented: false, …}
>>>>>>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>>>>>> g…g.e…s.BrowserEvent}
>>>>>>>>
>>>>>>>> The type, target and currentTarget properties are correct in the
>>>>>>>> BrowserEvent and the rest of the properties are undefined. So, I’m
>>>>>>>> not
>>>>>>>> sure that it really matters that it is a BrowserEvent, although the
>>>>>>>> construction of it has to be less efficient.
>>>>>>>>
>>>>>>>> Either way, do you agree that there should be only one of these two
>>>>>>>> events dispatched?
>>>>>>>>
>>>>>>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <aharui@adobe.com.INVALID
>>>>>>>>> <ma...@adobe.com.INVALID>
>>>>>>>>> <mailto:aharui@adobe.com.INVALID
>>>>>>>>> <ma...@adobe.com.INVALID>>>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> I think the most common event should have a simple name like
>>>>>>>>> "change".
>>>>>>>>> It
>>>>>>>>> makes it easier to remember.
>>>>>>>>>
>>>>>>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>>>>>>> initiated
>>>>>>>>> by an HTMLElement event. We are sort of taking advantage of the
>>>>>>>>> fact
>>>>>>>>> that
>>>>>>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>>>>>> type-check
>>>>>>>>> the event class.
>>>>>>>>>
>>>>>>>>> My 2 cents,
>>>>>>>>> -Alex
>>>>>>>>>
>>>>>>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>>>>>>>>> <ma...@gmail.com>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Nope.
>>>>>>>>>>
>>>>>>>>>> Copying my response from Github:
>>>>>>>>>>
>>>>>>>>>> The only place change is referenced in the Framework is in the
>>>>>>>>>> metadata
>>>>>>>>>> of DateChooser:
>>>>>>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>>>>>>
>>>>>>>>>> That could easily be changed to:
>>>>>>>>>> [Event(name="selectedDateChanged",
>>>>>>>>>> type="org.apache.royale.events.Event")]
>>>>>>>>>>
>>>>>>>>>> The current metadata is actually incorrect, because the event
>>>>>>>>>> type
>>>>>>>>>> is
>>>>>>>>>> org.apache.royale.events.BrowserEvent
>>>>>>>>>>
>>>>>>>>>> Harbs
>>>>>>>>>>
>>>>>>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>>>>>>> <piotrzarzycki21@gmail.com <ma...@gmail.com>
>>>>>>>>>>> <mailto:piotrzarzycki21@gmail.com
>>>>>>>>>>> <ma...@gmail.com>>
>>>>>>>>>>> <mailto:piotrzarzycki21@gmail.com
>>>>>>>>>>> <ma...@gmail.com>
>>>>>>>>>>> <mailto:piotrzarzycki21@gmail.com
>>>>>>>>>>> <ma...@gmail.com>>>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> You can remove it if it is not fired it up for some other cases
>>>>>>>>>>> in
>>>>>>>>>>> DateChooser.
>>>>>>>>>>>
>>>>>>>>>>> Piotr
>>>>>>>>>>>
>>>>>>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com
>>>>>>>>>>> <ma...@gmail.com>
>>>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>:
>>>>>>>>>>>
>>>>>>>>>>>> My comment in the commit message needs discussion.
>>>>>>>>>>>>
>>>>>>>>>>>> I think the change event should be removed. What do others
>>>>>>>>>>>> think?
>>>>>>>>>>>>
>>>>>>>>>>>> Harbs
>>>>>>>>>>>>
>>>>>>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org
>>>>>>>>>>>>> <ma...@apache.org>
>>>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>>
>>>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>
>>>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>>>>>> repository.
>>>>>>>>>>>>>
>>>>>>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>>>>>>> in repository
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2F>
>>>>>>>>>>>>> gi
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fgi>
>>>>>>>>>>>>> tb
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg>
>>>>>>>>>>>>> itb>
>>>>>>>>>>>>> ox
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg>
>>>>>>>>>>>>> it
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>> %2>
>>>>>>>>>>>>> Fg>
>>>>>>>>>>>>> it>
>>>>>>>>>>>>> box>
>>>>>>>>>>>>> .apache.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fapache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557
>>>>>>>>>>>>> e27%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645157342729
>>>>>>>>>>>>> 2934&sdata=s%2BdjugzZ08UzMa4NjpIEsKY6j5g6jnWcgVQzJCFzqMU%3D&res
>>>>>>>>>>>>> erved=0>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> apache.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fapache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557
>>>>>>>>>>>>> e27%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645157342729
>>>>>>>>>>>>> 2934&sdata=s%2BdjugzZ08UzMa4NjpIEsKY6j5g6jnWcgVQzJCFzqMU%3D&res
>>>>>>>>>>>>> erved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>>>>
>>>>>>>>>>>>> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035
>>>>>>>>>>>>> &s
>>>>>>>>>>>>>
>>>>>>>>>>>>> data=3bh9wC0Op3OH3psgqimuLvLvEWpvkRK3VX4UTcM%2F6X8%3D&reserved=
>>>>>>>>>>>>> 0>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap>
>>>>>>>>>>>>> ache.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e2
>>>>>>>>>>>>> 7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364515734272929
>>>>>>>>>>>>> 34&sdata=DJ4sHDEQqunM3pC1%2Be92ixXZs6jzdUn5By08H%2FI1oF0%3D&res
>>>>>>>>>>>>> erved=0>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ache.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e2
>>>>>>>>>>>>> 7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364515734272929
>>>>>>>>>>>>> 34&sdata=DJ4sHDEQqunM3pC1%2Be92ixXZs6jzdUn5By08H%2FI1oF0%3D&res
>>>>>>>>>>>>> erved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>>>> 7C
>>>>>>>>>>>>>
>>>>>>>>>>>>> fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&s
>>>>>>>>>>>>> da
>>>>>>>>>>>>>
>>>>>>>>>>>>> ta=qICErbclqu41fuNV6k4X%2BwwDgUEQm5%2FnvXPkQmtUuGQ%3D&reserved=
>>>>>>>>>>>>> 0>
>>>>>>>>>>>>> %2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sda
>>>>>>>>>>>>> ta
>>>>>>>>>>>>> =c
>>>>>>>>>>>>> TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap>
>>>>>>>>>>>>> ac
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> ap>
>>>>>>>>>>>>> ac>
>>>>>>>>>>>>> he.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fhe.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%
>>>>>>>>>>>>> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934
>>>>>>>>>>>>> &sdata=ZUQG5Gpp5l%2Fv8uPhYwGY1p2Z3rD%2BeYt7K2hGyCb6qI4%3D&reser
>>>>>>>>>>>>> ved=0>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> he.org
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2Fhe.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%
>>>>>>>>>>>>> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934
>>>>>>>>>>>>> &sdata=ZUQG5Gpp5l%2Fv8uPhYwGY1p2Z3rD%2BeYt7K2hGyCb6qI4%3D&reser
>>>>>>>>>>>>> ved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7C
>>>>>>>>>>>>> fa
>>>>>>>>>>>>>
>>>>>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sda
>>>>>>>>>>>>> ta
>>>>>>>>>>>>>
>>>>>>>>>>>>> =y%2BMNhg4YUcOb%2F29PSq9fplNGzZGCYBus85a%2BV1DnLsA%3D&reserved=
>>>>>>>>>>>>> 0>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> he
>>>>>>>>>>>>>
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F
>>>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>> 2F>
>>>>>>>>>>>>> he>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> .org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>>>> 7b
>>>>>>>>>>>>> 1b
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=p
>>>>>>>>>>>>> P5
>>>>>>>>>>>>> w8
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&da
>>>>>>>>>>>>> ta
>>>>>>>>>>>>> =0
>>>>>>>>>>>>> 2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=p
>>>>>>>>>>>>> G0
>>>>>>>>>>>>> pr
>>>>>>>>>>>>> Ot
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos
>>>>>>>>>>>>> %2
>>>>>>>>>>>>> Fa
>>>>>>>>>>>>> sf
>>>>>>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>>>>>>>>>>>>> 7C
>>>>>>>>>>>>> 0%
>>>>>>>>>>>>> 7C
>>>>>>>>>>>>> 63
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9D
>>>>>>>>>>>>> ST
>>>>>>>>>>>>> g%
>>>>>>>>>>>>> 3D
>>>>>>>>>>>>> &r
>>>>>>>>>>>>> eserved=0
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> The following commit(s) were added to refs/heads/develop by
>>>>>>>>>>>>> this
>>>>>>>>>>>>> push:
>>>>>>>>>>>>> new 2072541 Fixes #24
>>>>>>>>>>>>> 2072541 is described below
>>>>>>>>>>>>>
>>>>>>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>>>
>>>>>>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>>>>>>
>>>>>>>>>>>>> Fixes #24
>>>>>>>>>>>>>
>>>>>>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>>>>>>> event
>>>>>>>>>>>> and a “changed” event for the same action. It seems like we
>>>>>>>>>>>> should
>>>>>>>>>>>> dispatch
>>>>>>>>>>>> one or the other.
>>>>>>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>>>>>>> events
>>>>>>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>>>>>>> I think the change event should be removed.
>>>>>>>>>>>>> ---
>>>>>>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>>>>>>> ++++++++++++----
>>>>>>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1
>>>>>>>>>>>>> -
>>>>>>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>>>>>>
>>>>>>>>>>>>> diff --git
>>>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>> b/frameworks/projects/Basic/
>>>>>>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>>>>>>
>>>>>>>>>>>>> /**
>>>>>>>>>>>>> + * @royaleignorecoercion
>>>>>>>>>>>>> org.apache.royale.core.UIBase
>>>>>>>>>>>>> + */
>>>>>>>>>>>>> + private function getHost():UIBase
>>>>>>>>>>>>> + {
>>>>>>>>>>>>> + return _strand as UIBase;
>>>>>>>>>>>>> + }
>>>>>>>>>>>>> + /**
>>>>>>>>>>>>> * The button that causes the previous month to be
>>>>>>>>>>>> displayed by the DateChooser.
>>>>>>>>>>>>> *
>>>>>>>>>>>>> * @langversion 3.0
>>>>>>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>>>>>>> monthButtonsContainer.
>>>>>>>>>>>> addElement(_nextMonthButton);
>>>>>>>>>>>>>
>>>>>>>>>>>>> -
>>>>>>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>>> +
>>>>>>>>>>>>> getHost().addElement(monthButtonsContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>>>
>>>>>>>>>>>>> // DAY NAMES
>>>>>>>>>>>>>
>>>>>>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>>>>>>> }
>>>>>>>>>>>>> -
>>>>>>>>>>>>> UIBase(_strand).addElement(dayNamesContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>>>>>>> false);
>>>>>>>>>>>>>
>>>>>>>>>>>>> // DAYS
>>>>>>>>>>>>>
>>>>>>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>>>>>>> }
>>>>>>>>>>>>> -
>>>>>>>>>>>>> UIBase(_strand).addElement(daysContainer,
>>>>>>>>>>>>> false);
>>>>>>>>>>>>> + getHost().addElement(daysContainer,
>>>>>>>>>>>>> false);
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>>>>>>> new Event("itemsCreated") );
>>>>>>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>>>>>>> var index:Number =
>>>>>>>>>>>>> model.getIndexForSelectedDate(
>>>>>>>>>>>> );
>>>>>>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>>>>>>
>>>>>>>>>>>>> -
>>>>>>>>>>>>> IEventDispatcher(_strand).dispatchEvent(new
>>>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>>>> + getHost().dispatchEvent(new
>>>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>>>> + getHost().dispatchEvent( new
>>>>>>>>>>>>> Event("change")
>>>>>>>>>>>>> );
>>>>>>>>>>>>> }
>>>>>>>>>>>>>
>>>>>>>>>>>>> /**
>>>>>>>>>>>>> diff --git
>>>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>>> @@ -81,7 +81,6 @@ package
>>>>>>>>>>>>> org.apache.royale.html.beads.controllers
>>>>>>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>>>>>>> DateChooserList;
>>>>>>>>>>>>> var model:DateChooserModel =
>>>>>>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>>>>>>> as DateChooserModel;
>>>>>>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>>>>>>> Event("change") );
>>>>>>>>>>>>> }
>>>>>>>>>>>>>
>>>>>>>>>>>>> /**
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>>>>>> contact
>>>>>>>>>>>>> ['"commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>>>"
>>>>>>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>
>>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>>> <ma...@royale.apache.org>>>>>'].
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>>
>>>>>>>>>>> Piotr Zarzycki
>>>>>>>>>>>
>>>>>>>>>>> mobile: +48 880 859 557
>>>>>>>>>>> skype: zarzycki10
>>>>>>>>>>>
>>>>>>>>>>> LinkedIn:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> www>
>>>>>>>>>>> .l
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w.l>
>>>>>>>>>>> in
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w>.
>>>>>>>>>>> lin>
>>>>>>>>>>> ke
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w>.
>>>>>>>>>>> li
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ww>
>>>>>>>>>>> w>.
>>>>>>>>>>> li>
>>>>>>>>>>> nke>
>>>>>>>>>>> din.com
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> din.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cf
>>>>>>>>>>> a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdat
>>>>>>>>>>> a=Imk6sB12o8N2v7pXCzSeB4ij7Az4y2gJ2sgzcQsTeQQ%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n.com
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> n.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cfa7
>>>>>>>>>>> b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdata=
>>>>>>>>>>> R8JGYExCA3%2BnUtWekeCyHGpcqWVvpmnIQr6x5Ms3qmo%3D&reserved=0>%2F&d
>>>>>>>>>>> ata=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1
>>>>>>>>>>>
>>>>>>>>>>> b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=p6
>>>>>>>>>>> Pk
>>>>>>>>>>> yp6pLodpmEnEUeVe%2Fn6Wgd9g0vNvW9ktUIRKMZI%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n>.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1
>>>>>>>>>>> b5
>>>>>>>>>>> a7
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rT
>>>>>>>>>>> To
>>>>>>>>>>> 6I
>>>>>>>>>>> w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n>.
>>>>>>>>>>> co
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di>
>>>>>>>>>>> n
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> di
>>>>>>>>>>> n>.
>>>>>>>>>>> co>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5
>>>>>>>>>>> a7
>>>>>>>>>>> b3
>>>>>>>>>>> 44
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb
>>>>>>>>>>> %2
>>>>>>>>>>> Be
>>>>>>>>>>> VT
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data
>>>>>>>>>>> =0
>>>>>>>>>>> 2%
>>>>>>>>>>> 7C
>>>>>>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920
>>>>>>>>>>> &s
>>>>>>>>>>> da
>>>>>>>>>>> ta
>>>>>>>>>>> =i
>>>>>>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l>.
>>>>>>>>>>> li
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l>.
>>>>>>>>>>> li>
>>>>>>>>>>> nk
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l>.
>>>>>>>>>>> li
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fp>
>>>>>>>>>>> l>.
>>>>>>>>>>> li>
>>>>>>>>>>> nk>
>>>>>>>>>>> edin.com
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> edin.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7C
>>>>>>>>>>> fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sda
>>>>>>>>>>> ta=5nA5wzd5a%2Bfcr%2BvtsJ5QtnF5%2F3Ap%2FRxEVK3u0NiKxiI%3D&reserve
>>>>>>>>>>> d=0>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in.com
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> in.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cfa
>>>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdata
>>>>>>>>>>> =%2BBvbQWksMNA%2BaKgSvw3MAmuke9UuSKgAP7n9u%2BW16to%3D&reserved=0>
>>>>>>>>>>> %2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b
>>>>>>>>>>>
>>>>>>>>>>> 1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=u
>>>>>>>>>>> 7o
>>>>>>>>>>> zW7xs5FFLQ2HfIYLIgyfAED2h5c49NuTwArKyE%2F8%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> .com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b
>>>>>>>>>>> 1b
>>>>>>>>>>> 5a
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGw
>>>>>>>>>>> kr
>>>>>>>>>>> fN
>>>>>>>>>>> 54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in>
>>>>>>>>>>> .c
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed>
>>>>>>>>>>> in
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>> ed
>>>>>>>>>>> in>
>>>>>>>>>>> .c>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>> 5a
>>>>>>>>>>> 7b
>>>>>>>>>>> 34
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq
>>>>>>>>>>> 2x
>>>>>>>>>>> AX
>>>>>>>>>>> Fa
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzyc
>>>>>>>>>>> ki
>>>>>>>>>>> -9
>>>>>>>>>>> 2a
>>>>>>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63
>>>>>>>>>>> 64
>>>>>>>>>>> 50
>>>>>>>>>>> 89
>>>>>>>>>>> 47
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&r
>>>>>>>>>>> es
>>>>>>>>>>> er
>>>>>>>>>>> ve
>>>>>>>>>>> d=
>>>>>>>>>>> 0>
>>>>>>>>>>>
>>>>>>>>>>> GitHub:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>>>>>>>>>>> gi
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fgi>
>>>>>>>>>>> th
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> ith>
>>>>>>>>>>> ub
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it>
>>>>>>>>>>> hub>
>>>>>>>>>>> .c
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it>
>>>>>>>>>>> hu
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>> Fg>
>>>>>>>>>>> it>
>>>>>>>>>>> hu>
>>>>>>>>>>> b.c>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520
>>>>>>>>>>> b7
>>>>>>>>>>> 78
>>>>>>>>>>> 49
>>>>>>>>>>> %7
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sd
>>>>>>>>>>> at
>>>>>>>>>>> a=
>>>>>>>>>>> WZ
>>>>>>>>>>> tw
>>>>>>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>>
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Aren't we essentially making a copy of each MouseEvent? That doesn't
sound right to me.
Unless some code is actually checking the type:
If (event is MouseEvent)
it would seem to me to be far cheaper to just add new getters to
BrowserEvent.
And if we do want to support type-checking of MouseEvent, we could add a
bead that extends Language.is/as and sees if it is a BrowserEvent and look
inside at the native event.
Smoke and mirrors...
Thoughts?
-Alex
On 11/1/17, 11:22 AM, "Harbs" <ha...@gmail.com> wrote:
>The only way to get MouseEvent and KeyboardEvent-specific properties was
>by digging into the native event buried in the goog event.
>
>Additionally, client code is expecting KeyboardEvents and MouseEvents and
>the expected properties was missing in the BrowserEvents. Before my
>changes, MouseEvents and KeyboardEvents were actually never dispatched by
>Royale.
>
>I don’t remember the exact details, but the impetus for me to make these
>changes were errors and difficulties I had in my app.
>
>I don’t think the switch is terribly expensive, and I don’t see any
>alternative.
>
>
>> On Nov 1, 2017, at 8:10 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>
>> Those look like change logs, but I'm not recalling why you needed to do
>> that. That looks pretty expensive to me.
>>
>> -Alex
>>
>> On 11/1/17, 10:33 AM, "Harbs" <harbs.lists@gmail.com
>><ma...@gmail.com>> wrote:
>>
>>> We discussed this a few months ago:
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
>>>co
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>.co>
>>>
>>>m%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasi
>>>c%
>>>
>>>2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrappe
>>>r.
>>>
>>>as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b
>>>34
>>>
>>>438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4
>>>kD
>>> e%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0
>>>
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>.c
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>.c>
>>>
>>>om%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBas
>>>ic
>>>
>>>%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapp
>>>er
>>>
>>>.as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7
>>>b3
>>>
>>>4438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz
>>>4k
>>> De%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0>
>>>
>>> Harbs
>>>
>>>> On Nov 1, 2017, at 7:12 PM, Alex Harui <aharui@adobe.com.INVALID
>>>><ma...@adobe.com.INVALID>> wrote:
>>>>
>>>> How did you "fix" that? The most obvious way that popped into my mind
>>>> would be pretty expensive.
>>>>
>>>> Thanks,
>>>> -Alex
>>>>
>>>> On 11/1/17, 8:45 AM, "Harbs" <harbs.lists@gmail.com
>>>><ma...@gmail.com>
>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>>
>>>>> FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types
>>>>>and
>>>>> not BrowserEvents as they are in the goog libraries.
>>>>>
>>>>> OK. Let’s get rid of selectedDateChanged.
>>>>>
>>>>>> On Nov 1, 2017, at 5:41 PM, Alex Harui <aharui@adobe.com.INVALID
>>>>>><ma...@adobe.com.INVALID>>
>>>>>> wrote:
>>>>>>
>>>>>> AIUI, events generated by an HTMLElement are caught by Google
>>>>>>Closure
>>>>>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>>>>> even
>>>>>> things we think are MouseEvents are actually dispatched as
>>>>>> BrowserEvents.
>>>>>> So the actual type for lots of events on the JS side are not what
>>>>>>the
>>>>>> metadata says. I think only the events we dispatch directly don't
>>>>>>get
>>>>>> converted. So yes, that means that we are frequently lying about
>>>>>>the
>>>>>> event type, but since JS doesn't do runtime checking, as long as
>>>>>>your
>>>>>> code
>>>>>> doesn't need to check the type (via "is" or "as") everything should
>>>>>> "just
>>>>>> work".
>>>>>>
>>>>>> I'm always interested in running less code, so dispatching two
>>>>>>events
>>>>>> seems unnecessary, and one should go away. I was only trying to
>>>>>>say
>>>>>> that
>>>>>> I don't care about consistency that every property change event
>>>>>>should
>>>>>> be
>>>>>> named "somePropertyChanged". IMO, it is ok for the most popular
>>>>>>event
>>>>>> to
>>>>>> be just plain "change".
>>>>>>
>>>>>> My 2 cents,
>>>>>> -Alex
>>>>>>
>>>>>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com
>>>>>><ma...@gmail.com>
>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>><mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>
>>>>>>wrote:
>>>>>>
>>>>>>> I’m not sure why/how, but I checked and the change event on the
>>>>>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>>>>>
>>>>>>> Here’s what I get if I listen for both events and trace them to the
>>>>>>> console:
>>>>>>>
>>>>>>> org.apache.royale.events.Event {type: "selectedDateChanged",
>>>>>>>target:
>>>>>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>>>>> org.a…e.r…e.h…l.DateChooser,
>>>>>>> propagationStopped_: false, defaultPrevented: false, …}
>>>>>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>>>>> g…g.e…s.BrowserEvent}
>>>>>>>
>>>>>>> The type, target and currentTarget properties are correct in the
>>>>>>> BrowserEvent and the rest of the properties are undefined. So, I’m
>>>>>>> not
>>>>>>> sure that it really matters that it is a BrowserEvent, although the
>>>>>>> construction of it has to be less efficient.
>>>>>>>
>>>>>>> Either way, do you agree that there should be only one of these two
>>>>>>> events dispatched?
>>>>>>>
>>>>>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <aharui@adobe.com.INVALID
>>>>>>>><ma...@adobe.com.INVALID>
>>>>>>>> <mailto:aharui@adobe.com.INVALID
>>>>>>>><ma...@adobe.com.INVALID>>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> I think the most common event should have a simple name like
>>>>>>>> "change".
>>>>>>>> It
>>>>>>>> makes it easier to remember.
>>>>>>>>
>>>>>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>>>>>> initiated
>>>>>>>> by an HTMLElement event. We are sort of taking advantage of the
>>>>>>>> fact
>>>>>>>> that
>>>>>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>>>>> type-check
>>>>>>>> the event class.
>>>>>>>>
>>>>>>>> My 2 cents,
>>>>>>>> -Alex
>>>>>>>>
>>>>>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>>>>>>>><ma...@gmail.com>
>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>><mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>><mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Nope.
>>>>>>>>>
>>>>>>>>> Copying my response from Github:
>>>>>>>>>
>>>>>>>>> The only place change is referenced in the Framework is in the
>>>>>>>>> metadata
>>>>>>>>> of DateChooser:
>>>>>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>>>>>
>>>>>>>>> That could easily be changed to:
>>>>>>>>> [Event(name="selectedDateChanged",
>>>>>>>>> type="org.apache.royale.events.Event")]
>>>>>>>>>
>>>>>>>>> The current metadata is actually incorrect, because the event
>>>>>>>>>type
>>>>>>>>> is
>>>>>>>>> org.apache.royale.events.BrowserEvent
>>>>>>>>>
>>>>>>>>> Harbs
>>>>>>>>>
>>>>>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>>>>>> <piotrzarzycki21@gmail.com <ma...@gmail.com>
>>>>>>>>>><mailto:piotrzarzycki21@gmail.com
>>>>>>>>>><ma...@gmail.com>>
>>>>>>>>>> <mailto:piotrzarzycki21@gmail.com
>>>>>>>>>><ma...@gmail.com>
>>>>>>>>>> <mailto:piotrzarzycki21@gmail.com
>>>>>>>>>><ma...@gmail.com>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> You can remove it if it is not fired it up for some other cases
>>>>>>>>>>in
>>>>>>>>>> DateChooser.
>>>>>>>>>>
>>>>>>>>>> Piotr
>>>>>>>>>>
>>>>>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com
>>>>>>>>>><ma...@gmail.com>
>>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>>>><mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>:
>>>>>>>>>>
>>>>>>>>>>> My comment in the commit message needs discussion.
>>>>>>>>>>>
>>>>>>>>>>> I think the change event should be removed. What do others
>>>>>>>>>>>think?
>>>>>>>>>>>
>>>>>>>>>>> Harbs
>>>>>>>>>>>
>>>>>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org
>>>>>>>>>>>><ma...@apache.org>
>>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>>
>>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>
>>>>>>>>>>>><mailto:harbs@apache.org <ma...@apache.org>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>>>>> repository.
>>>>>>>>>>>>
>>>>>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>>>>>> in repository
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2F>
>>>>>>>>>>>> gi
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fgi>
>>>>>>>>>>>> tb
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg>
>>>>>>>>>>>> itb>
>>>>>>>>>>>> ox
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg>
>>>>>>>>>>>> it
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F
>>>>>>>>>>>>%2>
>>>>>>>>>>>> Fg>
>>>>>>>>>>>> it>
>>>>>>>>>>>> box>
>>>>>>>>>>>> .apache.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fapache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557
>>>>>>>>>>>>e27%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645157342729
>>>>>>>>>>>>2934&sdata=s%2BdjugzZ08UzMa4NjpIEsKY6j5g6jnWcgVQzJCFzqMU%3D&res
>>>>>>>>>>>>erved=0>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> apache.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fapache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557
>>>>>>>>>>>>e27%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645157342729
>>>>>>>>>>>>2934&sdata=s%2BdjugzZ08UzMa4NjpIEsKY6j5g6jnWcgVQzJCFzqMU%3D&res
>>>>>>>>>>>>erved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>>>
>>>>>>>>>>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035
>>>>>>>>>>>>&s
>>>>>>>>>>>>
>>>>>>>>>>>>data=3bh9wC0Op3OH3psgqimuLvLvEWpvkRK3VX4UTcM%2F6X8%3D&reserved=
>>>>>>>>>>>>0>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap>
>>>>>>>>>>>> ache.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e2
>>>>>>>>>>>>7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364515734272929
>>>>>>>>>>>>34&sdata=DJ4sHDEQqunM3pC1%2Be92ixXZs6jzdUn5By08H%2FI1oF0%3D&res
>>>>>>>>>>>>erved=0>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ache.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fache.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e2
>>>>>>>>>>>>7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364515734272929
>>>>>>>>>>>>34&sdata=DJ4sHDEQqunM3pC1%2Be92ixXZs6jzdUn5By08H%2FI1oF0%3D&res
>>>>>>>>>>>>erved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>>>7C
>>>>>>>>>>>>
>>>>>>>>>>>>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&s
>>>>>>>>>>>>da
>>>>>>>>>>>>
>>>>>>>>>>>>ta=qICErbclqu41fuNV6k4X%2BwwDgUEQm5%2FnvXPkQmtUuGQ%3D&reserved=
>>>>>>>>>>>>0>
>>>>>>>>>>>> %2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sda
>>>>>>>>>>>>ta
>>>>>>>>>>>> =c
>>>>>>>>>>>> TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap>
>>>>>>>>>>>> ac
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> ap>
>>>>>>>>>>>> ac>
>>>>>>>>>>>> he.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fhe.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%
>>>>>>>>>>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934
>>>>>>>>>>>>&sdata=ZUQG5Gpp5l%2Fv8uPhYwGY1p2Z3rD%2BeYt7K2hGyCb6qI4%3D&reser
>>>>>>>>>>>>ved=0>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> he.org
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2Fhe.org%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%
>>>>>>>>>>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934
>>>>>>>>>>>>&sdata=ZUQG5Gpp5l%2Fv8uPhYwGY1p2Z3rD%2BeYt7K2hGyCb6qI4%3D&reser
>>>>>>>>>>>>ved=0>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7C
>>>>>>>>>>>>fa
>>>>>>>>>>>>
>>>>>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sda
>>>>>>>>>>>>ta
>>>>>>>>>>>>
>>>>>>>>>>>>=y%2BMNhg4YUcOb%2F29PSq9fplNGzZGCYBus85a%2BV1DnLsA%3D&reserved=
>>>>>>>>>>>>0>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> he
>>>>>>>>>>>>
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F
>>>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%
>>>>>>>>>>>>2F>
>>>>>>>>>>>> he>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>.org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>>>7b
>>>>>>>>>>>> 1b
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=p
>>>>>>>>>>>>P5
>>>>>>>>>>>> w8
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&da
>>>>>>>>>>>>ta
>>>>>>>>>>>> =0
>>>>>>>>>>>> 2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=p
>>>>>>>>>>>>G0
>>>>>>>>>>>> pr
>>>>>>>>>>>> Ot
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos
>>>>>>>>>>>>%2
>>>>>>>>>>>> Fa
>>>>>>>>>>>> sf
>>>>>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>>>>>>>>>>>>7C
>>>>>>>>>>>> 0%
>>>>>>>>>>>> 7C
>>>>>>>>>>>> 63
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9D
>>>>>>>>>>>>ST
>>>>>>>>>>>> g%
>>>>>>>>>>>> 3D
>>>>>>>>>>>> &r
>>>>>>>>>>>> eserved=0
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> The following commit(s) were added to refs/heads/develop by
>>>>>>>>>>>>this
>>>>>>>>>>>> push:
>>>>>>>>>>>> new 2072541 Fixes #24
>>>>>>>>>>>> 2072541 is described below
>>>>>>>>>>>>
>>>>>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>>
>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>>>>
>>>>>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>>>>>
>>>>>>>>>>>> Fixes #24
>>>>>>>>>>>>
>>>>>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>>>>>> event
>>>>>>>>>>> and a “changed” event for the same action. It seems like we
>>>>>>>>>>> should
>>>>>>>>>>> dispatch
>>>>>>>>>>> one or the other.
>>>>>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>>>>>> events
>>>>>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>>>>>> I think the change event should be removed.
>>>>>>>>>>>> ---
>>>>>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>>>>>> ++++++++++++----
>>>>>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1
>>>>>>>>>>>>-
>>>>>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>>>>>
>>>>>>>>>>>> diff --git
>>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>b/frameworks/projects/Basic/
>>>>>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>>>>>
>>>>>>>>>>>> /**
>>>>>>>>>>>> + * @royaleignorecoercion
>>>>>>>>>>>> org.apache.royale.core.UIBase
>>>>>>>>>>>> + */
>>>>>>>>>>>> + private function getHost():UIBase
>>>>>>>>>>>> + {
>>>>>>>>>>>> + return _strand as UIBase;
>>>>>>>>>>>> + }
>>>>>>>>>>>> + /**
>>>>>>>>>>>> * The button that causes the previous month to be
>>>>>>>>>>> displayed by the DateChooser.
>>>>>>>>>>>> *
>>>>>>>>>>>> * @langversion 3.0
>>>>>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>>>>>> monthButtonsContainer.
>>>>>>>>>>> addElement(_nextMonthButton);
>>>>>>>>>>>>
>>>>>>>>>>>> -
>>>>>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>>>>>> false);
>>>>>>>>>>>> +
>>>>>>>>>>>> getHost().addElement(monthButtonsContainer,
>>>>>>>>>>> false);
>>>>>>>>>>>>
>>>>>>>>>>>> // DAY NAMES
>>>>>>>>>>>>
>>>>>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>>>>>> }
>>>>>>>>>>>> -
>>>>>>>>>>>> UIBase(_strand).addElement(dayNamesContainer,
>>>>>>>>>>> false);
>>>>>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>>
>>>>>>>>>>>> // DAYS
>>>>>>>>>>>>
>>>>>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>>>>>> }
>>>>>>>>>>>> -
>>>>>>>>>>>>UIBase(_strand).addElement(daysContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>> + getHost().addElement(daysContainer,
>>>>>>>>>>>> false);
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>>>>>> new Event("itemsCreated") );
>>>>>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>>>>>> var index:Number =
>>>>>>>>>>>> model.getIndexForSelectedDate(
>>>>>>>>>>> );
>>>>>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>>>>>
>>>>>>>>>>>> -
>>>>>>>>>>>> IEventDispatcher(_strand).dispatchEvent(new
>>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>>> + getHost().dispatchEvent(new
>>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>>> + getHost().dispatchEvent( new
>>>>>>>>>>>> Event("change")
>>>>>>>>>>>> );
>>>>>>>>>>>> }
>>>>>>>>>>>>
>>>>>>>>>>>> /**
>>>>>>>>>>>> diff --git
>>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>>> @@ -81,7 +81,6 @@ package
>>>>>>>>>>>> org.apache.royale.html.beads.controllers
>>>>>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>>>>>> DateChooserList;
>>>>>>>>>>>> var model:DateChooserModel =
>>>>>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>>>>>> as DateChooserModel;
>>>>>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>>>>>> Event("change") );
>>>>>>>>>>>> }
>>>>>>>>>>>>
>>>>>>>>>>>> /**
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>>>>> contact
>>>>>>>>>>>> ['"commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>>>"
>>>>>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>>>><ma...@royale.apache.org>>>>>'].
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>>
>>>>>>>>>> Piotr Zarzycki
>>>>>>>>>>
>>>>>>>>>> mobile: +48 880 859 557
>>>>>>>>>> skype: zarzycki10
>>>>>>>>>>
>>>>>>>>>> LinkedIn:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fw
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>www>
>>>>>>>>>> .l
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w.l>
>>>>>>>>>> in
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w>.
>>>>>>>>>> lin>
>>>>>>>>>> ke
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w>.
>>>>>>>>>> li
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ww>
>>>>>>>>>> w>.
>>>>>>>>>> li>
>>>>>>>>>> nke>
>>>>>>>>>> din.com
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>din.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cf
>>>>>>>>>>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdat
>>>>>>>>>>a=Imk6sB12o8N2v7pXCzSeB4ij7Az4y2gJ2sgzcQsTeQQ%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n.com
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>n.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cfa7
>>>>>>>>>>b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdata=
>>>>>>>>>>R8JGYExCA3%2BnUtWekeCyHGpcqWVvpmnIQr6x5Ms3qmo%3D&reserved=0>%2F&d
>>>>>>>>>>ata=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1
>>>>>>>>>>
>>>>>>>>>>b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=p6
>>>>>>>>>>Pk
>>>>>>>>>> yp6pLodpmEnEUeVe%2Fn6Wgd9g0vNvW9ktUIRKMZI%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n>.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1
>>>>>>>>>>b5
>>>>>>>>>> a7
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rT
>>>>>>>>>>To
>>>>>>>>>> 6I
>>>>>>>>>> w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n>.
>>>>>>>>>> co
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di>
>>>>>>>>>> n
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>di
>>>>>>>>>> n>.
>>>>>>>>>> co>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5
>>>>>>>>>>a7
>>>>>>>>>> b3
>>>>>>>>>> 44
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb
>>>>>>>>>>%2
>>>>>>>>>> Be
>>>>>>>>>> VT
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data
>>>>>>>>>>=0
>>>>>>>>>> 2%
>>>>>>>>>> 7C
>>>>>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920
>>>>>>>>>>&s
>>>>>>>>>> da
>>>>>>>>>> ta
>>>>>>>>>> =i
>>>>>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l>.
>>>>>>>>>> li
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l>.
>>>>>>>>>> li>
>>>>>>>>>> nk
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l>.
>>>>>>>>>> li
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fp>
>>>>>>>>>> l>.
>>>>>>>>>> li>
>>>>>>>>>> nk>
>>>>>>>>>> edin.com
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>edin.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7C
>>>>>>>>>>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sda
>>>>>>>>>>ta=5nA5wzd5a%2Bfcr%2BvtsJ5QtnF5%2F3Ap%2FRxEVK3u0NiKxiI%3D&reserve
>>>>>>>>>>d=0>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in.com
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>in.com%2F&data=02%7C01%7C%7Cfb3e2c89577d4c8faf8a08d521557e27%7Cfa
>>>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451573427292934&sdata
>>>>>>>>>>=%2BBvbQWksMNA%2BaKgSvw3MAmuke9UuSKgAP7n9u%2BW16to%3D&reserved=0>
>>>>>>>>>>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b
>>>>>>>>>>
>>>>>>>>>>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=u
>>>>>>>>>>7o
>>>>>>>>>> zW7xs5FFLQ2HfIYLIgyfAED2h5c49NuTwArKyE%2F8%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>.com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b
>>>>>>>>>>1b
>>>>>>>>>> 5a
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGw
>>>>>>>>>>kr
>>>>>>>>>> fN
>>>>>>>>>> 54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in>
>>>>>>>>>> .c
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed>
>>>>>>>>>> in
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ed
>>>>>>>>>> in>
>>>>>>>>>> .c>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>5a
>>>>>>>>>> 7b
>>>>>>>>>> 34
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq
>>>>>>>>>>2x
>>>>>>>>>> AX
>>>>>>>>>> Fa
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzyc
>>>>>>>>>>ki
>>>>>>>>>> -9
>>>>>>>>>> 2a
>>>>>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63
>>>>>>>>>>64
>>>>>>>>>> 50
>>>>>>>>>> 89
>>>>>>>>>> 47
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&r
>>>>>>>>>>es
>>>>>>>>>> er
>>>>>>>>>> ve
>>>>>>>>>> d=
>>>>>>>>>> 0>
>>>>>>>>>>
>>>>>>>>>> GitHub:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>>>>>>>>>>gi
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fgi>
>>>>>>>>>> th
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> ith>
>>>>>>>>>> ub
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it>
>>>>>>>>>> hub>
>>>>>>>>>> .c
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it>
>>>>>>>>>> hu
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it>
>>>>>>>>>> hu>
>>>>>>>>>> b.c>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520
>>>>>>>>>>b7
>>>>>>>>>> 78
>>>>>>>>>> 49
>>>>>>>>>> %7
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sd
>>>>>>>>>>at
>>>>>>>>>> a=
>>>>>>>>>> WZ
>>>>>>>>>> tw
>>>>>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
The only way to get MouseEvent and KeyboardEvent-specific properties was by digging into the native event buried in the goog event.
Additionally, client code is expecting KeyboardEvents and MouseEvents and the expected properties was missing in the BrowserEvents. Before my changes, MouseEvents and KeyboardEvents were actually never dispatched by Royale.
I don’t remember the exact details, but the impetus for me to make these changes were errors and difficulties I had in my app.
I don’t think the switch is terribly expensive, and I don’t see any alternative.
> On Nov 1, 2017, at 8:10 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> Those look like change logs, but I'm not recalling why you needed to do
> that. That looks pretty expensive to me.
>
> -Alex
>
> On 11/1/17, 10:33 AM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
>
>> We discussed this a few months ago:
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co>
>> m%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%
>> 2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapper.
>> as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b34
>> 438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4kD
>> e%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0
>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c>
>> om%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic
>> %2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapper
>> .as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b3
>> 4438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4k
>> De%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0>
>>
>> Harbs
>>
>>> On Nov 1, 2017, at 7:12 PM, Alex Harui <aharui@adobe.com.INVALID <ma...@adobe.com.INVALID>> wrote:
>>>
>>> How did you "fix" that? The most obvious way that popped into my mind
>>> would be pretty expensive.
>>>
>>> Thanks,
>>> -Alex
>>>
>>> On 11/1/17, 8:45 AM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>
>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>
>>>> FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types and
>>>> not BrowserEvents as they are in the goog libraries.
>>>>
>>>> OK. Let’s get rid of selectedDateChanged.
>>>>
>>>>> On Nov 1, 2017, at 5:41 PM, Alex Harui <aharui@adobe.com.INVALID <ma...@adobe.com.INVALID>>
>>>>> wrote:
>>>>>
>>>>> AIUI, events generated by an HTMLElement are caught by Google Closure
>>>>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>>>> even
>>>>> things we think are MouseEvents are actually dispatched as
>>>>> BrowserEvents.
>>>>> So the actual type for lots of events on the JS side are not what the
>>>>> metadata says. I think only the events we dispatch directly don't get
>>>>> converted. So yes, that means that we are frequently lying about the
>>>>> event type, but since JS doesn't do runtime checking, as long as your
>>>>> code
>>>>> doesn't need to check the type (via "is" or "as") everything should
>>>>> "just
>>>>> work".
>>>>>
>>>>> I'm always interested in running less code, so dispatching two events
>>>>> seems unnecessary, and one should go away. I was only trying to say
>>>>> that
>>>>> I don't care about consistency that every property change event should
>>>>> be
>>>>> named "somePropertyChanged". IMO, it is ok for the most popular event
>>>>> to
>>>>> be just plain "change".
>>>>>
>>>>> My 2 cents,
>>>>> -Alex
>>>>>
>>>>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>
>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>> wrote:
>>>>>
>>>>>> I’m not sure why/how, but I checked and the change event on the
>>>>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>>>>
>>>>>> Here’s what I get if I listen for both events and trace them to the
>>>>>> console:
>>>>>>
>>>>>> org.apache.royale.events.Event {type: "selectedDateChanged", target:
>>>>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>>>> org.a…e.r…e.h…l.DateChooser,
>>>>>> propagationStopped_: false, defaultPrevented: false, …}
>>>>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>>>> g…g.e…s.BrowserEvent}
>>>>>>
>>>>>> The type, target and currentTarget properties are correct in the
>>>>>> BrowserEvent and the rest of the properties are undefined. So, I’m
>>>>>> not
>>>>>> sure that it really matters that it is a BrowserEvent, although the
>>>>>> construction of it has to be less efficient.
>>>>>>
>>>>>> Either way, do you agree that there should be only one of these two
>>>>>> events dispatched?
>>>>>>
>>>>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <aharui@adobe.com.INVALID <ma...@adobe.com.INVALID>
>>>>>>> <mailto:aharui@adobe.com.INVALID <ma...@adobe.com.INVALID>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>> I think the most common event should have a simple name like
>>>>>>> "change".
>>>>>>> It
>>>>>>> makes it easier to remember.
>>>>>>>
>>>>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>>>>> initiated
>>>>>>> by an HTMLElement event. We are sort of taking advantage of the
>>>>>>> fact
>>>>>>> that
>>>>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>>>> type-check
>>>>>>> the event class.
>>>>>>>
>>>>>>> My 2 cents,
>>>>>>> -Alex
>>>>>>>
>>>>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Nope.
>>>>>>>>
>>>>>>>> Copying my response from Github:
>>>>>>>>
>>>>>>>> The only place change is referenced in the Framework is in the
>>>>>>>> metadata
>>>>>>>> of DateChooser:
>>>>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>>>>
>>>>>>>> That could easily be changed to:
>>>>>>>> [Event(name="selectedDateChanged",
>>>>>>>> type="org.apache.royale.events.Event")]
>>>>>>>>
>>>>>>>> The current metadata is actually incorrect, because the event type
>>>>>>>> is
>>>>>>>> org.apache.royale.events.BrowserEvent
>>>>>>>>
>>>>>>>> Harbs
>>>>>>>>
>>>>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>>>>> <piotrzarzycki21@gmail.com <ma...@gmail.com> <mailto:piotrzarzycki21@gmail.com <ma...@gmail.com>>
>>>>>>>>> <mailto:piotrzarzycki21@gmail.com <ma...@gmail.com>
>>>>>>>>> <mailto:piotrzarzycki21@gmail.com <ma...@gmail.com>>>>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> You can remove it if it is not fired it up for some other cases in
>>>>>>>>> DateChooser.
>>>>>>>>>
>>>>>>>>> Piotr
>>>>>>>>>
>>>>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>
>>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>:
>>>>>>>>>
>>>>>>>>>> My comment in the commit message needs discussion.
>>>>>>>>>>
>>>>>>>>>> I think the change event should be removed. What do others think?
>>>>>>>>>>
>>>>>>>>>> Harbs
>>>>>>>>>>
>>>>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org <ma...@apache.org>
>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>>
>>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org> <mailto:harbs@apache.org <ma...@apache.org>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>>>> repository.
>>>>>>>>>>>
>>>>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>>>>> in repository
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F>
>>>>>>>>>>> gi
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fgi>
>>>>>>>>>>> tb
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg>
>>>>>>>>>>> itb>
>>>>>>>>>>> ox
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg>
>>>>>>>>>>> it
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2>
>>>>>>>>>>> Fg>
>>>>>>>>>>> it>
>>>>>>>>>>> box>
>>>>>>>>>>> .apache.org <http://apache.org/>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> apache.org <http://apache.org/>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&s
>>>>>>>>>>> data=3bh9wC0Op3OH3psgqimuLvLvEWpvkRK3VX4UTcM%2F6X8%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap>
>>>>>>>>>>> ache.org <http://ache.org/>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ache.org <http://ache.org/>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7C
>>>>>>>>>>> fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sda
>>>>>>>>>>> ta=qICErbclqu41fuNV6k4X%2BwwDgUEQm5%2FnvXPkQmtUuGQ%3D&reserved=0>
>>>>>>>>>>> %2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>>
>>>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata
>>>>>>>>>>> =c
>>>>>>>>>>> TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap>
>>>>>>>>>>> ac
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> ap>
>>>>>>>>>>> ac>
>>>>>>>>>>> he.org <http://he.org/>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> he.org <http://he.org/>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa
>>>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata
>>>>>>>>>>> =y%2BMNhg4YUcOb%2F29PSq9fplNGzZGCYBus85a%2BV1DnLsA%3D&reserved=0>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> he
>>>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F>
>>>>>>>>>>> he>
>>>>>>>>>>>
>>>>>>>>>>> .org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b
>>>>>>>>>>> 1b
>>>>>>>>>>>
>>>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=pP5
>>>>>>>>>>> w8
>>>>>>>>>>>
>>>>>>>>>>> NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&data
>>>>>>>>>>> =0
>>>>>>>>>>> 2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0
>>>>>>>>>>> pr
>>>>>>>>>>> Ot
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2
>>>>>>>>>>> Fa
>>>>>>>>>>> sf
>>>>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>>>>>>>>>>> 0%
>>>>>>>>>>> 7C
>>>>>>>>>>> 63
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DST
>>>>>>>>>>> g%
>>>>>>>>>>> 3D
>>>>>>>>>>> &r
>>>>>>>>>>> eserved=0
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>>>>>> push:
>>>>>>>>>>> new 2072541 Fixes #24
>>>>>>>>>>> 2072541 is described below
>>>>>>>>>>>
>>>>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>
>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>>>
>>>>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>>>>
>>>>>>>>>>> Fixes #24
>>>>>>>>>>>
>>>>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>>>>> event
>>>>>>>>>> and a “changed” event for the same action. It seems like we
>>>>>>>>>> should
>>>>>>>>>> dispatch
>>>>>>>>>> one or the other.
>>>>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>>>>> events
>>>>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>>>>> I think the change event should be removed.
>>>>>>>>>>> ---
>>>>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>>>>> ++++++++++++----
>>>>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>>>>
>>>>>>>>>>> diff --git
>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>>>>
>>>>>>>>>>> /**
>>>>>>>>>>> + * @royaleignorecoercion
>>>>>>>>>>> org.apache.royale.core.UIBase
>>>>>>>>>>> + */
>>>>>>>>>>> + private function getHost():UIBase
>>>>>>>>>>> + {
>>>>>>>>>>> + return _strand as UIBase;
>>>>>>>>>>> + }
>>>>>>>>>>> + /**
>>>>>>>>>>> * The button that causes the previous month to be
>>>>>>>>>> displayed by the DateChooser.
>>>>>>>>>>> *
>>>>>>>>>>> * @langversion 3.0
>>>>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>>>>> monthButtonsContainer.
>>>>>>>>>> addElement(_nextMonthButton);
>>>>>>>>>>>
>>>>>>>>>>> -
>>>>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>>>>> false);
>>>>>>>>>>> +
>>>>>>>>>>> getHost().addElement(monthButtonsContainer,
>>>>>>>>>> false);
>>>>>>>>>>>
>>>>>>>>>>> // DAY NAMES
>>>>>>>>>>>
>>>>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>>>>> }
>>>>>>>>>>> -
>>>>>>>>>>> UIBase(_strand).addElement(dayNamesContainer,
>>>>>>>>>> false);
>>>>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>>>>> false);
>>>>>>>>>>>
>>>>>>>>>>> // DAYS
>>>>>>>>>>>
>>>>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>>>>> }
>>>>>>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>>>>>>> false);
>>>>>>>>>>> + getHost().addElement(daysContainer,
>>>>>>>>>>> false);
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>>>>> new Event("itemsCreated") );
>>>>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>>>>> var index:Number =
>>>>>>>>>>> model.getIndexForSelectedDate(
>>>>>>>>>> );
>>>>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>>>>
>>>>>>>>>>> -
>>>>>>>>>>> IEventDispatcher(_strand).dispatchEvent(new
>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>> + getHost().dispatchEvent(new
>>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>>> + getHost().dispatchEvent( new
>>>>>>>>>>> Event("change")
>>>>>>>>>>> );
>>>>>>>>>>> }
>>>>>>>>>>>
>>>>>>>>>>> /**
>>>>>>>>>>> diff --git
>>>>>>>>>>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>>> @@ -81,7 +81,6 @@ package
>>>>>>>>>>> org.apache.royale.html.beads.controllers
>>>>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>>>>> DateChooserList;
>>>>>>>>>>> var model:DateChooserModel =
>>>>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>>>>> as DateChooserModel;
>>>>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>>>>> Event("change") );
>>>>>>>>>>> }
>>>>>>>>>>>
>>>>>>>>>>> /**
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>>>> contact
>>>>>>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>>"
>>>>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>>>'].
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>> Piotr Zarzycki
>>>>>>>>>
>>>>>>>>> mobile: +48 880 859 557
>>>>>>>>> skype: zarzycki10
>>>>>>>>>
>>>>>>>>> LinkedIn:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww>
>>>>>>>>> .l
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w.l>
>>>>>>>>> in
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w>.
>>>>>>>>> lin>
>>>>>>>>> ke
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w>.
>>>>>>>>> li
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww>
>>>>>>>>> w>.
>>>>>>>>> li>
>>>>>>>>> nke>
>>>>>>>>> din.com <http://din.com/>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n.com <http://n.com/>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1
>>>>>>>>> b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=p6Pk
>>>>>>>>> yp6pLodpmEnEUeVe%2Fn6Wgd9g0vNvW9ktUIRKMZI%3D&reserved=0>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n>.
>>>>>>>>>
>>>>>>>>> com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5
>>>>>>>>> a7
>>>>>>>>>
>>>>>>>>> b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rTTo
>>>>>>>>> 6I
>>>>>>>>> w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n>.
>>>>>>>>> co
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi>
>>>>>>>>> n
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>> n>.
>>>>>>>>> co>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7
>>>>>>>>> b3
>>>>>>>>> 44
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2
>>>>>>>>> Be
>>>>>>>>> VT
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=0
>>>>>>>>> 2%
>>>>>>>>> 7C
>>>>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&s
>>>>>>>>> da
>>>>>>>>> ta
>>>>>>>>> =i
>>>>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l>.
>>>>>>>>> li
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l>.
>>>>>>>>> li>
>>>>>>>>> nk
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l>.
>>>>>>>>> li
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp>
>>>>>>>>> l>.
>>>>>>>>> li>
>>>>>>>>> nk>
>>>>>>>>> edin.com <http://edin.com/>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in.com <http://in.com/>%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b
>>>>>>>>> 1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=u7o
>>>>>>>>> zW7xs5FFLQ2HfIYLIgyfAED2h5c49NuTwArKyE%2F8%3D&reserved=0>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in>
>>>>>>>>>
>>>>>>>>> .com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b
>>>>>>>>> 5a
>>>>>>>>>
>>>>>>>>> 7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGwkr
>>>>>>>>> fN
>>>>>>>>> 54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in>
>>>>>>>>> .c
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed>
>>>>>>>>> in
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>> in>
>>>>>>>>> .c>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a
>>>>>>>>> 7b
>>>>>>>>> 34
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2x
>>>>>>>>> AX
>>>>>>>>> Fa
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki
>>>>>>>>> -9
>>>>>>>>> 2a
>>>>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364
>>>>>>>>> 50
>>>>>>>>> 89
>>>>>>>>> 47
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&res
>>>>>>>>> er
>>>>>>>>> ve
>>>>>>>>> d=
>>>>>>>>> 0>
>>>>>>>>>
>>>>>>>>> GitHub:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi>
>>>>>>>>> th
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> ith>
>>>>>>>>> ub
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it>
>>>>>>>>> hub>
>>>>>>>>> .c
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it>
>>>>>>>>> hu
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it>
>>>>>>>>> hu>
>>>>>>>>> b.c>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b7
>>>>>>>>> 78
>>>>>>>>> 49
>>>>>>>>> %7
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdat
>>>>>>>>> a=
>>>>>>>>> WZ
>>>>>>>>> tw
>>>>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Those look like change logs, but I'm not recalling why you needed to do
that. That looks pretty expensive to me.
-Alex
On 11/1/17, 10:33 AM, "Harbs" <ha...@gmail.com> wrote:
>We discussed this a few months ago:
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%
>2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapper.
>as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b34
>438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4kD
>e%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0
><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>om%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic
>%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FHTMLElementWrapper
>.as%23L68&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1b5a7b3
>4438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=ENIiI7HlHRzg2Pz4k
>De%2BRFrIIxlP10L3X22oA%2Bmlovk%3D&reserved=0>
>
>Harbs
>
>> On Nov 1, 2017, at 7:12 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>
>> How did you "fix" that? The most obvious way that popped into my mind
>> would be pretty expensive.
>>
>> Thanks,
>> -Alex
>>
>> On 11/1/17, 8:45 AM, "Harbs" <harbs.lists@gmail.com
>><ma...@gmail.com>> wrote:
>>
>>> FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types and
>>> not BrowserEvents as they are in the goog libraries.
>>>
>>> OK. Let’s get rid of selectedDateChanged.
>>>
>>>> On Nov 1, 2017, at 5:41 PM, Alex Harui <ah...@adobe.com.INVALID>
>>>>wrote:
>>>>
>>>> AIUI, events generated by an HTMLElement are caught by Google Closure
>>>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>>> even
>>>> things we think are MouseEvents are actually dispatched as
>>>> BrowserEvents.
>>>> So the actual type for lots of events on the JS side are not what the
>>>> metadata says. I think only the events we dispatch directly don't get
>>>> converted. So yes, that means that we are frequently lying about the
>>>> event type, but since JS doesn't do runtime checking, as long as your
>>>> code
>>>> doesn't need to check the type (via "is" or "as") everything should
>>>> "just
>>>> work".
>>>>
>>>> I'm always interested in running less code, so dispatching two events
>>>> seems unnecessary, and one should go away. I was only trying to say
>>>> that
>>>> I don't care about consistency that every property change event should
>>>> be
>>>> named "somePropertyChanged". IMO, it is ok for the most popular event
>>>> to
>>>> be just plain "change".
>>>>
>>>> My 2 cents,
>>>> -Alex
>>>>
>>>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com
>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>>
>>>>> I’m not sure why/how, but I checked and the change event on the
>>>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>>>
>>>>> Here’s what I get if I listen for both events and trace them to the
>>>>> console:
>>>>>
>>>>> org.apache.royale.events.Event {type: "selectedDateChanged", target:
>>>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>>> org.a…e.r…e.h…l.DateChooser,
>>>>> propagationStopped_: false, defaultPrevented: false, …}
>>>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>>> g…g.e…s.BrowserEvent}
>>>>>
>>>>> The type, target and currentTarget properties are correct in the
>>>>> BrowserEvent and the rest of the properties are undefined. So, I’m
>>>>>not
>>>>> sure that it really matters that it is a BrowserEvent, although the
>>>>> construction of it has to be less efficient.
>>>>>
>>>>> Either way, do you agree that there should be only one of these two
>>>>> events dispatched?
>>>>>
>>>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <aharui@adobe.com.INVALID
>>>>>><ma...@adobe.com.INVALID>>
>>>>>> wrote:
>>>>>>
>>>>>> I think the most common event should have a simple name like
>>>>>>"change".
>>>>>> It
>>>>>> makes it easier to remember.
>>>>>>
>>>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>>>> initiated
>>>>>> by an HTMLElement event. We are sort of taking advantage of the
>>>>>>fact
>>>>>> that
>>>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>>> type-check
>>>>>> the event class.
>>>>>>
>>>>>> My 2 cents,
>>>>>> -Alex
>>>>>>
>>>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>>>>>><ma...@gmail.com>
>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>
>>>>>><mailto:harbs.lists@gmail.com <ma...@gmail.com>>>>
>>>>>>wrote:
>>>>>>
>>>>>>> Nope.
>>>>>>>
>>>>>>> Copying my response from Github:
>>>>>>>
>>>>>>> The only place change is referenced in the Framework is in the
>>>>>>> metadata
>>>>>>> of DateChooser:
>>>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>>>
>>>>>>> That could easily be changed to:
>>>>>>> [Event(name="selectedDateChanged",
>>>>>>> type="org.apache.royale.events.Event")]
>>>>>>>
>>>>>>> The current metadata is actually incorrect, because the event type
>>>>>>>is
>>>>>>> org.apache.royale.events.BrowserEvent
>>>>>>>
>>>>>>> Harbs
>>>>>>>
>>>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>>>> <piotrzarzycki21@gmail.com <ma...@gmail.com>
>>>>>>>><mailto:piotrzarzycki21@gmail.com
>>>>>>>><ma...@gmail.com>>>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> You can remove it if it is not fired it up for some other cases in
>>>>>>>> DateChooser.
>>>>>>>>
>>>>>>>> Piotr
>>>>>>>>
>>>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com
>>>>>>>><ma...@gmail.com>
>>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>:
>>>>>>>>
>>>>>>>>> My comment in the commit message needs discussion.
>>>>>>>>>
>>>>>>>>> I think the change event should be removed. What do others think?
>>>>>>>>>
>>>>>>>>> Harbs
>>>>>>>>>
>>>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org
>>>>>>>>>><ma...@apache.org>
>>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>> wrote:
>>>>>>>>>>
>>>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>>> repository.
>>>>>>>>>>
>>>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>>>> in repository
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>>>>>>>>>>gi
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fgi>
>>>>>>>>>> tb
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> itb>
>>>>>>>>>> ox
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2
>>>>>>>>>>Fg>
>>>>>>>>>> it>
>>>>>>>>>> box>
>>>>>>>>>> .apache.org
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>apache.org%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%
>>>>>>>>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&s
>>>>>>>>>>data=3bh9wC0Op3OH3psgqimuLvLvEWpvkRK3VX4UTcM%2F6X8%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap>
>>>>>>>>>> ache.org
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ache.org%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7C
>>>>>>>>>>fa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sda
>>>>>>>>>>ta=qICErbclqu41fuNV6k4X%2BwwDgUEQm5%2FnvXPkQmtUuGQ%3D&reserved=0>
>>>>>>>>>>%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>>>
>>>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata
>>>>>>>>>>=c
>>>>>>>>>> TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap>
>>>>>>>>>> ac
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>ap>
>>>>>>>>>> ac>
>>>>>>>>>> he.org
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>he.org%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa
>>>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata
>>>>>>>>>>=y%2BMNhg4YUcOb%2F29PSq9fplNGzZGCYBus85a%2BV1DnLsA%3D&reserved=0>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>he
>>>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
>>>>>>>>>>he>
>>>>>>>>>>
>>>>>>>>>>.org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b
>>>>>>>>>>1b
>>>>>>>>>>
>>>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=pP5
>>>>>>>>>>w8
>>>>>>>>>>
>>>>>>>>>>NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&data
>>>>>>>>>>=0
>>>>>>>>>> 2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0
>>>>>>>>>>pr
>>>>>>>>>> Ot
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2
>>>>>>>>>>Fa
>>>>>>>>>> sf
>>>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>>>>>>>>>>0%
>>>>>>>>>> 7C
>>>>>>>>>> 63
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DST
>>>>>>>>>>g%
>>>>>>>>>> 3D
>>>>>>>>>> &r
>>>>>>>>>> eserved=0
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>>>>> push:
>>>>>>>>>> new 2072541 Fixes #24
>>>>>>>>>> 2072541 is described below
>>>>>>>>>>
>>>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>>>
>>>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>>>
>>>>>>>>>> Fixes #24
>>>>>>>>>>
>>>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>>>> event
>>>>>>>>> and a “changed” event for the same action. It seems like we
>>>>>>>>>should
>>>>>>>>> dispatch
>>>>>>>>> one or the other.
>>>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>>>> events
>>>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>>>> I think the change event should be removed.
>>>>>>>>>> ---
>>>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>>>> ++++++++++++----
>>>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>>>
>>>>>>>>>> diff --git
>>>>>>>>>>a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>>>
>>>>>>>>>> /**
>>>>>>>>>> + * @royaleignorecoercion
>>>>>>>>>> org.apache.royale.core.UIBase
>>>>>>>>>> + */
>>>>>>>>>> + private function getHost():UIBase
>>>>>>>>>> + {
>>>>>>>>>> + return _strand as UIBase;
>>>>>>>>>> + }
>>>>>>>>>> + /**
>>>>>>>>>> * The button that causes the previous month to be
>>>>>>>>> displayed by the DateChooser.
>>>>>>>>>> *
>>>>>>>>>> * @langversion 3.0
>>>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>>>> monthButtonsContainer.
>>>>>>>>> addElement(_nextMonthButton);
>>>>>>>>>>
>>>>>>>>>> -
>>>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>>>> false);
>>>>>>>>>> +
>>>>>>>>>>getHost().addElement(monthButtonsContainer,
>>>>>>>>> false);
>>>>>>>>>>
>>>>>>>>>> // DAY NAMES
>>>>>>>>>>
>>>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>>>> }
>>>>>>>>>> -
>>>>>>>>>> UIBase(_strand).addElement(dayNamesContainer,
>>>>>>>>> false);
>>>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>>>> false);
>>>>>>>>>>
>>>>>>>>>> // DAYS
>>>>>>>>>>
>>>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>>>> COMPILE::SWF {
>>>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>>>> }
>>>>>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>>>>>> false);
>>>>>>>>>> + getHost().addElement(daysContainer,
>>>>>>>>>>false);
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>>>> new Event("itemsCreated") );
>>>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>>>> var index:Number =
>>>>>>>>>> model.getIndexForSelectedDate(
>>>>>>>>> );
>>>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>>>
>>>>>>>>>> -
>>>>>>>>>>IEventDispatcher(_strand).dispatchEvent(new
>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>> + getHost().dispatchEvent(new
>>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>>> + getHost().dispatchEvent( new
>>>>>>>>>>Event("change")
>>>>>>>>>> );
>>>>>>>>>> }
>>>>>>>>>>
>>>>>>>>>> /**
>>>>>>>>>> diff --git
>>>>>>>>>>a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>>> @@ -81,7 +81,6 @@ package
>>>>>>>>>>org.apache.royale.html.beads.controllers
>>>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>>>> DateChooserList;
>>>>>>>>>> var model:DateChooserModel =
>>>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>>>> as DateChooserModel;
>>>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>>>> Event("change") );
>>>>>>>>>> }
>>>>>>>>>>
>>>>>>>>>> /**
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>>> contact
>>>>>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>>>"
>>>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>>
>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>
>>>>>>>>>> <mailto:commits@royale.apache.org
>>>>>>>>>><ma...@royale.apache.org>>>>'].
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Piotr Zarzycki
>>>>>>>>
>>>>>>>> mobile: +48 880 859 557
>>>>>>>> skype: zarzycki10
>>>>>>>>
>>>>>>>> LinkedIn:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
>>>>>>>>.l
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w.l>
>>>>>>>> in
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w>.
>>>>>>>> lin>
>>>>>>>> ke
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w>.
>>>>>>>> li
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fww
>>>>>>>>w>.
>>>>>>>> li>
>>>>>>>> nke>
>>>>>>>> din.com
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n.com%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b1
>>>>>>>>b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=p6Pk
>>>>>>>>yp6pLodpmEnEUeVe%2Fn6Wgd9g0vNvW9ktUIRKMZI%3D&reserved=0>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n>.
>>>>>>>>
>>>>>>>>com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5
>>>>>>>>a7
>>>>>>>>
>>>>>>>>b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rTTo
>>>>>>>>6I
>>>>>>>> w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n>.
>>>>>>>> co
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdi
>>>>>>>>n>.
>>>>>>>> co>
>>>>>>>>
>>>>>>>>
>>>>>>>>m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7
>>>>>>>>b3
>>>>>>>> 44
>>>>>>>>
>>>>>>>>
>>>>>>>>38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2
>>>>>>>>Be
>>>>>>>> VT
>>>>>>>>
>>>>>>>>
>>>>>>>>yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=0
>>>>>>>>2%
>>>>>>>> 7C
>>>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&s
>>>>>>>>da
>>>>>>>> ta
>>>>>>>> =i
>>>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l>.
>>>>>>>> li
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l>.
>>>>>>>> li>
>>>>>>>> nk
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l>.
>>>>>>>> li
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>>>>>l>.
>>>>>>>> li>
>>>>>>>> nk>
>>>>>>>> edin.com
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in.com%2F&data=02%7C01%7C%7C00ddc95e7ca34fa70a7b08d5214eb38b%7Cfa7b
>>>>>>>>1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451544263115035&sdata=u7o
>>>>>>>>zW7xs5FFLQ2HfIYLIgyfAED2h5c49NuTwArKyE%2F8%3D&reserved=0>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in>
>>>>>>>>
>>>>>>>>.com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b
>>>>>>>>5a
>>>>>>>>
>>>>>>>>7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGwkr
>>>>>>>>fN
>>>>>>>> 54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in>
>>>>>>>> .c
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fed
>>>>>>>>in>
>>>>>>>> .c>
>>>>>>>>
>>>>>>>>
>>>>>>>>om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a
>>>>>>>>7b
>>>>>>>> 34
>>>>>>>>
>>>>>>>>
>>>>>>>>438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2x
>>>>>>>>AX
>>>>>>>> Fa
>>>>>>>>
>>>>>>>>
>>>>>>>>jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki
>>>>>>>>-9
>>>>>>>> 2a
>>>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364
>>>>>>>>50
>>>>>>>> 89
>>>>>>>> 47
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&res
>>>>>>>>er
>>>>>>>> ve
>>>>>>>> d=
>>>>>>>> 0>
>>>>>>>>
>>>>>>>> GitHub:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>>>>>>>>th
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>ith>
>>>>>>>> ub
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it>
>>>>>>>> hub>
>>>>>>>> .c
>>>>>>>>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it>
>>>>>>>> hu
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it>
>>>>>>>> hu>
>>>>>>>> b.c>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b7
>>>>>>>>78
>>>>>>>> 49
>>>>>>>> %7
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdat
>>>>>>>>a=
>>>>>>>> WZ
>>>>>>>> tw
>>>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
We discussed this a few months ago:
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as#L68 <https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as#L68>
Harbs
> On Nov 1, 2017, at 7:12 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> How did you "fix" that? The most obvious way that popped into my mind
> would be pretty expensive.
>
> Thanks,
> -Alex
>
> On 11/1/17, 8:45 AM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
>
>> FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types and
>> not BrowserEvents as they are in the goog libraries.
>>
>> OK. Let’s get rid of selectedDateChanged.
>>
>>> On Nov 1, 2017, at 5:41 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>>
>>> AIUI, events generated by an HTMLElement are caught by Google Closure
>>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>> even
>>> things we think are MouseEvents are actually dispatched as
>>> BrowserEvents.
>>> So the actual type for lots of events on the JS side are not what the
>>> metadata says. I think only the events we dispatch directly don't get
>>> converted. So yes, that means that we are frequently lying about the
>>> event type, but since JS doesn't do runtime checking, as long as your
>>> code
>>> doesn't need to check the type (via "is" or "as") everything should
>>> "just
>>> work".
>>>
>>> I'm always interested in running less code, so dispatching two events
>>> seems unnecessary, and one should go away. I was only trying to say
>>> that
>>> I don't care about consistency that every property change event should
>>> be
>>> named "somePropertyChanged". IMO, it is ok for the most popular event
>>> to
>>> be just plain "change".
>>>
>>> My 2 cents,
>>> -Alex
>>>
>>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com
>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>
>>>> I’m not sure why/how, but I checked and the change event on the
>>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>>
>>>> Here’s what I get if I listen for both events and trace them to the
>>>> console:
>>>>
>>>> org.apache.royale.events.Event {type: "selectedDateChanged", target:
>>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>> org.a…e.r…e.h…l.DateChooser,
>>>> propagationStopped_: false, defaultPrevented: false, …}
>>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>> g…g.e…s.BrowserEvent}
>>>>
>>>> The type, target and currentTarget properties are correct in the
>>>> BrowserEvent and the rest of the properties are undefined. So, I’m not
>>>> sure that it really matters that it is a BrowserEvent, although the
>>>> construction of it has to be less efficient.
>>>>
>>>> Either way, do you agree that there should be only one of these two
>>>> events dispatched?
>>>>
>>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <aharui@adobe.com.INVALID <ma...@adobe.com.INVALID>>
>>>>> wrote:
>>>>>
>>>>> I think the most common event should have a simple name like "change".
>>>>> It
>>>>> makes it easier to remember.
>>>>>
>>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>>> initiated
>>>>> by an HTMLElement event. We are sort of taking advantage of the fact
>>>>> that
>>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>> type-check
>>>>> the event class.
>>>>>
>>>>> My 2 cents,
>>>>> -Alex
>>>>>
>>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>
>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>> wrote:
>>>>>
>>>>>> Nope.
>>>>>>
>>>>>> Copying my response from Github:
>>>>>>
>>>>>> The only place change is referenced in the Framework is in the
>>>>>> metadata
>>>>>> of DateChooser:
>>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>>
>>>>>> That could easily be changed to:
>>>>>> [Event(name="selectedDateChanged",
>>>>>> type="org.apache.royale.events.Event")]
>>>>>>
>>>>>> The current metadata is actually incorrect, because the event type is
>>>>>> org.apache.royale.events.BrowserEvent
>>>>>>
>>>>>> Harbs
>>>>>>
>>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>>> <piotrzarzycki21@gmail.com <ma...@gmail.com> <mailto:piotrzarzycki21@gmail.com <ma...@gmail.com>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>> You can remove it if it is not fired it up for some other cases in
>>>>>>> DateChooser.
>>>>>>>
>>>>>>> Piotr
>>>>>>>
>>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com <ma...@gmail.com>
>>>>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>>:
>>>>>>>
>>>>>>>> My comment in the commit message needs discussion.
>>>>>>>>
>>>>>>>> I think the change event should be removed. What do others think?
>>>>>>>>
>>>>>>>> Harbs
>>>>>>>>
>>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org <ma...@apache.org>
>>>>>>>>> <mailto:harbs@apache.org <ma...@apache.org>> wrote:
>>>>>>>>>
>>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>> repository.
>>>>>>>>>
>>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>>> in repository
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi>
>>>>>>>>> tb
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> itb>
>>>>>>>>> ox
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg>
>>>>>>>>> it>
>>>>>>>>> box>
>>>>>>>>> .apache.org <http://apache.org/>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap>
>>>>>>>>> ache.org <http://ache.org/>%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>> 7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=c
>>>>>>>>> TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap>
>>>>>>>>> ac
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap>
>>>>>>>>> ac>
>>>>>>>>> he.org <http://he.org/>
>>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhe <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhe>
>>>>>>>>> .org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b
>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=pP5w8
>>>>>>>>> NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&data=0
>>>>>>>>> 2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>>
>>>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0pr
>>>>>>>>> Ot
>>>>>>>>>
>>>>>>>>> yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2Fa
>>>>>>>>> sf
>>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>>>>>>>>> 7C
>>>>>>>>> 63
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%
>>>>>>>>> 3D
>>>>>>>>> &r
>>>>>>>>> eserved=0
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>>>> push:
>>>>>>>>> new 2072541 Fixes #24
>>>>>>>>> 2072541 is described below
>>>>>>>>>
>>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>
>>>>>>>>> <mailto:harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>>
>>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>>
>>>>>>>>> Fixes #24
>>>>>>>>>
>>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>>> event
>>>>>>>> and a “changed” event for the same action. It seems like we should
>>>>>>>> dispatch
>>>>>>>> one or the other.
>>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>>> events
>>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>>> I think the change event should be removed.
>>>>>>>>> ---
>>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>>> ++++++++++++----
>>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>>
>>>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>>
>>>>>>>>> /**
>>>>>>>>> + * @royaleignorecoercion
>>>>>>>>> org.apache.royale.core.UIBase
>>>>>>>>> + */
>>>>>>>>> + private function getHost():UIBase
>>>>>>>>> + {
>>>>>>>>> + return _strand as UIBase;
>>>>>>>>> + }
>>>>>>>>> + /**
>>>>>>>>> * The button that causes the previous month to be
>>>>>>>> displayed by the DateChooser.
>>>>>>>>> *
>>>>>>>>> * @langversion 3.0
>>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>>> monthButtonsContainer.
>>>>>>>> addElement(_nextMonthButton);
>>>>>>>>>
>>>>>>>>> -
>>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>>> false);
>>>>>>>>> + getHost().addElement(monthButtonsContainer,
>>>>>>>> false);
>>>>>>>>>
>>>>>>>>> // DAY NAMES
>>>>>>>>>
>>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>>> COMPILE::SWF {
>>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>>> }
>>>>>>>>> -
>>>>>>>>> UIBase(_strand).addElement(dayNamesContainer,
>>>>>>>> false);
>>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>>> false);
>>>>>>>>>
>>>>>>>>> // DAYS
>>>>>>>>>
>>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>>> COMPILE::SWF {
>>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>>> }
>>>>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>>>>> false);
>>>>>>>>> + getHost().addElement(daysContainer, false);
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>>> new Event("itemsCreated") );
>>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>>> var index:Number =
>>>>>>>>> model.getIndexForSelectedDate(
>>>>>>>> );
>>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>>
>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>> + getHost().dispatchEvent(new
>>>>>>>> Event("selectedDateChanged"));
>>>>>>>>> + getHost().dispatchEvent( new Event("change")
>>>>>>>>> );
>>>>>>>>> }
>>>>>>>>>
>>>>>>>>> /**
>>>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>>> DateChooserList;
>>>>>>>>> var model:DateChooserModel =
>>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>>> as DateChooserModel;
>>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>>> Event("change") );
>>>>>>>>> }
>>>>>>>>>
>>>>>>>>> /**
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>> contact
>>>>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>"
>>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>
>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>>> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>>'].
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Piotr Zarzycki
>>>>>>>
>>>>>>> mobile: +48 880 859 557
>>>>>>> skype: zarzycki10
>>>>>>>
>>>>>>> LinkedIn:
>>>>>>>
>>>>>>>
>>>>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l>
>>>>>>> in
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww>.
>>>>>>> lin>
>>>>>>> ke
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww>.
>>>>>>> li
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww>.
>>>>>>> li>
>>>>>>> nke>
>>>>>>> din.com <http://din.com/>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin>.
>>>>>>> com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5a7
>>>>>>> b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rTTo6I
>>>>>>> w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin>.
>>>>>>> co
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin>.
>>>>>>> co>
>>>>>>>
>>>>>>> m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b3
>>>>>>> 44
>>>>>>>
>>>>>>> 38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2Be
>>>>>>> VT
>>>>>>>
>>>>>>> yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=02%
>>>>>>> 7C
>>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>>
>>>>>>>
>>>>>>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sda
>>>>>>> ta
>>>>>>> =i
>>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl>.
>>>>>>> li
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl>.
>>>>>>> li>
>>>>>>> nk
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl>.
>>>>>>> li
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl>.
>>>>>>> li>
>>>>>>> nk>
>>>>>>> edin.com <http://edin.com/>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin>
>>>>>>> .com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5a
>>>>>>> 7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGwkrfN
>>>>>>> 54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin>
>>>>>>> .c
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin>
>>>>>>> .c>
>>>>>>>
>>>>>>> om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b
>>>>>>> 34
>>>>>>>
>>>>>>> 438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2xAX
>>>>>>> Fa
>>>>>>>
>>>>>>> jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki-9
>>>>>>> 2a
>>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>>
>>>>>>>
>>>>>>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450
>>>>>>> 89
>>>>>>> 47
>>>>>>>
>>>>>>>
>>>>>>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reser
>>>>>>> ve
>>>>>>> d=
>>>>>>> 0>
>>>>>>>
>>>>>>> GitHub:
>>>>>>>
>>>>>>>
>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith>
>>>>>>> ub
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit>
>>>>>>> hub>
>>>>>>> .c
>>>>>>>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit>
>>>>>>> hu
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit>
>>>>>>> hu>
>>>>>>> b.c>
>>>>>>>
>>>>>>>
>>>>>>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b778
>>>>>>> 49
>>>>>>> %7
>>>>>>>
>>>>>>>
>>>>>>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=
>>>>>>> WZ
>>>>>>> tw
>>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
How did you "fix" that? The most obvious way that popped into my mind
would be pretty expensive.
Thanks,
-Alex
On 11/1/17, 8:45 AM, "Harbs" <ha...@gmail.com> wrote:
>FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types and
>not BrowserEvents as they are in the goog libraries.
>
>OK. Let’s get rid of selectedDateChanged.
>
>> On Nov 1, 2017, at 5:41 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>
>> AIUI, events generated by an HTMLElement are caught by Google Closure
>> Library's event subsystem and dispatched as a BrowserEvent. I think
>>even
>> things we think are MouseEvents are actually dispatched as
>>BrowserEvents.
>> So the actual type for lots of events on the JS side are not what the
>> metadata says. I think only the events we dispatch directly don't get
>> converted. So yes, that means that we are frequently lying about the
>> event type, but since JS doesn't do runtime checking, as long as your
>>code
>> doesn't need to check the type (via "is" or "as") everything should
>>"just
>> work".
>>
>> I'm always interested in running less code, so dispatching two events
>> seems unnecessary, and one should go away. I was only trying to say
>>that
>> I don't care about consistency that every property change event should
>>be
>> named "somePropertyChanged". IMO, it is ok for the most popular event
>>to
>> be just plain "change".
>>
>> My 2 cents,
>> -Alex
>>
>> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com
>><ma...@gmail.com>> wrote:
>>
>>> I’m not sure why/how, but I checked and the change event on the
>>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>>
>>> Here’s what I get if I listen for both events and trace them to the
>>> console:
>>>
>>> org.apache.royale.events.Event {type: "selectedDateChanged", target:
>>> org.a…e.r…e.h…l.DateChooser, currentTarget:
>>>org.a…e.r…e.h…l.DateChooser,
>>> propagationStopped_: false, defaultPrevented: false, …}
>>> org.apache.royale.events.BrowserEvent {wrappedEvent:
>>>g…g.e…s.BrowserEvent}
>>>
>>> The type, target and currentTarget properties are correct in the
>>> BrowserEvent and the rest of the properties are undefined. So, I’m not
>>> sure that it really matters that it is a BrowserEvent, although the
>>> construction of it has to be less efficient.
>>>
>>> Either way, do you agree that there should be only one of these two
>>> events dispatched?
>>>
>>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <ah...@adobe.com.INVALID>
>>>>wrote:
>>>>
>>>> I think the most common event should have a simple name like "change".
>>>> It
>>>> makes it easier to remember.
>>>>
>>>> In JS, the actual type of most events is BrowserEvent if it was
>>>> initiated
>>>> by an HTMLElement event. We are sort of taking advantage of the fact
>>>> that
>>>> JS isn't strongly typed and hopefully nobody really needs to
>>>>type-check
>>>> the event class.
>>>>
>>>> My 2 cents,
>>>> -Alex
>>>>
>>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>>
>>>>> Nope.
>>>>>
>>>>> Copying my response from Github:
>>>>>
>>>>> The only place change is referenced in the Framework is in the
>>>>>metadata
>>>>> of DateChooser:
>>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>>
>>>>> That could easily be changed to:
>>>>> [Event(name="selectedDateChanged",
>>>>> type="org.apache.royale.events.Event")]
>>>>>
>>>>> The current metadata is actually incorrect, because the event type is
>>>>> org.apache.royale.events.BrowserEvent
>>>>>
>>>>> Harbs
>>>>>
>>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>>>>>><piotrzarzycki21@gmail.com <ma...@gmail.com>>
>>>>>> wrote:
>>>>>>
>>>>>> You can remove it if it is not fired it up for some other cases in
>>>>>> DateChooser.
>>>>>>
>>>>>> Piotr
>>>>>>
>>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com
>>>>>><ma...@gmail.com>>:
>>>>>>
>>>>>>> My comment in the commit message needs discussion.
>>>>>>>
>>>>>>> I think the change event should be removed. What do others think?
>>>>>>>
>>>>>>> Harbs
>>>>>>>
>>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org
>>>>>>>><ma...@apache.org> wrote:
>>>>>>>>
>>>>>>>> This is an automated email from the ASF dual-hosted git
>>>>>>>>repository.
>>>>>>>>
>>>>>>>> harbs pushed a commit to branch develop
>>>>>>>> in repository
>>>>>>>>
>>>>>>>>
>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>>>>>>>>tb
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>itb>
>>>>>>>> ox
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>>>>>>>>it>
>>>>>>>> box>
>>>>>>>> .apache.org
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap
>>>>>>>>ache.org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa
>>>>>>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=c
>>>>>>>>TdyosIbkoYs%2B7dNmAYMjWZA1LeK0dnhAdsF1zEuXH4%3D&reserved=0>
>>>>>>>>
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap
>>>>>>>>ac
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fap
>>>>>>>>ac>
>>>>>>>> he.org
>>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhe
>>>>>>>>.org%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b
>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=pP5w8
>>>>>>>>NbST3hPFoRy%2B4fnPVXBB%2FXnBCDrngOsHkz2Yog%3D&reserved=0>%2F&data=0
>>>>>>>>2%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>>>
>>>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0pr
>>>>>>>>Ot
>>>>>>>>
>>>>>>>>yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2Fa
>>>>>>>>sf
>>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>>
>>>>>>>>
>>>>>>>>48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>>>>>>>>7C
>>>>>>>> 63
>>>>>>>>
>>>>>>>>
>>>>>>>>6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%
>>>>>>>>3D
>>>>>>>> &r
>>>>>>>> eserved=0
>>>>>>>>
>>>>>>>>
>>>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>>> push:
>>>>>>>> new 2072541 Fixes #24
>>>>>>>> 2072541 is described below
>>>>>>>>
>>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>
>>>>>>>><mailto:harbs@in-tools.com <ma...@in-tools.com>>>
>>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>>
>>>>>>>> Fixes #24
>>>>>>>>
>>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>>> event
>>>>>>> and a “changed” event for the same action. It seems like we should
>>>>>>> dispatch
>>>>>>> one or the other.
>>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>>> events
>>>>>>> which become BrowserEvents when dispatched.
>>>>>>>> I think the change event should be removed.
>>>>>>>> ---
>>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>>> ++++++++++++----
>>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/DateChooserView.as
>>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>>
>>>>>>>> /**
>>>>>>>> + * @royaleignorecoercion
>>>>>>>>org.apache.royale.core.UIBase
>>>>>>>> + */
>>>>>>>> + private function getHost():UIBase
>>>>>>>> + {
>>>>>>>> + return _strand as UIBase;
>>>>>>>> + }
>>>>>>>> + /**
>>>>>>>> * The button that causes the previous month to be
>>>>>>> displayed by the DateChooser.
>>>>>>>> *
>>>>>>>> * @langversion 3.0
>>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>>> monthButtonsContainer.
>>>>>>> addElement(_nextMonthButton);
>>>>>>>>
>>>>>>>> -
>>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>>> false);
>>>>>>>> + getHost().addElement(monthButtonsContainer,
>>>>>>> false);
>>>>>>>>
>>>>>>>> // DAY NAMES
>>>>>>>>
>>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>>> COMPILE::SWF {
>>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>>> }
>>>>>>>> -
>>>>>>>>UIBase(_strand).addElement(dayNamesContainer,
>>>>>>> false);
>>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>>> false);
>>>>>>>>
>>>>>>>> // DAYS
>>>>>>>>
>>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>>> COMPILE::SWF {
>>>>>>>> daysContainer.percentWidth = 100;
>>>>>>>> }
>>>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>>>> false);
>>>>>>>> + getHost().addElement(daysContainer, false);
>>>>>>>>
>>>>>>>>
>>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>>> new Event("itemsCreated") );
>>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>>> var index:Number =
>>>>>>>> model.getIndexForSelectedDate(
>>>>>>> );
>>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>>
>>>>>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>>>>>> Event("selectedDateChanged"));
>>>>>>>> + getHost().dispatchEvent(new
>>>>>>> Event("selectedDateChanged"));
>>>>>>>> + getHost().dispatchEvent( new Event("change")
>>>>>>>> );
>>>>>>>> }
>>>>>>>>
>>>>>>>> /**
>>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>>>>>> var list:DateChooserList = event.target as
>>>>>>>> DateChooserList;
>>>>>>>> var model:DateChooserModel =
>>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>>> as DateChooserModel;
>>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>>> Event("change") );
>>>>>>>> }
>>>>>>>>
>>>>>>>> /**
>>>>>>>>
>>>>>>>> --
>>>>>>>> To stop receiving notification emails like this one, please
>>>>>>>>contact
>>>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>><ma...@royale.apache.org>>"
>>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org>
>>>>>>>><mailto:commits@royale.apache.org
>>>>>>>><ma...@royale.apache.org>>>'].
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Piotr Zarzycki
>>>>>>
>>>>>> mobile: +48 880 859 557
>>>>>> skype: zarzycki10
>>>>>>
>>>>>> LinkedIn:
>>>>>>
>>>>>>
>>>>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l
>>>>>>in
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
>>>>>>lin>
>>>>>> ke
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
>>>>>>li
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
>>>>>>li>
>>>>>> nke>
>>>>>> din.com
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.
>>>>>>com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5a7
>>>>>>b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=LQF5rTTo6I
>>>>>>w1toxzJNk%2BiaKFtekYYKVgHaPUiO1ddnM%3D&reserved=0>
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.
>>>>>>co
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.
>>>>>>co>
>>>>>>
>>>>>>m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b3
>>>>>>44
>>>>>>
>>>>>>38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2Be
>>>>>>VT
>>>>>>
>>>>>>yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=02%
>>>>>>7C
>>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>>
>>>>>>
>>>>>>9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sda
>>>>>>ta
>>>>>> =i
>>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>>
>>>>>>
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.
>>>>>>li
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.
>>>>>>li>
>>>>>> nk
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.
>>>>>>li
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.
>>>>>>li>
>>>>>> nk>
>>>>>> edin.com
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin
>>>>>>.com%2F&data=02%7C01%7C%7C7b4540aedf554e9abd0b08d5213f9c98%7Cfa7b1b5a
>>>>>>7b34438794aed2c178decee1%7C0%7C0%7C636451479453261727&sdata=hXeGwkrfN
>>>>>>54Goi%2B01aEuixeq%2Fr6jgLOkcZ7PW%2BiNQxo%3D&reserved=0>
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin
>>>>>>.c
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin
>>>>>>.c>
>>>>>>
>>>>>>om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b
>>>>>>34
>>>>>>
>>>>>>438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2xAX
>>>>>>Fa
>>>>>>
>>>>>>jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki-9
>>>>>>2a
>>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>>
>>>>>>
>>>>>>efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450
>>>>>>89
>>>>>> 47
>>>>>>
>>>>>>
>>>>>>28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reser
>>>>>>ve
>>>>>> d=
>>>>>> 0>
>>>>>>
>>>>>> GitHub:
>>>>>>
>>>>>>
>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
>>>>>>ub
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>>>>>hub>
>>>>>> .c
>>>>>>
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>>>>>hu
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>>>>>hu>
>>>>>> b.c>
>>>>>>
>>>>>>
>>>>>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b778
>>>>>>49
>>>>>> %7
>>>>>>
>>>>>>
>>>>>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=
>>>>>>WZ
>>>>>> tw
>>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
FWIW, I fixed MouseEvents and KeyboardEvents to be the Royale types and not BrowserEvents as they are in the goog libraries.
OK. Let’s get rid of selectedDateChanged.
> On Nov 1, 2017, at 5:41 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> AIUI, events generated by an HTMLElement are caught by Google Closure
> Library's event subsystem and dispatched as a BrowserEvent. I think even
> things we think are MouseEvents are actually dispatched as BrowserEvents.
> So the actual type for lots of events on the JS side are not what the
> metadata says. I think only the events we dispatch directly don't get
> converted. So yes, that means that we are frequently lying about the
> event type, but since JS doesn't do runtime checking, as long as your code
> doesn't need to check the type (via "is" or "as") everything should "just
> work".
>
> I'm always interested in running less code, so dispatching two events
> seems unnecessary, and one should go away. I was only trying to say that
> I don't care about consistency that every property change event should be
> named "somePropertyChanged". IMO, it is ok for the most popular event to
> be just plain "change".
>
> My 2 cents,
> -Alex
>
> On 11/1/17, 12:37 AM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
>
>> I’m not sure why/how, but I checked and the change event on the
>> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>>
>> Here’s what I get if I listen for both events and trace them to the
>> console:
>>
>> org.apache.royale.events.Event {type: "selectedDateChanged", target:
>> org.a…e.r…e.h…l.DateChooser, currentTarget: org.a…e.r…e.h…l.DateChooser,
>> propagationStopped_: false, defaultPrevented: false, …}
>> org.apache.royale.events.BrowserEvent {wrappedEvent: g…g.e…s.BrowserEvent}
>>
>> The type, target and currentTarget properties are correct in the
>> BrowserEvent and the rest of the properties are undefined. So, I’m not
>> sure that it really matters that it is a BrowserEvent, although the
>> construction of it has to be less efficient.
>>
>> Either way, do you agree that there should be only one of these two
>> events dispatched?
>>
>>> On Nov 1, 2017, at 5:38 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>>
>>> I think the most common event should have a simple name like "change".
>>> It
>>> makes it easier to remember.
>>>
>>> In JS, the actual type of most events is BrowserEvent if it was
>>> initiated
>>> by an HTMLElement event. We are sort of taking advantage of the fact
>>> that
>>> JS isn't strongly typed and hopefully nobody really needs to type-check
>>> the event class.
>>>
>>> My 2 cents,
>>> -Alex
>>>
>>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>>> <mailto:harbs.lists@gmail.com <ma...@gmail.com>>> wrote:
>>>
>>>> Nope.
>>>>
>>>> Copying my response from Github:
>>>>
>>>> The only place change is referenced in the Framework is in the metadata
>>>> of DateChooser:
>>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>>
>>>> That could easily be changed to:
>>>> [Event(name="selectedDateChanged",
>>>> type="org.apache.royale.events.Event")]
>>>>
>>>> The current metadata is actually incorrect, because the event type is
>>>> org.apache.royale.events.BrowserEvent
>>>>
>>>> Harbs
>>>>
>>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <piotrzarzycki21@gmail.com <ma...@gmail.com>>
>>>>> wrote:
>>>>>
>>>>> You can remove it if it is not fired it up for some other cases in
>>>>> DateChooser.
>>>>>
>>>>> Piotr
>>>>>
>>>>> 2017-11-01 0:23 GMT+01:00 Harbs <harbs.lists@gmail.com <ma...@gmail.com>>:
>>>>>
>>>>>> My comment in the commit message needs discussion.
>>>>>>
>>>>>> I think the change event should be removed. What do others think?
>>>>>>
>>>>>> Harbs
>>>>>>
>>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org <ma...@apache.org> wrote:
>>>>>>>
>>>>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>>>>
>>>>>>> harbs pushed a commit to branch develop
>>>>>>> in repository
>>>>>>>
>>>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitb <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitb>
>>>>>>> ox
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit>
>>>>>>> box>
>>>>>>> .apache.org <http://apache.org/>
>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapac <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapac>
>>>>>>> he.org <http://he.org/>%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>> 5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0prOt
>>>>>>> yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2Fasf
>>>>>>> %2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>>
>>>>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C
>>>>>>> 63
>>>>>>>
>>>>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%3D
>>>>>>> &r
>>>>>>> eserved=0
>>>>>>>
>>>>>>>
>>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>> push:
>>>>>>> new 2072541 Fixes #24
>>>>>>> 2072541 is described below
>>>>>>>
>>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com> <mailto:harbs@in-tools.com <ma...@in-tools.com>>>
>>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>>
>>>>>>> Fixes #24
>>>>>>>
>>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>> event
>>>>>> and a “changed” event for the same action. It seems like we should
>>>>>> dispatch
>>>>>> one or the other.
>>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>> events
>>>>>> which become BrowserEvents when dispatched.
>>>>>>> I think the change event should be removed.
>>>>>>> ---
>>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>>> ++++++++++++----
>>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>>
>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>>> index 2316f4a..17a5ef0 100644
>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/DateChooserView.as
>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/DateChooserView.as
>>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>>> private var daysContainer:DateChooserList;
>>>>>>>
>>>>>>> /**
>>>>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>>>>>> + */
>>>>>>> + private function getHost():UIBase
>>>>>>> + {
>>>>>>> + return _strand as UIBase;
>>>>>>> + }
>>>>>>> + /**
>>>>>>> * The button that causes the previous month to be
>>>>>> displayed by the DateChooser.
>>>>>>> *
>>>>>>> * @langversion 3.0
>>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>>> monthButtonsContainer.
>>>>>> addElement(_nextMonthButton);
>>>>>>>
>>>>>>> -
>>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>>> false);
>>>>>>> + getHost().addElement(monthButtonsContainer,
>>>>>> false);
>>>>>>>
>>>>>>> // DAY NAMES
>>>>>>>
>>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>>> COMPILE::SWF {
>>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>>> }
>>>>>>> - UIBase(_strand).addElement(dayNamesContainer,
>>>>>> false);
>>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>> false);
>>>>>>>
>>>>>>> // DAYS
>>>>>>>
>>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>>> COMPILE::SWF {
>>>>>>> daysContainer.percentWidth = 100;
>>>>>>> }
>>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>>> false);
>>>>>>> + getHost().addElement(daysContainer, false);
>>>>>>>
>>>>>>>
>>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>>> new Event("itemsCreated") );
>>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>>> var index:Number =
>>>>>>> model.getIndexForSelectedDate(
>>>>>> );
>>>>>>> daysContainer.selectedIndex = index;
>>>>>>>
>>>>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>>>>> Event("selectedDateChanged"));
>>>>>>> + getHost().dispatchEvent(new
>>>>>> Event("selectedDateChanged"));
>>>>>>> + getHost().dispatchEvent( new Event("change")
>>>>>>> );
>>>>>>> }
>>>>>>>
>>>>>>> /**
>>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>>>>> var list:DateChooserList = event.target as
>>>>>>> DateChooserList;
>>>>>>> var model:DateChooserModel =
>>>>>>> _strand.getBeadByType(IBeadModel)
>>>>>> as DateChooserModel;
>>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>>> Event("change") );
>>>>>>> }
>>>>>>>
>>>>>>> /**
>>>>>>>
>>>>>>> --
>>>>>>> To stop receiving notification emails like this one, please contact
>>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>"
>>>>>>> <commits@royale.apache.org <ma...@royale.apache.org> <mailto:commits@royale.apache.org <ma...@royale.apache.org>>>'].
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Piotr Zarzycki
>>>>>
>>>>> mobile: +48 880 859 557
>>>>> skype: zarzycki10
>>>>>
>>>>> LinkedIn:
>>>>>
>>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin>
>>>>> ke
>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.li <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.li>
>>>>> nke>
>>>>> din.com <http://din.com/>
>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.co <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.co>
>>>>> m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b344
>>>>> 38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2BeVT
>>>>> yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C
>>>>> 01%7C%7C0ff25865748242cefbda08d520b7784
>>>>>
>>>>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata
>>>>> =i
>>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>>
>>>>>
>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li>
>>>>> nk
>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li>
>>>>> nk>
>>>>> edin.com <http://edin.com/>
>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin.c <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin.c>
>>>>> om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b34
>>>>> 438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2xAXFa
>>>>> jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki-92a
>>>>> 53552&data=02%7C01%7C%7C0ff25865748242c
>>>>>
>>>>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645089
>>>>> 47
>>>>>
>>>>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reserve
>>>>> d=
>>>>> 0>
>>>>>
>>>>> GitHub:
>>>>>
>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub>
>>>>> .c
>>>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu>
>>>>> b.c>
>>>>>
>>>>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b77849
>>>>> %7
>>>>>
>>>>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=WZ
>>>>> tw
>>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
AIUI, events generated by an HTMLElement are caught by Google Closure
Library's event subsystem and dispatched as a BrowserEvent. I think even
things we think are MouseEvents are actually dispatched as BrowserEvents.
So the actual type for lots of events on the JS side are not what the
metadata says. I think only the events we dispatch directly don't get
converted. So yes, that means that we are frequently lying about the
event type, but since JS doesn't do runtime checking, as long as your code
doesn't need to check the type (via "is" or "as") everything should "just
work".
I'm always interested in running less code, so dispatching two events
seems unnecessary, and one should go away. I was only trying to say that
I don't care about consistency that every property change event should be
named "somePropertyChanged". IMO, it is ok for the most popular event to
be just plain "change".
My 2 cents,
-Alex
On 11/1/17, 12:37 AM, "Harbs" <ha...@gmail.com> wrote:
>I’m not sure why/how, but I checked and the change event on the
>DateChooser change event is BrowserEvent. Maybe that’s a bug.
>
>Here’s what I get if I listen for both events and trace them to the
>console:
>
>org.apache.royale.events.Event {type: "selectedDateChanged", target:
>org.a…e.r…e.h…l.DateChooser, currentTarget: org.a…e.r…e.h…l.DateChooser,
>propagationStopped_: false, defaultPrevented: false, …}
>org.apache.royale.events.BrowserEvent {wrappedEvent: g…g.e…s.BrowserEvent}
>
>The type, target and currentTarget properties are correct in the
>BrowserEvent and the rest of the properties are undefined. So, I’m not
>sure that it really matters that it is a BrowserEvent, although the
>construction of it has to be less efficient.
>
>Either way, do you agree that there should be only one of these two
>events dispatched?
>
>> On Nov 1, 2017, at 5:38 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>>
>> I think the most common event should have a simple name like "change".
>>It
>> makes it easier to remember.
>>
>> In JS, the actual type of most events is BrowserEvent if it was
>>initiated
>> by an HTMLElement event. We are sort of taking advantage of the fact
>>that
>> JS isn't strongly typed and hopefully nobody really needs to type-check
>> the event class.
>>
>> My 2 cents,
>> -Alex
>>
>> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com
>><ma...@gmail.com>> wrote:
>>
>>> Nope.
>>>
>>> Copying my response from Github:
>>>
>>> The only place change is referenced in the Framework is in the metadata
>>> of DateChooser:
>>> [Event(name="change", type="org.apache.royale.events.Event")]
>>>
>>> That could easily be changed to:
>>> [Event(name="selectedDateChanged",
>>>type="org.apache.royale.events.Event")]
>>>
>>> The current metadata is actually incorrect, because the event type is
>>> org.apache.royale.events.BrowserEvent
>>>
>>> Harbs
>>>
>>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com>
>>>> wrote:
>>>>
>>>> You can remove it if it is not fired it up for some other cases in
>>>> DateChooser.
>>>>
>>>> Piotr
>>>>
>>>> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>>>>
>>>>> My comment in the commit message needs discussion.
>>>>>
>>>>> I think the change event should be removed. What do others think?
>>>>>
>>>>> Harbs
>>>>>
>>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>>>>>>
>>>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>>>
>>>>>> harbs pushed a commit to branch develop
>>>>>> in repository
>>>>>>
>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitb
>>>>>>ox
>>>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>>>>>>box>
>>>>>> .apache.org
>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapac
>>>>>>he.org%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b
>>>>>>5a7b34438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=pG0prOt
>>>>>>yP38hDAZWo9shrc%2F%2FIIveXWBR5LJkOS4NfH4%3D&reserved=0>%2Frepos%2Fasf
>>>>>>%2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>>>
>>>>>>48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C
>>>>>>63
>>>>>>
>>>>>>6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%3D
>>>>>>&r
>>>>>> eserved=0
>>>>>>
>>>>>>
>>>>>> The following commit(s) were added to refs/heads/develop by this
>>>>>>push:
>>>>>> new 2072541 Fixes #24
>>>>>> 2072541 is described below
>>>>>>
>>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>>
>>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>>
>>>>>> Fixes #24
>>>>>>
>>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>>>>>>event
>>>>> and a “changed” event for the same action. It seems like we should
>>>>> dispatch
>>>>> one or the other.
>>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>>> discoverable. On the other hand, “change” is one of the special
>>>>>events
>>>>> which become BrowserEvents when dispatched.
>>>>>> I think the change event should be removed.
>>>>>> ---
>>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>>> ++++++++++++----
>>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>>
>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>>> index 2316f4a..17a5ef0 100644
>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/DateChooserView.as
>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/DateChooserView.as
>>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>>> private var daysContainer:DateChooserList;
>>>>>>
>>>>>> /**
>>>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>>>>> + */
>>>>>> + private function getHost():UIBase
>>>>>> + {
>>>>>> + return _strand as UIBase;
>>>>>> + }
>>>>>> + /**
>>>>>> * The button that causes the previous month to be
>>>>> displayed by the DateChooser.
>>>>>> *
>>>>>> * @langversion 3.0
>>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>>> monthButtonsContainer.
>>>>> addElement(_nextMonthButton);
>>>>>>
>>>>>> -
>>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>>> false);
>>>>>> + getHost().addElement(monthButtonsContainer,
>>>>> false);
>>>>>>
>>>>>> // DAY NAMES
>>>>>>
>>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>>> COMPILE::SWF {
>>>>>> dayNamesContainer.percentWidth = 100;
>>>>>> }
>>>>>> - UIBase(_strand).addElement(dayNamesContainer,
>>>>> false);
>>>>>> + getHost().addElement(dayNamesContainer,
>>>>>>false);
>>>>>>
>>>>>> // DAYS
>>>>>>
>>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>>> COMPILE::SWF {
>>>>>> daysContainer.percentWidth = 100;
>>>>>> }
>>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>>> false);
>>>>>> + getHost().addElement(daysContainer, false);
>>>>>>
>>>>>>
>>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>>> new Event("itemsCreated") );
>>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>>> var index:Number =
>>>>>>model.getIndexForSelectedDate(
>>>>> );
>>>>>> daysContainer.selectedIndex = index;
>>>>>>
>>>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>>>> Event("selectedDateChanged"));
>>>>>> + getHost().dispatchEvent(new
>>>>> Event("selectedDateChanged"));
>>>>>> + getHost().dispatchEvent( new Event("change")
>>>>>>);
>>>>>> }
>>>>>>
>>>>>> /**
>>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>> index d3ef05c..ccf3cbc 100644
>>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>>>> var list:DateChooserList = event.target as
>>>>>>DateChooserList;
>>>>>> var model:DateChooserModel =
>>>>>> _strand.getBeadByType(IBeadModel)
>>>>> as DateChooserModel;
>>>>>> model.selectedDate = list.selectedItem as Date;
>>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>>> Event("change") );
>>>>>> }
>>>>>>
>>>>>> /**
>>>>>>
>>>>>> --
>>>>>> To stop receiving notification emails like this one, please contact
>>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org>"
>>>>>><commits@royale.apache.org <ma...@royale.apache.org>>'].
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Piotr Zarzycki
>>>>
>>>> mobile: +48 880 859 557
>>>> skype: zarzycki10
>>>>
>>>> LinkedIn:
>>>>
>>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
>>>>ke
>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.li
>>>>nke>
>>>> din.com
>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdin.co
>>>>m%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b344
>>>>38794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=8Vthp0Wrfb%2BeVT
>>>>yudUKEmQx2gD0ojbKiMDeh0omHxOw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C
>>>>01%7C%7C0ff25865748242cefbda08d520b7784
>>>>
>>>>9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata
>>>>=i
>>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>>
>>>>
>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li
>>>>nk
>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.li
>>>>nk>
>>>> edin.com
>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fedin.c
>>>>om%2F&data=02%7C01%7C%7C817a277357384d327b7208d520fb6902%7Cfa7b1b5a7b34
>>>>438794aed2c178decee1%7C0%7C0%7C636451186536265548&sdata=xs3%2Biiq2xAXFa
>>>>jZear3dLmRjmEwQ8H2WBLfFh08AFKU%3D&reserved=0>%2Fin%2Fpiotr-zarzycki-92a
>>>>53552&data=02%7C01%7C%7C0ff25865748242c
>>>>
>>>>efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645089
>>>>47
>>>>
>>>>28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reserve
>>>>d=
>>>> 0>
>>>>
>>>> GitHub:
>>>>
>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
>>>>.c
>>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
>>>>b.c>
>>>>
>>>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b77849
>>>>%7
>>>>
>>>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=WZ
>>>>tw
>>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Piotr Zarzycki <pi...@gmail.com>.
Harbs,
Whole framework is working like that. We are getting in most cases
BroserEvent. I'm always in favor of "change" event, but the second one
could be also ok.
Piotr
2017-11-01 8:37 GMT+01:00 Harbs <ha...@gmail.com>:
> I’m not sure why/how, but I checked and the change event on the
> DateChooser change event is BrowserEvent. Maybe that’s a bug.
>
> Here’s what I get if I listen for both events and trace them to the
> console:
>
> org.apache.royale.events.Event {type: "selectedDateChanged", target:
> org.a…e.r…e.h…l.DateChooser, currentTarget: org.a…e.r…e.h…l.DateChooser,
> propagationStopped_: false, defaultPrevented: false, …}
> org.apache.royale.events.BrowserEvent {wrappedEvent: g…g.e…s.BrowserEvent}
>
> The type, target and currentTarget properties are correct in the
> BrowserEvent and the rest of the properties are undefined. So, I’m not sure
> that it really matters that it is a BrowserEvent, although the construction
> of it has to be less efficient.
>
> Either way, do you agree that there should be only one of these two events
> dispatched?
>
> > On Nov 1, 2017, at 5:38 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
> >
> > I think the most common event should have a simple name like "change".
> It
> > makes it easier to remember.
> >
> > In JS, the actual type of most events is BrowserEvent if it was initiated
> > by an HTMLElement event. We are sort of taking advantage of the fact
> that
> > JS isn't strongly typed and hopefully nobody really needs to type-check
> > the event class.
> >
> > My 2 cents,
> > -Alex
> >
> > On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com <mailto:
> harbs.lists@gmail.com>> wrote:
> >
> >> Nope.
> >>
> >> Copying my response from Github:
> >>
> >> The only place change is referenced in the Framework is in the metadata
> >> of DateChooser:
> >> [Event(name="change", type="org.apache.royale.events.Event")]
> >>
> >> That could easily be changed to:
> >> [Event(name="selectedDateChanged", type="org.apache.royale.
> events.Event")]
> >>
> >> The current metadata is actually incorrect, because the event type is
> >> org.apache.royale.events.BrowserEvent
> >>
> >> Harbs
> >>
> >>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com>
> >>> wrote:
> >>>
> >>> You can remove it if it is not fired it up for some other cases in
> >>> DateChooser.
> >>>
> >>> Piotr
> >>>
> >>> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
> >>>
> >>>> My comment in the commit message needs discussion.
> >>>>
> >>>> I think the change event should be removed. What do others think?
> >>>>
> >>>> Harbs
> >>>>
> >>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
> >>>>>
> >>>>> This is an automated email from the ASF dual-hosted git repository.
> >>>>>
> >>>>> harbs pushed a commit to branch develop
> >>>>> in repository
> >>>>> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgitbox <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgitbox>
> >>>>> .apache.org <http://apache.org/>%2Frepos%
> 2Fasf%2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
> >>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C63
> >>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlw
> ryG5q3GB9DSTg%3D&r
> >>>>> eserved=0
> >>>>>
> >>>>>
> >>>>> The following commit(s) were added to refs/heads/develop by this
> push:
> >>>>> new 2072541 Fixes #24
> >>>>> 2072541 is described below
> >>>>>
> >>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
> >>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>>
> >>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
> >>>>>
> >>>>> Fixes #24
> >>>>>
> >>>>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
> >>>> and a “changed” event for the same action. It seems like we should
> >>>> dispatch
> >>>> one or the other.
> >>>>> On the one hand, “change” is a standard name, so it’s easily
> >>>> discoverable. On the other hand, “change” is one of the special events
> >>>> which become BrowserEvents when dispatched.
> >>>>> I think the change event should be removed.
> >>>>> ---
> >>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
> >>>> ++++++++++++----
> >>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
> >>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
> >>>>>
> >>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
> >>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> >>>>> index 2316f4a..17a5ef0 100644
> >>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/DateChooserView.as
> >>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/DateChooserView.as
> >>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
> >>>>> private var daysContainer:DateChooserList;
> >>>>>
> >>>>> /**
> >>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
> >>>>> + */
> >>>>> + private function getHost():UIBase
> >>>>> + {
> >>>>> + return _strand as UIBase;
> >>>>> + }
> >>>>> + /**
> >>>>> * The button that causes the previous month to be
> >>>> displayed by the DateChooser.
> >>>>> *
> >>>>> * @langversion 3.0
> >>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
> >>>>> _nextMonthButton.style.flexGrow = 0;
> >>>>> monthButtonsContainer.
> >>>> addElement(_nextMonthButton);
> >>>>>
> >>>>> -
> >>>>> UIBase(_strand).addElement(monthButtonsContainer,
> >>>> false);
> >>>>> + getHost().addElement(monthButtonsContainer,
> >>>> false);
> >>>>>
> >>>>> // DAY NAMES
> >>>>>
> >>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
> >>>>> COMPILE::SWF {
> >>>>> dayNamesContainer.percentWidth = 100;
> >>>>> }
> >>>>> - UIBase(_strand).addElement(dayNamesContainer,
> >>>> false);
> >>>>> + getHost().addElement(dayNamesContainer,
> false);
> >>>>>
> >>>>> // DAYS
> >>>>>
> >>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
> >>>>> COMPILE::SWF {
> >>>>> daysContainer.percentWidth = 100;
> >>>>> }
> >>>>> - UIBase(_strand).addElement(daysContainer,
> >>>>> false);
> >>>>> + getHost().addElement(daysContainer, false);
> >>>>>
> >>>>>
> >>>>> IEventDispatcher(daysContainer).dispatchEvent(
> >>>> new Event("itemsCreated") );
> >>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
> >>>>> var index:Number = model.getIndexForSelectedDate(
> >>>> );
> >>>>> daysContainer.selectedIndex = index;
> >>>>>
> >>>>> - IEventDispatcher(_strand).dispatchEvent(new
> >>>> Event("selectedDateChanged"));
> >>>>> + getHost().dispatchEvent(new
> >>>> Event("selectedDateChanged"));
> >>>>> + getHost().dispatchEvent( new Event("change") );
> >>>>> }
> >>>>>
> >>>>> /**
> >>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/controllers/DateChooserMouseController.as
> >>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/controllers/DateChooserMouseController.as
> >>>>> index d3ef05c..ccf3cbc 100644
> >>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/controllers/DateChooserMouseController.as
> >>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> >>>> royale/html/beads/controllers/DateChooserMouseController.as
> >>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
> >>>>> var list:DateChooserList = event.target as DateChooserList;
> >>>>> var model:DateChooserModel =
> >>>>> _strand.getBeadByType(IBeadModel)
> >>>> as DateChooserModel;
> >>>>> model.selectedDate = list.selectedItem as Date;
> >>>>> - IEventDispatcher(_strand).dispatchEvent( new
> >>>> Event("change") );
> >>>>> }
> >>>>>
> >>>>> /**
> >>>>>
> >>>>> --
> >>>>> To stop receiving notification emails like this one, please contact
> >>>>> ['"commits@royale.apache.org <ma...@royale.apache.org>" <
> commits@royale.apache.org <ma...@royale.apache.org>>'].
> >>>>
> >>>>
> >>>
> >>>
> >>> --
> >>>
> >>> Piotr Zarzycki
> >>>
> >>> mobile: +48 880 859 557
> >>> skype: zarzycki10
> >>>
> >>> LinkedIn:
> >>> https://na01.safelinks.protection.outlook.com/?url=
> http%3A%2F%2Fwww.linke <https://na01.safelinks.
> protection.outlook.com/?url=http%3A%2F%2Fwww.linke>
> >>> din.com <http://din.com/>%2Fpiotrzarzycki&data=02%7C01%7C%
> 7C0ff25865748242cefbda08d520b7784
> >>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636450894728223920&sdata=i
> >>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
> >>>
> >>> <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fpl.link <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fpl.link>
> >>> edin.com <http://edin.com/>%2Fin%2Fpiotr-zarzycki-92a53552&
> data=02%7C01%7C%7C0ff25865748242c
> >>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C6364508947
> >>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5Ftqe
> whVcqGqnbotM%3D&reserved=
> >>> 0>
> >>>
> >>> GitHub:
> >>> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.c <https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.c>
> >>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b7
> 7849%7
> >>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=
> WZtw
> >>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
>
--
Piotr Zarzycki
mobile: +48 880 859 557
skype: zarzycki10
LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
GitHub: https://github.com/piotrzarzycki21
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
I’m not sure why/how, but I checked and the change event on the DateChooser change event is BrowserEvent. Maybe that’s a bug.
Here’s what I get if I listen for both events and trace them to the console:
org.apache.royale.events.Event {type: "selectedDateChanged", target: org.a…e.r…e.h…l.DateChooser, currentTarget: org.a…e.r…e.h…l.DateChooser, propagationStopped_: false, defaultPrevented: false, …}
org.apache.royale.events.BrowserEvent {wrappedEvent: g…g.e…s.BrowserEvent}
The type, target and currentTarget properties are correct in the BrowserEvent and the rest of the properties are undefined. So, I’m not sure that it really matters that it is a BrowserEvent, although the construction of it has to be less efficient.
Either way, do you agree that there should be only one of these two events dispatched?
> On Nov 1, 2017, at 5:38 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> I think the most common event should have a simple name like "change". It
> makes it easier to remember.
>
> In JS, the actual type of most events is BrowserEvent if it was initiated
> by an HTMLElement event. We are sort of taking advantage of the fact that
> JS isn't strongly typed and hopefully nobody really needs to type-check
> the event class.
>
> My 2 cents,
> -Alex
>
> On 10/31/17, 4:30 PM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
>
>> Nope.
>>
>> Copying my response from Github:
>>
>> The only place change is referenced in the Framework is in the metadata
>> of DateChooser:
>> [Event(name="change", type="org.apache.royale.events.Event")]
>>
>> That could easily be changed to:
>> [Event(name="selectedDateChanged", type="org.apache.royale.events.Event")]
>>
>> The current metadata is actually incorrect, because the event type is
>> org.apache.royale.events.BrowserEvent
>>
>> Harbs
>>
>>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com>
>>> wrote:
>>>
>>> You can remove it if it is not fired it up for some other cases in
>>> DateChooser.
>>>
>>> Piotr
>>>
>>> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>>>
>>>> My comment in the commit message needs discussion.
>>>>
>>>> I think the change event should be removed. What do others think?
>>>>
>>>> Harbs
>>>>
>>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>>>>>
>>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>>
>>>>> harbs pushed a commit to branch develop
>>>>> in repository
>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox>
>>>>> .apache.org <http://apache.org/>%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>> 48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63
>>>>> 6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%3D&r
>>>>> eserved=0
>>>>>
>>>>>
>>>>> The following commit(s) were added to refs/heads/develop by this push:
>>>>> new 2072541 Fixes #24
>>>>> 2072541 is described below
>>>>>
>>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>>> Author: Harbs <harbs@in-tools.com <ma...@in-tools.com>>
>>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>>
>>>>> Fixes #24
>>>>>
>>>>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
>>>> and a “changed” event for the same action. It seems like we should
>>>> dispatch
>>>> one or the other.
>>>>> On the one hand, “change” is a standard name, so it’s easily
>>>> discoverable. On the other hand, “change” is one of the special events
>>>> which become BrowserEvents when dispatched.
>>>>> I think the change event should be removed.
>>>>> ---
>>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>>> ++++++++++++----
>>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>>> index 2316f4a..17a5ef0 100644
>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/DateChooserView.as
>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/DateChooserView.as
>>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>>> private var daysContainer:DateChooserList;
>>>>>
>>>>> /**
>>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>>>> + */
>>>>> + private function getHost():UIBase
>>>>> + {
>>>>> + return _strand as UIBase;
>>>>> + }
>>>>> + /**
>>>>> * The button that causes the previous month to be
>>>> displayed by the DateChooser.
>>>>> *
>>>>> * @langversion 3.0
>>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>>> _nextMonthButton.style.flexGrow = 0;
>>>>> monthButtonsContainer.
>>>> addElement(_nextMonthButton);
>>>>>
>>>>> -
>>>>> UIBase(_strand).addElement(monthButtonsContainer,
>>>> false);
>>>>> + getHost().addElement(monthButtonsContainer,
>>>> false);
>>>>>
>>>>> // DAY NAMES
>>>>>
>>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>>> COMPILE::SWF {
>>>>> dayNamesContainer.percentWidth = 100;
>>>>> }
>>>>> - UIBase(_strand).addElement(dayNamesContainer,
>>>> false);
>>>>> + getHost().addElement(dayNamesContainer, false);
>>>>>
>>>>> // DAYS
>>>>>
>>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>>> COMPILE::SWF {
>>>>> daysContainer.percentWidth = 100;
>>>>> }
>>>>> - UIBase(_strand).addElement(daysContainer,
>>>>> false);
>>>>> + getHost().addElement(daysContainer, false);
>>>>>
>>>>>
>>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>>> new Event("itemsCreated") );
>>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>>> var index:Number = model.getIndexForSelectedDate(
>>>> );
>>>>> daysContainer.selectedIndex = index;
>>>>>
>>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>>> Event("selectedDateChanged"));
>>>>> + getHost().dispatchEvent(new
>>>> Event("selectedDateChanged"));
>>>>> + getHost().dispatchEvent( new Event("change") );
>>>>> }
>>>>>
>>>>> /**
>>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>> index d3ef05c..ccf3cbc 100644
>>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>>> var list:DateChooserList = event.target as DateChooserList;
>>>>> var model:DateChooserModel =
>>>>> _strand.getBeadByType(IBeadModel)
>>>> as DateChooserModel;
>>>>> model.selectedDate = list.selectedItem as Date;
>>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>>> Event("change") );
>>>>> }
>>>>>
>>>>> /**
>>>>>
>>>>> --
>>>>> To stop receiving notification emails like this one, please contact
>>>>> ['"commits@royale.apache.org <ma...@royale.apache.org>" <commits@royale.apache.org <ma...@royale.apache.org>>'].
>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> Piotr Zarzycki
>>>
>>> mobile: +48 880 859 557
>>> skype: zarzycki10
>>>
>>> LinkedIn:
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke>
>>> din.com <http://din.com/>%2Fpiotrzarzycki&data=02%7C01%7C%7C0ff25865748242cefbda08d520b7784
>>> 9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=i
>>> yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>>
>>> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link>
>>> edin.com <http://edin.com/>%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C0ff25865748242c
>>> efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364508947
>>> 28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reserved=
>>> 0>
>>>
>>> GitHub:
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c>
>>> om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b77849%7
>>> Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=WZtw
>>> vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
I think the most common event should have a simple name like "change". It
makes it easier to remember.
In JS, the actual type of most events is BrowserEvent if it was initiated
by an HTMLElement event. We are sort of taking advantage of the fact that
JS isn't strongly typed and hopefully nobody really needs to type-check
the event class.
My 2 cents,
-Alex
On 10/31/17, 4:30 PM, "Harbs" <ha...@gmail.com> wrote:
>Nope.
>
>Copying my response from Github:
>
>The only place change is referenced in the Framework is in the metadata
>of DateChooser:
>[Event(name="change", type="org.apache.royale.events.Event")]
>
>That could easily be changed to:
>[Event(name="selectedDateChanged", type="org.apache.royale.events.Event")]
>
>The current metadata is actually incorrect, because the event type is
>org.apache.royale.events.BrowserEvent
>
>Harbs
>
>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com>
>>wrote:
>>
>> You can remove it if it is not fired it up for some other cases in
>> DateChooser.
>>
>> Piotr
>>
>> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>>
>>> My comment in the commit message needs discussion.
>>>
>>> I think the change event should be removed. What do others think?
>>>
>>> Harbs
>>>
>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>>>>
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> harbs pushed a commit to branch develop
>>>> in repository
>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox
>>>>.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7C%7C0ff258657
>>>>48242cefbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63
>>>>6450894728223920&sdata=p24zgDJLDKLtwvp1n8FWLd5kjtBxlwryG5q3GB9DSTg%3D&r
>>>>eserved=0
>>>>
>>>>
>>>> The following commit(s) were added to refs/heads/develop by this push:
>>>> new 2072541 Fixes #24
>>>> 2072541 is described below
>>>>
>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>> Author: Harbs <ha...@in-tools.com>
>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>
>>>> Fixes #24
>>>>
>>>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
>>> and a “changed” event for the same action. It seems like we should
>>>dispatch
>>> one or the other.
>>>> On the one hand, “change” is a standard name, so it’s easily
>>> discoverable. On the other hand, “change” is one of the special events
>>> which become BrowserEvents when dispatched.
>>>> I think the change event should be removed.
>>>> ---
>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>> ++++++++++++----
>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>> index 2316f4a..17a5ef0 100644
>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as
>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as
>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>> private var daysContainer:DateChooserList;
>>>>
>>>> /**
>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>>> + */
>>>> + private function getHost():UIBase
>>>> + {
>>>> + return _strand as UIBase;
>>>> + }
>>>> + /**
>>>> * The button that causes the previous month to be
>>> displayed by the DateChooser.
>>>> *
>>>> * @langversion 3.0
>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>> _nextMonthButton.style.flexGrow = 0;
>>>> monthButtonsContainer.
>>> addElement(_nextMonthButton);
>>>>
>>>> -
>>>>UIBase(_strand).addElement(monthButtonsContainer,
>>> false);
>>>> + getHost().addElement(monthButtonsContainer,
>>> false);
>>>>
>>>> // DAY NAMES
>>>>
>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>> COMPILE::SWF {
>>>> dayNamesContainer.percentWidth = 100;
>>>> }
>>>> - UIBase(_strand).addElement(dayNamesContainer,
>>> false);
>>>> + getHost().addElement(dayNamesContainer, false);
>>>>
>>>> // DAYS
>>>>
>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>> COMPILE::SWF {
>>>> daysContainer.percentWidth = 100;
>>>> }
>>>> - UIBase(_strand).addElement(daysContainer,
>>>>false);
>>>> + getHost().addElement(daysContainer, false);
>>>>
>>>>
>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>> new Event("itemsCreated") );
>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>> var index:Number = model.getIndexForSelectedDate(
>>> );
>>>> daysContainer.selectedIndex = index;
>>>>
>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>> Event("selectedDateChanged"));
>>>> + getHost().dispatchEvent(new
>>> Event("selectedDateChanged"));
>>>> + getHost().dispatchEvent( new Event("change") );
>>>> }
>>>>
>>>> /**
>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> index d3ef05c..ccf3cbc 100644
>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>> var list:DateChooserList = event.target as DateChooserList;
>>>> var model:DateChooserModel =
>>>>_strand.getBeadByType(IBeadModel)
>>> as DateChooserModel;
>>>> model.selectedDate = list.selectedItem as Date;
>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>> Event("change") );
>>>> }
>>>>
>>>> /**
>>>>
>>>> --
>>>> To stop receiving notification emails like this one, please contact
>>>> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>>>
>>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> mobile: +48 880 859 557
>> skype: zarzycki10
>>
>> LinkedIn:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke
>>din.com%2Fpiotrzarzycki&data=02%7C01%7C%7C0ff25865748242cefbda08d520b7784
>>9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=i
>>yKjF6QyvtOVxAZM%2FgiPbBT7jgVPIqjLvaCw9%2BTJbrY%3D&reserved=0
>>
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
>>edin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C0ff25865748242c
>>efbda08d520b77849%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364508947
>>28223920&sdata=4Y%2BsJt5LmIUcCfs31OWhHaJTbP5FtqewhVcqGqnbotM%3D&reserved=
>>0>
>>
>> GitHub:
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C0ff25865748242cefbda08d520b77849%7
>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636450894728223920&sdata=WZtw
>>vlQJnZK4rHRMSEnTG5iTKvR7rZZHa8qHn4fdgk0%3D&reserved=0
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
BTW, code comments on Github do not propagate to the Apache lists.
If there’s a reason to discuss some code in context, code comments are very useful. For general discussions on code commits, responding to commit emails is probably a better way to do it.
Harbs
> On Nov 1, 2017, at 1:30 AM, Harbs <ha...@gmail.com> wrote:
>
> Nope.
>
> Copying my response from Github:
>
> The only place change is referenced in the Framework is in the metadata of DateChooser:
> [Event(name="change", type="org.apache.royale.events.Event")]
>
> That could easily be changed to:
> [Event(name="selectedDateChanged", type="org.apache.royale.events.Event")]
>
> The current metadata is actually incorrect, because the event type is org.apache.royale.events.BrowserEvent
>
> Harbs
>
>> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com> wrote:
>>
>> You can remove it if it is not fired it up for some other cases in
>> DateChooser.
>>
>> Piotr
>>
>> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>>
>>> My comment in the commit message needs discussion.
>>>
>>> I think the change event should be removed. What do others think?
>>>
>>> Harbs
>>>
>>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>>>>
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> harbs pushed a commit to branch develop
>>>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>>>
>>>>
>>>> The following commit(s) were added to refs/heads/develop by this push:
>>>> new 2072541 Fixes #24
>>>> 2072541 is described below
>>>>
>>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>>> Author: Harbs <ha...@in-tools.com>
>>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>>
>>>> Fixes #24
>>>>
>>>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
>>> and a “changed” event for the same action. It seems like we should dispatch
>>> one or the other.
>>>> On the one hand, “change” is a standard name, so it’s easily
>>> discoverable. On the other hand, “change” is one of the special events
>>> which become BrowserEvents when dispatched.
>>>> I think the change event should be removed.
>>>> ---
>>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>>> ++++++++++++----
>>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>>> index 2316f4a..17a5ef0 100644
>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as
>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/DateChooserView.as
>>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>>> private var daysContainer:DateChooserList;
>>>>
>>>> /**
>>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>>> + */
>>>> + private function getHost():UIBase
>>>> + {
>>>> + return _strand as UIBase;
>>>> + }
>>>> + /**
>>>> * The button that causes the previous month to be
>>> displayed by the DateChooser.
>>>> *
>>>> * @langversion 3.0
>>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>>> _nextMonthButton.style.flexGrow = 0;
>>>> monthButtonsContainer.
>>> addElement(_nextMonthButton);
>>>>
>>>> - UIBase(_strand).addElement(monthButtonsContainer,
>>> false);
>>>> + getHost().addElement(monthButtonsContainer,
>>> false);
>>>>
>>>> // DAY NAMES
>>>>
>>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>>> COMPILE::SWF {
>>>> dayNamesContainer.percentWidth = 100;
>>>> }
>>>> - UIBase(_strand).addElement(dayNamesContainer,
>>> false);
>>>> + getHost().addElement(dayNamesContainer, false);
>>>>
>>>> // DAYS
>>>>
>>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>>> COMPILE::SWF {
>>>> daysContainer.percentWidth = 100;
>>>> }
>>>> - UIBase(_strand).addElement(daysContainer, false);
>>>> + getHost().addElement(daysContainer, false);
>>>>
>>>>
>>>> IEventDispatcher(daysContainer).dispatchEvent(
>>> new Event("itemsCreated") );
>>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>>> var index:Number = model.getIndexForSelectedDate(
>>> );
>>>> daysContainer.selectedIndex = index;
>>>>
>>>> - IEventDispatcher(_strand).dispatchEvent(new
>>> Event("selectedDateChanged"));
>>>> + getHost().dispatchEvent(new
>>> Event("selectedDateChanged"));
>>>> + getHost().dispatchEvent( new Event("change") );
>>>> }
>>>>
>>>> /**
>>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> index d3ef05c..ccf3cbc 100644
>>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>>> royale/html/beads/controllers/DateChooserMouseController.as
>>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>>> var list:DateChooserList = event.target as DateChooserList;
>>>> var model:DateChooserModel = _strand.getBeadByType(IBeadModel)
>>> as DateChooserModel;
>>>> model.selectedDate = list.selectedItem as Date;
>>>> - IEventDispatcher(_strand).dispatchEvent( new
>>> Event("change") );
>>>> }
>>>>
>>>> /**
>>>>
>>>> --
>>>> To stop receiving notification emails like this one, please contact
>>>> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>>>
>>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> mobile: +48 880 859 557
>> skype: zarzycki10
>>
>> LinkedIn: http://www.linkedin.com/piotrzarzycki
>> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
>>
>> GitHub: https://github.com/piotrzarzycki21
>
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Alex Harui <ah...@adobe.com.INVALID>.
We could, but it would be slightly more expensive. IMO it is a trade-off
of usability vs code size.
Flex leaned towards usability, but we saw several customers never get off
the launch pad because of code size performance.
My 2 cents,
-Alex
On 11/1/17, 12:20 PM, "Idylog - Nicolas Granon" <ng...@idylog.com> wrote:
>I do not really understand why we do not have a simple "DateChooserEvent"
>with a "change" type, and "previousSelectedDate" and "selectedDate"
>properties.
>
>Nicolas Granon
>
>
>
>
>> -----Message d'origine-----
>> De : Piotr Zarzycki [mailto:piotrzarzycki21@gmail.com]
>> Envoyé : mercredi 1 novembre 2017 00:34
>> À : dev@royale.apache.org
>> Objet : Re: [royale-asjs] branch develop updated: Fixes #24
>>
>> "change" event is being used widely in the framework, but in that case
>> definitely more suites name "selectedDateChanged".
>>
>> Thanks!
>>
>> 2017-11-01 0:30 GMT+01:00 Harbs <ha...@gmail.com>:
>>
>> > Nope.
>> >
>> > Copying my response from Github:
>> >
>> > The only place change is referenced in the Framework is in the
>> > metadata of
>> > DateChooser:
>> > [Event(name="change", type="org.apache.royale.events.Event")]
>> >
>> > That could easily be changed to:
>> > [Event(name="selectedDateChanged",
>> > type="org.apache.royale.events.Event")]
>> >
>> > The current metadata is actually incorrect, because the event type is
>> > org.apache.royale.events.BrowserEvent
>> >
>> > Harbs
>> >
>> > > On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
>> > > <pi...@gmail.com>
>> > wrote:
>> > >
>> > > You can remove it if it is not fired it up for some other cases in
>> > > DateChooser.
>> > >
>> > > Piotr
>> > >
>> > > 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>> > >
>> > >> My comment in the commit message needs discussion.
>> > >>
>> > >> I think the change event should be removed. What do others think?
>> > >>
>> > >> Harbs
>> > >>
>> > >>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>> > >>>
>> > >>> This is an automated email from the ASF dual-hosted git
>> repository.
>> > >>>
>> > >>> harbs pushed a commit to branch develop in repository
>> > >>>
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.a
>>pache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7C%7C6139a5aa32294
>>70b10f608d5215d9f92%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645160
>>8356973575&sdata=Ocj1QqZaV9nhmo2qNlvh6Y6IlCzmo2XcTFzrdqJUBzE%3D&reserved=
>>0
>> > >>>
>> > >>>
>> > >>> The following commit(s) were added to refs/heads/develop by this
>> push:
>> > >>> new 2072541 Fixes #24
>> > >>> 2072541 is described below
>> > >>>
>> > >>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>> > >>> Author: Harbs <ha...@in-tools.com>
>> > >>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>> > >>>
>> > >>> Fixes #24
>> > >>>
>> > >>> I’m not sure why we’re dispatching both a “selctedDateChanged”
>> > >>> event
>> > >> and a “changed” event for the same action. It seems like we should
>> > dispatch
>> > >> one or the other.
>> > >>> On the one hand, “change” is a standard name, so it’s easily
>> > >> discoverable. On the other hand, “change” is one of the special
>> > >> events which become BrowserEvents when dispatched.
>> > >>> I think the change event should be removed.
>> > >>> ---
>> > >>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>> > >> ++++++++++++----
>> > >>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>> > >>> 2 files changed, 12 insertions(+), 5 deletions(-)
>> > >>>
>> > >>> diff --git
>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>> > >> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>> > >>> index 2316f4a..17a5ef0 100644
>> > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/DateChooserView.as
>> > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/DateChooserView.as
>> > >>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>> > >>> private var daysContainer:DateChooserList;
>> > >>>
>> > >>> /**
>> > >>> + * @royaleignorecoercion
>> org.apache.royale.core.UIBase
>> > >>> + */
>> > >>> + private function getHost():UIBase
>> > >>> + {
>> > >>> + return _strand as UIBase;
>> > >>> + }
>> > >>> + /**
>> > >>> * The button that causes the previous month to be
>> > >> displayed by the DateChooser.
>> > >>> *
>> > >>> * @langversion 3.0
>> > >>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>> > >>> _nextMonthButton.style.flexGrow = 0;
>> > >>> monthButtonsContainer.
>> > >> addElement(_nextMonthButton);
>> > >>>
>> > >>> - UIBase(_strand).addElement(
>> > monthButtonsContainer,
>> > >> false);
>> > >>> + getHost().addElement(monthButtonsContainer,
>> > >> false);
>> > >>>
>> > >>> // DAY NAMES
>> > >>>
>> > >>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>> > >>> COMPILE::SWF {
>> > >>> dayNamesContainer.percentWidth =
>> 100;
>> > >>> }
>> > >>> -
>> UIBase(_strand).addElement(dayNamesContainer,
>> > >> false);
>> > >>> + getHost().addElement(dayNamesContainer,
>> > >>> + false);
>> > >>>
>> > >>> // DAYS
>> > >>>
>> > >>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>> > >>> COMPILE::SWF {
>> > >>> daysContainer.percentWidth = 100;
>> > >>> }
>> > >>> - UIBase(_strand).addElement(daysContainer,
>> > false);
>> > >>> + getHost().addElement(daysContainer, false);
>> > >>>
>> > >>>
>> > >>>
>> > >>> IEventDispatcher(daysContainer).dispatchEvent(
>> > >> new Event("itemsCreated") );
>> > >>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>> > >>> var index:Number =
>> > >>> model.getIndexForSelectedDate(
>> > >> );
>> > >>> daysContainer.selectedIndex = index;
>> > >>>
>> > >>> - IEventDispatcher(_strand).dispatchEvent(new
>> > >> Event("selectedDateChanged"));
>> > >>> + getHost().dispatchEvent(new
>> > >> Event("selectedDateChanged"));
>> > >>> + getHost().dispatchEvent( new
>> Event("change")
>> > >>> + );
>> > >>> }
>> > >>>
>> > >>> /**
>> > >>> diff --git
>> a/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/controllers/DateChooserMouseController.as
>> > >> b/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/controllers/DateChooserMouseController.as
>> > >>> index d3ef05c..ccf3cbc 100644
>> > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/controllers/DateChooserMouseController.as
>> > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>> > >> royale/html/beads/controllers/DateChooserMouseController.as
>> > >>> @@ -81,7 +81,6 @@ package
>> org.apache.royale.html.beads.controllers
>> > >>> var list:DateChooserList = event.target as
>> DateChooserList;
>> > >>> var model:DateChooserModel = _strand.getBeadByType(
>> > IBeadModel)
>> > >> as DateChooserModel;
>> > >>> model.selectedDate = list.selectedItem as Date;
>> > >>> - IEventDispatcher(_strand).dispatchEvent( new
>> > >> Event("change") );
>> > >>> }
>> > >>>
>> > >>> /**
>> > >>>
>> > >>> --
>> > >>> To stop receiving notification emails like this one, please
>> > >>> contact ['"commits@royale.apache.org"
>> <co...@royale.apache.org>'].
>> > >>
>> > >>
>> > >
>> > >
>> > > --
>> > >
>> > > Piotr Zarzycki
>> > >
>> > > mobile: +48 880 859 557
>> > > skype: zarzycki10
>> > >
>> > > LinkedIn:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke
>>din.com%2Fpiotrzarzycki&data=02%7C01%7C%7C6139a5aa3229470b10f608d5215d9f9
>>2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451608356973575&sdata=P
>>JJGKZeTv5s5ExoheNTQEcUUMgHe8HJ5%2BLqjTkcKHR0%3D&reserved=0
>> > >
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
>>edin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C6139a5aa3229470
>>b10f608d5215d9f92%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364516083
>>56973575&sdata=wyYEIx%2Bck8VBenBOycxVpacCep9%2BeozFQAvrt8S4jYU%3D&reserve
>>d=0>
>> > >
>> > > GitHub:
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C6139a5aa3229470b10f608d5215d9f92%7
>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451608356973575&sdata=STI%
>>2FSOMxx5Hg2OI5FnA29pgjmUzxla6oU1QZNqetI8c%3D&reserved=0
>> >
>> >
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> mobile: +48 880 859 557
>> skype: zarzycki10
>>
>> LinkedIn:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke
>>din.com%2Fpiotrzarzycki&data=02%7C01%7C%7C6139a5aa3229470b10f608d5215d9f9
>>2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451608356973575&sdata=P
>>JJGKZeTv5s5ExoheNTQEcUUMgHe8HJ5%2BLqjTkcKHR0%3D&reserved=0
>>
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
>>edin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C6139a5aa3229470
>>b10f608d5215d9f92%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364516083
>>56973575&sdata=wyYEIx%2Bck8VBenBOycxVpacCep9%2BeozFQAvrt8S4jYU%3D&reserve
>>d=0>
>>
>> GitHub:
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C6139a5aa3229470b10f608d5215d9f92%7
>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636451608356973575&sdata=STI%
>>2FSOMxx5Hg2OI5FnA29pgjmUzxla6oU1QZNqetI8c%3D&reserved=0
>
RE: [royale-asjs] branch develop updated: Fixes #24
Posted by Idylog - Nicolas Granon <ng...@idylog.com>.
I do not really understand why we do not have a simple "DateChooserEvent" with a "change" type, and "previousSelectedDate" and "selectedDate" properties.
Nicolas Granon
> -----Message d'origine-----
> De : Piotr Zarzycki [mailto:piotrzarzycki21@gmail.com]
> Envoyé : mercredi 1 novembre 2017 00:34
> À : dev@royale.apache.org
> Objet : Re: [royale-asjs] branch develop updated: Fixes #24
>
> "change" event is being used widely in the framework, but in that case
> definitely more suites name "selectedDateChanged".
>
> Thanks!
>
> 2017-11-01 0:30 GMT+01:00 Harbs <ha...@gmail.com>:
>
> > Nope.
> >
> > Copying my response from Github:
> >
> > The only place change is referenced in the Framework is in the
> > metadata of
> > DateChooser:
> > [Event(name="change", type="org.apache.royale.events.Event")]
> >
> > That could easily be changed to:
> > [Event(name="selectedDateChanged",
> > type="org.apache.royale.events.Event")]
> >
> > The current metadata is actually incorrect, because the event type is
> > org.apache.royale.events.BrowserEvent
> >
> > Harbs
> >
> > > On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki
> > > <pi...@gmail.com>
> > wrote:
> > >
> > > You can remove it if it is not fired it up for some other cases in
> > > DateChooser.
> > >
> > > Piotr
> > >
> > > 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
> > >
> > >> My comment in the commit message needs discussion.
> > >>
> > >> I think the change event should be removed. What do others think?
> > >>
> > >> Harbs
> > >>
> > >>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
> > >>>
> > >>> This is an automated email from the ASF dual-hosted git
> repository.
> > >>>
> > >>> harbs pushed a commit to branch develop in repository
> > >>> https://gitbox.apache.org/repos/asf/royale-asjs.git
> > >>>
> > >>>
> > >>> The following commit(s) were added to refs/heads/develop by this
> push:
> > >>> new 2072541 Fixes #24
> > >>> 2072541 is described below
> > >>>
> > >>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
> > >>> Author: Harbs <ha...@in-tools.com>
> > >>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
> > >>>
> > >>> Fixes #24
> > >>>
> > >>> I’m not sure why we’re dispatching both a “selctedDateChanged”
> > >>> event
> > >> and a “changed” event for the same action. It seems like we should
> > dispatch
> > >> one or the other.
> > >>> On the one hand, “change” is a standard name, so it’s easily
> > >> discoverable. On the other hand, “change” is one of the special
> > >> events which become BrowserEvents when dispatched.
> > >>> I think the change event should be removed.
> > >>> ---
> > >>> .../org/apache/royale/html/beads/DateChooserView.as | 16
> > >> ++++++++++++----
> > >>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
> > >>> 2 files changed, 12 insertions(+), 5 deletions(-)
> > >>>
> > >>> diff --git
> a/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
> > >> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> > >>> index 2316f4a..17a5ef0 100644
> > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/DateChooserView.as
> > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/DateChooserView.as
> > >>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
> > >>> private var daysContainer:DateChooserList;
> > >>>
> > >>> /**
> > >>> + * @royaleignorecoercion
> org.apache.royale.core.UIBase
> > >>> + */
> > >>> + private function getHost():UIBase
> > >>> + {
> > >>> + return _strand as UIBase;
> > >>> + }
> > >>> + /**
> > >>> * The button that causes the previous month to be
> > >> displayed by the DateChooser.
> > >>> *
> > >>> * @langversion 3.0
> > >>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
> > >>> _nextMonthButton.style.flexGrow = 0;
> > >>> monthButtonsContainer.
> > >> addElement(_nextMonthButton);
> > >>>
> > >>> - UIBase(_strand).addElement(
> > monthButtonsContainer,
> > >> false);
> > >>> + getHost().addElement(monthButtonsContainer,
> > >> false);
> > >>>
> > >>> // DAY NAMES
> > >>>
> > >>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
> > >>> COMPILE::SWF {
> > >>> dayNamesContainer.percentWidth =
> 100;
> > >>> }
> > >>> -
> UIBase(_strand).addElement(dayNamesContainer,
> > >> false);
> > >>> + getHost().addElement(dayNamesContainer,
> > >>> + false);
> > >>>
> > >>> // DAYS
> > >>>
> > >>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
> > >>> COMPILE::SWF {
> > >>> daysContainer.percentWidth = 100;
> > >>> }
> > >>> - UIBase(_strand).addElement(daysContainer,
> > false);
> > >>> + getHost().addElement(daysContainer, false);
> > >>>
> > >>>
> > >>>
> > >>> IEventDispatcher(daysContainer).dispatchEvent(
> > >> new Event("itemsCreated") );
> > >>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
> > >>> var index:Number =
> > >>> model.getIndexForSelectedDate(
> > >> );
> > >>> daysContainer.selectedIndex = index;
> > >>>
> > >>> - IEventDispatcher(_strand).dispatchEvent(new
> > >> Event("selectedDateChanged"));
> > >>> + getHost().dispatchEvent(new
> > >> Event("selectedDateChanged"));
> > >>> + getHost().dispatchEvent( new
> Event("change")
> > >>> + );
> > >>> }
> > >>>
> > >>> /**
> > >>> diff --git
> a/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/controllers/DateChooserMouseController.as
> > >> b/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/controllers/DateChooserMouseController.as
> > >>> index d3ef05c..ccf3cbc 100644
> > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/controllers/DateChooserMouseController.as
> > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> > >> royale/html/beads/controllers/DateChooserMouseController.as
> > >>> @@ -81,7 +81,6 @@ package
> org.apache.royale.html.beads.controllers
> > >>> var list:DateChooserList = event.target as
> DateChooserList;
> > >>> var model:DateChooserModel = _strand.getBeadByType(
> > IBeadModel)
> > >> as DateChooserModel;
> > >>> model.selectedDate = list.selectedItem as Date;
> > >>> - IEventDispatcher(_strand).dispatchEvent( new
> > >> Event("change") );
> > >>> }
> > >>>
> > >>> /**
> > >>>
> > >>> --
> > >>> To stop receiving notification emails like this one, please
> > >>> contact ['"commits@royale.apache.org"
> <co...@royale.apache.org>'].
> > >>
> > >>
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > mobile: +48 880 859 557
> > > skype: zarzycki10
> > >
> > > LinkedIn: http://www.linkedin.com/piotrzarzycki
> > > <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
> > >
> > > GitHub: https://github.com/piotrzarzycki21
> >
> >
>
>
> --
>
> Piotr Zarzycki
>
> mobile: +48 880 859 557
> skype: zarzycki10
>
> LinkedIn: http://www.linkedin.com/piotrzarzycki
> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
>
> GitHub: https://github.com/piotrzarzycki21
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Piotr Zarzycki <pi...@gmail.com>.
"change" event is being used widely in the framework, but in that case
definitely more suites name "selectedDateChanged".
Thanks!
2017-11-01 0:30 GMT+01:00 Harbs <ha...@gmail.com>:
> Nope.
>
> Copying my response from Github:
>
> The only place change is referenced in the Framework is in the metadata of
> DateChooser:
> [Event(name="change", type="org.apache.royale.events.Event")]
>
> That could easily be changed to:
> [Event(name="selectedDateChanged", type="org.apache.royale.events.Event")]
>
> The current metadata is actually incorrect, because the event type is
> org.apache.royale.events.BrowserEvent
>
> Harbs
>
> > On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com>
> wrote:
> >
> > You can remove it if it is not fired it up for some other cases in
> > DateChooser.
> >
> > Piotr
> >
> > 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
> >
> >> My comment in the commit message needs discussion.
> >>
> >> I think the change event should be removed. What do others think?
> >>
> >> Harbs
> >>
> >>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
> >>>
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> harbs pushed a commit to branch develop
> >>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >>>
> >>>
> >>> The following commit(s) were added to refs/heads/develop by this push:
> >>> new 2072541 Fixes #24
> >>> 2072541 is described below
> >>>
> >>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
> >>> Author: Harbs <ha...@in-tools.com>
> >>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
> >>>
> >>> Fixes #24
> >>>
> >>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
> >> and a “changed” event for the same action. It seems like we should
> dispatch
> >> one or the other.
> >>> On the one hand, “change” is a standard name, so it’s easily
> >> discoverable. On the other hand, “change” is one of the special events
> >> which become BrowserEvents when dispatched.
> >>> I think the change event should be removed.
> >>> ---
> >>> .../org/apache/royale/html/beads/DateChooserView.as | 16
> >> ++++++++++++----
> >>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
> >>> 2 files changed, 12 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
> >> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> >>> index 2316f4a..17a5ef0 100644
> >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/DateChooserView.as
> >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/DateChooserView.as
> >>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
> >>> private var daysContainer:DateChooserList;
> >>>
> >>> /**
> >>> + * @royaleignorecoercion org.apache.royale.core.UIBase
> >>> + */
> >>> + private function getHost():UIBase
> >>> + {
> >>> + return _strand as UIBase;
> >>> + }
> >>> + /**
> >>> * The button that causes the previous month to be
> >> displayed by the DateChooser.
> >>> *
> >>> * @langversion 3.0
> >>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
> >>> _nextMonthButton.style.flexGrow = 0;
> >>> monthButtonsContainer.
> >> addElement(_nextMonthButton);
> >>>
> >>> - UIBase(_strand).addElement(
> monthButtonsContainer,
> >> false);
> >>> + getHost().addElement(monthButtonsContainer,
> >> false);
> >>>
> >>> // DAY NAMES
> >>>
> >>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
> >>> COMPILE::SWF {
> >>> dayNamesContainer.percentWidth = 100;
> >>> }
> >>> - UIBase(_strand).addElement(dayNamesContainer,
> >> false);
> >>> + getHost().addElement(dayNamesContainer, false);
> >>>
> >>> // DAYS
> >>>
> >>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
> >>> COMPILE::SWF {
> >>> daysContainer.percentWidth = 100;
> >>> }
> >>> - UIBase(_strand).addElement(daysContainer,
> false);
> >>> + getHost().addElement(daysContainer, false);
> >>>
> >>>
> >>> IEventDispatcher(daysContainer).dispatchEvent(
> >> new Event("itemsCreated") );
> >>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
> >>> var index:Number = model.getIndexForSelectedDate(
> >> );
> >>> daysContainer.selectedIndex = index;
> >>>
> >>> - IEventDispatcher(_strand).dispatchEvent(new
> >> Event("selectedDateChanged"));
> >>> + getHost().dispatchEvent(new
> >> Event("selectedDateChanged"));
> >>> + getHost().dispatchEvent( new Event("change") );
> >>> }
> >>>
> >>> /**
> >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/controllers/DateChooserMouseController.as
> >> b/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/controllers/DateChooserMouseController.as
> >>> index d3ef05c..ccf3cbc 100644
> >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/controllers/DateChooserMouseController.as
> >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> >> royale/html/beads/controllers/DateChooserMouseController.as
> >>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
> >>> var list:DateChooserList = event.target as DateChooserList;
> >>> var model:DateChooserModel = _strand.getBeadByType(
> IBeadModel)
> >> as DateChooserModel;
> >>> model.selectedDate = list.selectedItem as Date;
> >>> - IEventDispatcher(_strand).dispatchEvent( new
> >> Event("change") );
> >>> }
> >>>
> >>> /**
> >>>
> >>> --
> >>> To stop receiving notification emails like this one, please contact
> >>> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
> >>
> >>
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > mobile: +48 880 859 557
> > skype: zarzycki10
> >
> > LinkedIn: http://www.linkedin.com/piotrzarzycki
> > <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
> >
> > GitHub: https://github.com/piotrzarzycki21
>
>
--
Piotr Zarzycki
mobile: +48 880 859 557
skype: zarzycki10
LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
GitHub: https://github.com/piotrzarzycki21
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Harbs <ha...@gmail.com>.
Nope.
Copying my response from Github:
The only place change is referenced in the Framework is in the metadata of DateChooser:
[Event(name="change", type="org.apache.royale.events.Event")]
That could easily be changed to:
[Event(name="selectedDateChanged", type="org.apache.royale.events.Event")]
The current metadata is actually incorrect, because the event type is org.apache.royale.events.BrowserEvent
Harbs
> On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <pi...@gmail.com> wrote:
>
> You can remove it if it is not fired it up for some other cases in
> DateChooser.
>
> Piotr
>
> 2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
>
>> My comment in the commit message needs discussion.
>>
>> I think the change event should be removed. What do others think?
>>
>> Harbs
>>
>>> On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
>>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> harbs pushed a commit to branch develop
>>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/develop by this push:
>>> new 2072541 Fixes #24
>>> 2072541 is described below
>>>
>>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
>>> Author: Harbs <ha...@in-tools.com>
>>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200
>>>
>>> Fixes #24
>>>
>>> I’m not sure why we’re dispatching both a “selctedDateChanged” event
>> and a “changed” event for the same action. It seems like we should dispatch
>> one or the other.
>>> On the one hand, “change” is a standard name, so it’s easily
>> discoverable. On the other hand, “change” is one of the special events
>> which become BrowserEvents when dispatched.
>>> I think the change event should be removed.
>>> ---
>>> .../org/apache/royale/html/beads/DateChooserView.as | 16
>> ++++++++++++----
>>> .../html/beads/controllers/DateChooserMouseController.as | 1 -
>>> 2 files changed, 12 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
>> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
>>> index 2316f4a..17a5ef0 100644
>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/DateChooserView.as
>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/DateChooserView.as
>>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
>>> private var daysContainer:DateChooserList;
>>>
>>> /**
>>> + * @royaleignorecoercion org.apache.royale.core.UIBase
>>> + */
>>> + private function getHost():UIBase
>>> + {
>>> + return _strand as UIBase;
>>> + }
>>> + /**
>>> * The button that causes the previous month to be
>> displayed by the DateChooser.
>>> *
>>> * @langversion 3.0
>>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
>>> _nextMonthButton.style.flexGrow = 0;
>>> monthButtonsContainer.
>> addElement(_nextMonthButton);
>>>
>>> - UIBase(_strand).addElement(monthButtonsContainer,
>> false);
>>> + getHost().addElement(monthButtonsContainer,
>> false);
>>>
>>> // DAY NAMES
>>>
>>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
>>> COMPILE::SWF {
>>> dayNamesContainer.percentWidth = 100;
>>> }
>>> - UIBase(_strand).addElement(dayNamesContainer,
>> false);
>>> + getHost().addElement(dayNamesContainer, false);
>>>
>>> // DAYS
>>>
>>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
>>> COMPILE::SWF {
>>> daysContainer.percentWidth = 100;
>>> }
>>> - UIBase(_strand).addElement(daysContainer, false);
>>> + getHost().addElement(daysContainer, false);
>>>
>>>
>>> IEventDispatcher(daysContainer).dispatchEvent(
>> new Event("itemsCreated") );
>>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
>>> var index:Number = model.getIndexForSelectedDate(
>> );
>>> daysContainer.selectedIndex = index;
>>>
>>> - IEventDispatcher(_strand).dispatchEvent(new
>> Event("selectedDateChanged"));
>>> + getHost().dispatchEvent(new
>> Event("selectedDateChanged"));
>>> + getHost().dispatchEvent( new Event("change") );
>>> }
>>>
>>> /**
>>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/controllers/DateChooserMouseController.as
>> b/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/controllers/DateChooserMouseController.as
>>> index d3ef05c..ccf3cbc 100644
>>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/controllers/DateChooserMouseController.as
>>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
>> royale/html/beads/controllers/DateChooserMouseController.as
>>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
>>> var list:DateChooserList = event.target as DateChooserList;
>>> var model:DateChooserModel = _strand.getBeadByType(IBeadModel)
>> as DateChooserModel;
>>> model.selectedDate = list.selectedItem as Date;
>>> - IEventDispatcher(_strand).dispatchEvent( new
>> Event("change") );
>>> }
>>>
>>> /**
>>>
>>> --
>>> To stop receiving notification emails like this one, please contact
>>> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>>
>>
>
>
> --
>
> Piotr Zarzycki
>
> mobile: +48 880 859 557
> skype: zarzycki10
>
> LinkedIn: http://www.linkedin.com/piotrzarzycki
> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
>
> GitHub: https://github.com/piotrzarzycki21
Re: [royale-asjs] branch develop updated: Fixes #24
Posted by Piotr Zarzycki <pi...@gmail.com>.
You can remove it if it is not fired it up for some other cases in
DateChooser.
Piotr
2017-11-01 0:23 GMT+01:00 Harbs <ha...@gmail.com>:
> My comment in the commit message needs discussion.
>
> I think the change event should be removed. What do others think?
>
> Harbs
>
> > On Nov 1, 2017, at 1:14 AM, harbs@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > harbs pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> > new 2072541 Fixes #24
> > 2072541 is described below
> >
> > commit 2072541f1f9da5ed1780d497a6ec5fab52674b91
> > Author: Harbs <ha...@in-tools.com>
> > AuthorDate: Wed Nov 1 01:14:29 2017 +0200
> >
> > Fixes #24
> >
> > I’m not sure why we’re dispatching both a “selctedDateChanged” event
> and a “changed” event for the same action. It seems like we should dispatch
> one or the other.
> > On the one hand, “change” is a standard name, so it’s easily
> discoverable. On the other hand, “change” is one of the special events
> which become BrowserEvents when dispatched.
> > I think the change event should be removed.
> > ---
> > .../org/apache/royale/html/beads/DateChooserView.as | 16
> ++++++++++++----
> > .../html/beads/controllers/DateChooserMouseController.as | 1 -
> > 2 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/
> src/main/royale/org/apache/royale/html/beads/DateChooserView.as
> > index 2316f4a..17a5ef0 100644
> > --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/DateChooserView.as
> > +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/DateChooserView.as
> > @@ -86,6 +86,13 @@ package org.apache.royale.html.beads
> > private var daysContainer:DateChooserList;
> >
> > /**
> > + * @royaleignorecoercion org.apache.royale.core.UIBase
> > + */
> > + private function getHost():UIBase
> > + {
> > + return _strand as UIBase;
> > + }
> > + /**
> > * The button that causes the previous month to be
> displayed by the DateChooser.
> > *
> > * @langversion 3.0
> > @@ -171,7 +178,7 @@ package org.apache.royale.html.beads
> > _nextMonthButton.style.flexGrow = 0;
> > monthButtonsContainer.
> addElement(_nextMonthButton);
> >
> > - UIBase(_strand).addElement(monthButtonsContainer,
> false);
> > + getHost().addElement(monthButtonsContainer,
> false);
> >
> > // DAY NAMES
> >
> > @@ -188,7 +195,7 @@ package org.apache.royale.html.beads
> > COMPILE::SWF {
> > dayNamesContainer.percentWidth = 100;
> > }
> > - UIBase(_strand).addElement(dayNamesContainer,
> false);
> > + getHost().addElement(dayNamesContainer, false);
> >
> > // DAYS
> >
> > @@ -203,7 +210,7 @@ package org.apache.royale.html.beads
> > COMPILE::SWF {
> > daysContainer.percentWidth = 100;
> > }
> > - UIBase(_strand).addElement(daysContainer, false);
> > + getHost().addElement(daysContainer, false);
> >
> >
> > IEventDispatcher(daysContainer).dispatchEvent(
> new Event("itemsCreated") );
> > @@ -233,7 +240,8 @@ package org.apache.royale.html.beads
> > var index:Number = model.getIndexForSelectedDate(
> );
> > daysContainer.selectedIndex = index;
> >
> > - IEventDispatcher(_strand).dispatchEvent(new
> Event("selectedDateChanged"));
> > + getHost().dispatchEvent(new
> Event("selectedDateChanged"));
> > + getHost().dispatchEvent( new Event("change") );
> > }
> >
> > /**
> > diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/controllers/DateChooserMouseController.as
> b/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/controllers/DateChooserMouseController.as
> > index d3ef05c..ccf3cbc 100644
> > --- a/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/controllers/DateChooserMouseController.as
> > +++ b/frameworks/projects/Basic/src/main/royale/org/apache/
> royale/html/beads/controllers/DateChooserMouseController.as
> > @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers
> > var list:DateChooserList = event.target as DateChooserList;
> > var model:DateChooserModel = _strand.getBeadByType(IBeadModel)
> as DateChooserModel;
> > model.selectedDate = list.selectedItem as Date;
> > - IEventDispatcher(_strand).dispatchEvent( new
> Event("change") );
> > }
> >
> > /**
> >
> > --
> > To stop receiving notification emails like this one, please contact
> > ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>
>
--
Piotr Zarzycki
mobile: +48 880 859 557
skype: zarzycki10
LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
GitHub: https://github.com/piotrzarzycki21