You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/24 09:54:37 UTC
[GitHub] [dolphinscheduler] liqingwang opened a new pull request, #11629: [doc] Correct E2E Doc
liqingwang opened a new pull request, #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629
Fix E2E doc mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on pull request #11629: [doc] Correct E2E Doc
Posted by GitBox <gi...@apache.org>.
liqingwang commented on PR #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629#issuecomment-1225496838
PTAL @EricGao888 @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on pull request #11629: [doc] Correct E2E Doc, fix WorkerGroupPage typo
Posted by GitBox <gi...@apache.org>.
liqingwang commented on PR #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629#issuecomment-1226712121
PTAL @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11629: [doc] Correct E2E Doc
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629#discussion_r953598264
##########
docs/docs/en/contribute/e2e-test.md:
##########
@@ -74,7 +74,7 @@ During the test process, we only test the elements we need to focus on, not all
In addition, during the testing process, the elements are not manipulated directly. The general choice is to package the corresponding methods to achieve the effect of reuse. For example, if you want to log in, you input your username and password through the `public TenantPage login()` method to manipulate the elements you pass in to achieve the effect of logging in. That is, when the user finishes logging in, he or she jumps to the Security Centre (which goes to the Tenant Management page by default).
-The goToTab method is provided in SecurityPage to test the corresponding sidebar jumps, which include TenantPage, UserPage and WorkerGroupPge and QueuePage. These pages are implemented in the same way, to test that the form's input, add and delete buttons return the corresponding pages.
+The goToTab method is provided in SecurityPage to test the corresponding sidebar jumps, which include TenantPage, UserPage and WorkerGroupPage and QueuePage. These pages are implemented in the same way, to test that the form's input, add and delete buttons return the corresponding pages.
Review Comment:
This sentence looks a little wired. Would you like to rewrite it? Use active voice and fix some grammatical errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on a diff in pull request #11629: [doc] Correct E2E Doc
Posted by GitBox <gi...@apache.org>.
liqingwang commented on code in PR #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629#discussion_r953599952
##########
docs/docs/en/contribute/e2e-test.md:
##########
@@ -74,7 +74,7 @@ During the test process, we only test the elements we need to focus on, not all
In addition, during the testing process, the elements are not manipulated directly. The general choice is to package the corresponding methods to achieve the effect of reuse. For example, if you want to log in, you input your username and password through the `public TenantPage login()` method to manipulate the elements you pass in to achieve the effect of logging in. That is, when the user finishes logging in, he or she jumps to the Security Centre (which goes to the Tenant Management page by default).
-The goToTab method is provided in SecurityPage to test the corresponding sidebar jumps, which include TenantPage, UserPage and WorkerGroupPge and QueuePage. These pages are implemented in the same way, to test that the form's input, add and delete buttons return the corresponding pages.
+The goToTab method is provided in SecurityPage to test the corresponding sidebar jumps, which include TenantPage, UserPage and WorkerGroupPage and QueuePage. These pages are implemented in the same way, to test that the form's input, add and delete buttons return the corresponding pages.
Review Comment:
Sure, I will rewrite it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #11629: [doc] Correct E2E Doc, fix WorkerGroupPage typo
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #11629:
URL: https://github.com/apache/dolphinscheduler/pull/11629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org