You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2019/08/04 18:42:00 UTC
[jira] [Comment Edited] (MJAVADOC-619) Maven Javadoc bottom claims
copyright for future years
[ https://issues.apache.org/jira/browse/MJAVADOC-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899669#comment-16899669 ]
Michael Osipov edited comment on MJAVADOC-619 at 8/4/19 6:41 PM:
-----------------------------------------------------------------
I think this approach has flaws:
* Consider you have updated deps only and release, but you do update the year even though you haven't touched the code a bit.
* How do you get realiabley the POM's {{mtime}}? From your SCM? What is a tarball is expanded and the current timestamp is set? So the build won't be reproducible.
Also read: https://git.wiki.kernel.org/index.php/GitFaq#Why_isn.27t_Git_preserving_modification_time_on_files.3F
was (Author: michael-o):
I think this approach has flaws:
* Consider you have updated deps only and release, but you do update the year even though you haven't touched the code a bit.
* How do you get realiabley the POM's {{mtime}}? From your SCM? What is a tarball is expanded and the current timestamp is set? So the build wonÄt be reproducible.
Also read: https://git.wiki.kernel.org/index.php/GitFaq#Why_isn.27t_Git_preserving_modification_time_on_files.3F
> Maven Javadoc bottom claims copyright for future years
> ------------------------------------------------------
>
> Key: MJAVADOC-619
> URL: https://issues.apache.org/jira/browse/MJAVADOC-619
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 3.1.1
> Reporter: Bernhard M. Wiedemann
> Priority: Major
>
> Originally filed at https://issues.apache.org/jira/browse/MCOMPILER-380
> [https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#bottom]
> includes {{{currentYear}}}
> [https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/timestamp/copyright] explains why this is bad (not only for reproducible builds)
>
> Debian worked already around this with
> [https://sources.debian.org/src/maven-javadoc-plugin/2.10.4-1/debian/patches/reproducible-footer.patch/]
> but I think, this warrants a more general patch.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)