You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/10/29 09:39:39 UTC
[GitHub] tajo pull request: TAJO-1271: Improve memory usage in HashShuffleF...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/837
TAJO-1271: Improve memory usage in HashShuffleFileWriteExec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1271_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
----
commit 00fe7c284b75bc69755a922144f3c9e784b887cb
Author: Jinho Kim <jh...@apache.org>
Date: 2015-10-29T05:58:39Z
TAJO-1271: Improve memory usage in HashShuffleFileWriteExec
commit 8768d2f85e25ce0f5a12bae0a2c557d15ab59c41
Author: Jinho Kim <jh...@apache.org>
Date: 2015-10-29T06:10:04Z
cleanup
commit 2dce0f44868f62df2970526d5608ef6b1b4f711e
Author: Jinho Kim <jh...@apache.org>
Date: 2015-10-29T08:02:47Z
fix buffer overflow
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1271: Improve memory usage of Hash-shuffle
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/837#issuecomment-155363149
I add `HASH_SHUFFLE_BUFFER_SIZE`. if total buffer capacity are required more than `HASH_SHUFFLE_BUFFER_SIZE * BUFFER_THRESHOLD_FACTOR`, all partitions are flushed and the buffers are released
This PR is ready to review.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1271: Improve memory usage of Hash-shuffle
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1271: Improve memory usage of Hash-shuffle
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/837#issuecomment-157243986
+1 this patch looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1271: Improve memory usage of Hash-shuffle
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/837#issuecomment-156289938
Thanks for your work. I'll review tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---