[GitHub] [guacamole-server] mike-jumper commented on issue #235: GUACAMOLE-861: Drive redirectrion - fix WINDOWS_TIME calculation

[GitBox <gi...@apache.org>]

mike-jumper commented on issue #235: GUACAMOLE-861: Drive redirectrion - fix WINDOWS_TIME calculation
URL: https://github.com/apache/guacamole-server/pull/235#issuecomment-518349892
 
 
   > ... your commit message should say "GUACAMOLE-861: Fix WINDOWS_TIME calculation".
   
   Adding to this:
   
   Please also consider whether there might be more information that can be reasonably provided than "Fix WINDOWS_TIME calculation". If you can think of a better message which captures the nature of the change beyond that it's a fix to a time calculation, that would be good.
   
   I've been finding myself citing this blog post lately as an example of what to aim for and what to avoid. The git logs are critical, and the blog makes good points:
   
   https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/
   
   > ... so we won't have more iterations?
   
   Hang in there, @gabriel-sztejnworcel. The code will get there. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services