You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/25 11:40:28 UTC

[GitHub] [nifi] pvillard31 commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

pvillard31 commented on a change in pull request #4931:
URL: https://github.com/apache/nifi/pull/4931#discussion_r601403451



##########
File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java
##########
@@ -143,6 +150,16 @@
             .addValidator(Validator.VALID)
             .build();
 
+    static final PropertyDescriptor VALUE_INCLUDED_IN_RESULT = new PropertyDescriptor.Builder()
+            .displayName("Value Included in Result")
+            .name("accumulo-value-inclusive")
+            .description("Beside keys and their values, accumulo value field will also be included in the result as UTF-8 Encoded String.")
+            .required(false)
+            .defaultValue("True")

Review comment:
       ```suggestion
               .defaultValue("true")
   ```

##########
File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java
##########
@@ -143,6 +150,16 @@
             .addValidator(Validator.VALID)
             .build();
 
+    static final PropertyDescriptor VALUE_INCLUDED_IN_RESULT = new PropertyDescriptor.Builder()
+            .displayName("Value Included in Result")
+            .name("accumulo-value-inclusive")
+            .description("Beside keys and their values, accumulo value field will also be included in the result as UTF-8 Encoded String.")
+            .required(false)
+            .defaultValue("True")
+            .allowableValues("True", "False")

Review comment:
       ```suggestion
               .allowableValues("true", "false")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org