You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "I3eka (via GitHub)" <gi...@apache.org> on 2026/08/13 15:58:26 UTC
[PR] fix(mcp): accept common chart input variants [superset]
I3eka opened a new pull request, #43120:
URL: https://github.com/apache/superset/pull/43120
# fix(mcp): accept common chart input variants
### SUMMARY
Accept `column` as a column-reference alias and support `IS NULL`/`IS NOT NULL` filters without comparator values while preserving value validation for other operators.
Base: `apache/superset:master` at `e2bb33b1da17c16a51e54d84bcf496516d67a713`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; backend behavior only.
### TESTING INSTRUCTIONS
`pytest -q tests/unit_tests/mcp_service/chart/test_chart_utils.py tests/unit_tests/mcp_service/chart/tool/test_generate_chart.py`
Result: 182 passed.
The changed files also pass the repository pre-commit hooks.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): accept common chart input variants [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43120:
URL: https://github.com/apache/superset/pull/43120#issuecomment-5282956984
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): accept common chart input variants [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #43120:
URL: https://github.com/apache/superset/pull/43120#discussion_r3776987632
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -1312,6 +1312,8 @@ def map_filter_operator(op: str) -> str:
"NOT LIKE": "NOT LIKE",
"IN": "IN",
"NOT IN": "NOT IN",
+ "IS NULL": "IS NULL",
+ "IS NOT NULL": "IS NOT NULL",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for new operators</b></div>
<div id="fix">
Added operators are correct and match `FilterOperator.IS_NULL`/`IS_NOT_NULL` from `superset/utils/core.py`, but there's no test coverage for them. BITO.md rule [11730] requires comprehensive unit tests for new features.
</div>
</div>
<small><i>Code Review Run #4370b2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): accept common chart input variants [superset]
Posted by "I3eka (via GitHub)" <gi...@apache.org>.
I3eka closed pull request #43120: fix(mcp): accept common chart input variants
URL: https://github.com/apache/superset/pull/43120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org