You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by Scott Gray <le...@gmail.com> on 2007/06/14 11:18:31 UTC

Re: Promotions and Sales Tax

Hi Amit

See here, https://issues.apache.org/jira/browse/OFBIZ-225

In my opinion tax calculations should always take promotions into account.

Regards
Scott

On 14/06/07, Amit Shinde <am...@amicontech.com> wrote:
>
>  Hey Everyone,
>                        Currently, we have an ability to exclude shipping
> from calculation of sales tax. This is easily done by setting a
> 'taxShipping' flag in the TaxAuthorityRateProduct table. There is no way to
> include/exclude promotion adjustments in calculation of sales tax.
>                        I dont know if this is usual or no, but what the
> need is that tax should be calculated on price after including adjustments
> like coupons etc.
>                        I was going to implement this and before doing so,
> was wondering if anyone has come across this. Any inputs would be great.
>
>
> Thanks in advance,
>
> Amit Shinde
> Amicon Technologies Pvt. Ltd., Mumbai, India.
>

Re: Promotions and Sales Tax

Posted by Scott Gray <le...@gmail.com>.
Hi Amit

It would be great if you could attach a patch to OFBIZ-225 once you are
done, it would be good to get this fixed

Thanks
Scott

On 14/06/07, Amit Shinde <am...@amicontech.com> wrote:
>
>  Thanks Scott. Currently, the tax calculations are not taking promotions
> into account. I am implementing a fix for this by adding a flag
> 'taxPromotions' and then send one more 'calcTax' service param as
> 'orderPromotionsAmount' which will be a sum of all the promotion adjustments
> and will be of negative value. I suppose, the calculated tax will be
> negative too and hence balance the total sales tax.
>
> - Amit
>
>
> Scott Gray wrote:
>
> Hi Amit
>
> See here, https://issues.apache.org/jira/browse/OFBIZ-225
>
> In my opinion tax calculations should always take promotions into account.
>
>
> Regards
> Scott
>
> On 14/06/07, Amit Shinde <am...@amicontech.com> <am...@amicontech.com>wrote:
>
>
>  Hey Everyone,
>                        Currently, we have an ability to exclude shipping
> from calculation of sales tax. This is easily done by setting a
> 'taxShipping' flag in the TaxAuthorityRateProduct table. There is no way
> to
> include/exclude promotion adjustments in calculation of sales tax.
>                        I dont know if this is usual or no, but what the
> need is that tax should be calculated on price after including adjustments
>
> like coupons etc.
>                        I was going to implement this and before doing so,
> was wondering if anyone has come across this. Any inputs would be great.
>
>
> Thanks in advance,
>
> Amit Shinde
> Amicon Technologies Pvt. Ltd., Mumbai, India.
>
>
>