You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/13 21:24:03 UTC
[PR] chore: remove Reddit Search operator and praw dep [texera]
Yicong-Huang opened a new pull request, #5688:
URL: https://github.com/apache/texera/pull/5688
### What changes were proposed in this PR?
Removes the `Reddit Search` source operator and the unmaintained `praw==7.6.1` / `prawcore==2.4.0` Python deps. Reddit Search was a thin PRAW wrapper that emitted Python code calling `praw.Reddit(...)` from inside `RedditSearchSourceOpDesc`; deleting it lets us drop a third-party API surface and two transitive license entries.
| Layer | File | Action |
| --- | --- | --- |
| Operator descriptor | `common/workflow-operator/.../source/apis/reddit/RedditSearchSourceOpDesc.scala` | delete |
| Operator enum | `common/workflow-operator/.../source/apis/reddit/RedditSourceOperatorFunction.java` | delete |
| Operator registry | `common/workflow-operator/.../operator/LogicalOp.scala` | drop import + `@Type(... "RedditSearch")` |
| Python deps | `amber/requirements.txt`, `amber/operator-requirements.txt`, `amber/system-requirements-lock.txt` | drop `praw`, `prawcore` |
| License manifest | `amber/LICENSE-binary-python` | drop `praw`, `prawcore` rows |
| Frontend asset | `frontend/src/assets/operator_images/RedditSearch.png` | delete |
| Docs | `docs/reference/operators/external-api/reddit-search.md`, `docs/reference/operators/external-api/_index.md` | delete page; drop index row |
| Contributing guide | `docs/contribution-guidelines/guide-to-implement-java-operator.md` | genericize sample `@JsonPropertyDescription` text (was Reddit-specific) |
Result: `11 files changed, 2 insertions(+), 245 deletions(-)`. Frontend looks up operator PNGs by `operatorType` (`assets/operator_images/<type>.png`), so dropping the Type registration is sufficient — no other UI references to `RedditSearch` exist.
Left in place intentionally: `update-checker` and `websocket-client` in `system-requirements-lock.txt`. They are praw transitives, but the lock file is regenerated separately and these may be pulled by other deps — keeping the lock file truthful pending regeneration.
### Any related issues, documentation, discussions?
Closes #5687
### How was this PR tested?
- `STORAGE_JDBC_USERNAME=texera STORAGE_JDBC_PASSWORD=password sbt "WorkflowOperator/compile"` — clean (260 Scala / 49 Java sources, 21s)
- `sbt scalafmtCheckAll` — clean
- `grep -rni "reddit\|praw" --include="*.scala" --include="*.java" --include="*.py" --include="*.ts" --include="*.html" --include="*.json" --include="*.txt" --include="*.yaml" --include="*.yml" --include="*.md"` — no remaining references
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove Reddit Search operator and praw dep [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed pull request #5688: chore: remove Reddit Search operator and praw dep
URL: https://github.com/apache/texera/pull/5688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove Reddit Search operator and praw dep [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #5688:
URL: https://github.com/apache/texera/pull/5688#issuecomment-4699890166
Wrong scope — superseded by a follow-up PR that just dedups the duplicate `praw==7.6.1` pin from `amber/requirements.txt` (the entry stays in `operator-requirements.txt`, where operator-specific deps belong). Closing without merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove Reddit Search operator and praw dep [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5688:
URL: https://github.com/apache/texera/pull/5688#issuecomment-4699845635
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 4 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> CI benchmark results are noisy; treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/27479529720)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 400 | 0.244 | 25,131/33,068/33,068 us | 🔴 +9.3% / 🟢 -6.0% |
| 🟢 | bs=100 sw=10 sl=64 | 959 | 0.585 | 104,323/129,474/129,474 us | 🟢 -10.2% / 🟢 -7.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,128 | 0.689 | 888,926/936,689/936,689 us | ⚪ within ±5% / 🟢 -8.0% |
<details><summary>Baseline details</summary>
Latest main `4fd395b` from 2026-06-13T21:15:43.559Z
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 400 tuples/sec | 425.86 tuples/sec | 411.23 tuples/sec | -6.1% | -2.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.244 MB/s | 0.26 MB/s | 0.251 MB/s | -6.1% | -2.8% |
| bs=10 sw=10 sl=64 | p50 | 25,131 us | 24,156 us | 23,773 us | +4.0% | +5.7% |
| bs=10 sw=10 sl=64 | p95 | 33,068 us | 30,243 us | 35,177 us | +9.3% | -6.0% |
| bs=10 sw=10 sl=64 | p99 | 33,068 us | 30,243 us | 35,177 us | +9.3% | -6.0% |
| bs=100 sw=10 sl=64 | throughput | 959 tuples/sec | 957.92 tuples/sec | 896.95 tuples/sec | +0.1% | +6.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.585 MB/s | 0.585 MB/s | 0.547 MB/s | +0.1% | +6.9% |
| bs=100 sw=10 sl=64 | p50 | 104,323 us | 103,271 us | 111,596 us | +1.0% | -6.5% |
| bs=100 sw=10 sl=64 | p95 | 129,474 us | 144,102 us | 139,415 us | -10.2% | -7.1% |
| bs=100 sw=10 sl=64 | p99 | 129,474 us | 144,102 us | 139,415 us | -10.2% | -7.1% |
| bs=1000 sw=10 sl=64 | throughput | 1,128 tuples/sec | 1,118 tuples/sec | 1,048 tuples/sec | +0.9% | +7.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.689 MB/s | 0.682 MB/s | 0.64 MB/s | +1.0% | +7.7% |
| bs=1000 sw=10 sl=64 | p50 | 888,926 us | 892,725 us | 966,517 us | -0.4% | -8.0% |
| bs=1000 sw=10 sl=64 | p95 | 936,689 us | 943,636 us | 1,016,694 us | -0.7% | -7.9% |
| bs=1000 sw=10 sl=64 | p99 | 936,689 us | 943,636 us | 1,016,694 us | -0.7% | -7.9% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,499.40,200,128000,400,0.244,25130.76,33068.29,33068.29
1,100,10,64,20,2085.72,2000,1280000,959,0.585,104322.74,129473.68,129473.68
2,1000,10,64,20,17728.89,20000,12800000,1128,0.689,888926.17,936689.49,936689.49
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: remove Reddit Search operator and praw dep [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5688:
URL: https://github.com/apache/texera/pull/5688#issuecomment-4699841303
### :warning: JUnit XML file not found
The CLI was unable to find any JUnit XML files to upload.
For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org