You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/27 09:37:10 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24719:
[SPARK-27849][SQL] Redact treeString of FileTable and
DataSourceV2ScanExecBase
cloud-fan commented on a change in pull request #24719: [SPARK-27849][SQL] Redact treeString of FileTable and DataSourceV2ScanExecBase
URL: https://github.com/apache/spark/pull/24719#discussion_r287719828
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala
##########
@@ -35,7 +36,14 @@ trait DataSourceV2ScanExecBase extends LeafExecNode with ColumnarBatchScan {
def readerFactory: PartitionReaderFactory
override def simpleString(maxFields: Int): String = {
- s"$nodeName${truncatedString(output, "[", ", ", "]", maxFields)} ${scan.description()}"
+ redact(s"$nodeName${truncatedString(output, "[", ", ", "]", maxFields)} ${scan.description()}")
Review comment:
nit: seems we only need to redact `scan.description`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org