You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/05 00:31:52 UTC

[GitHub] [beam] damccorm opened a new issue, #21618: Remove invalid mod type from DataChangeRecord

damccorm opened a new issue, #21618:
URL: https://github.com/apache/beam/issues/21618

   Remove the invalid (and unused) mod type INSERT_OR_UPDATE from the Spanner Change Streams modtype
   
   Imported from Jira [BEAM-14419](https://issues.apache.org/jira/browse/BEAM-14419). Original Jira may contain additional context.
   Reported by: thiagotnunes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles closed issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
kennknowles closed issue #21618: Remove invalid mod type from DataChangeRecord
URL: https://github.com/apache/beam/issues/21618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1155270375

   This appears to have been fixed by #17556. @thiagotnunes can you confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] thiagotnunes commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1155782300

   Yes, that was fixed already, sorry about the late reply


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1156647412

   @thiagotnunes since you fixed this, could you self-assign and close it for our records?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1146712247

   Unable to assign user @thiagotnunes. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1156647644

   Ah, now that you commented I can assign you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on issue #21618: Remove invalid mod type from DataChangeRecord

Posted by GitBox <gi...@apache.org>.
kennknowles commented on issue #21618:
URL: https://github.com/apache/beam/issues/21618#issuecomment-1155271780

   In any case I do not see that this would be a release blocker unless it made things nonfunctional. But it seems that this was removing an invalid option to prevent users from choosing it. It wouldn't stop users from using valid configurations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org