You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/23 13:15:49 UTC

[GitHub] [beam] yyy1000 opened a new pull request, #24773: remove duplicated null checks in Row.Equals

yyy1000 opened a new pull request, #24773:
URL: https://github.com/apache/beam/pull/24773

   This PR is for #issue(https://github.com/apache/beam/issues/19561).
   As illustrated, PR(https://github.com/apache/beam/pull/6845) created the function "deepEquals", which could work when the value is null. So we can remove duplicated null checks in that.
   
   * I also need help with how could I run java unit tests for these functions in my local environment, could anyone help me?
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1462001876

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1473777816

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yyy1000 commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
yyy1000 commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1365221384

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed pull request #24773: remove duplicated null checks in Row.Equals

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #24773: remove duplicated null checks in Row.Equals
URL: https://github.com/apache/beam/pull/24773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1372152798

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yyy1000 commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
yyy1000 commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1374317578

   > Suppose a={1, null}, b={2, null} so they have same size, previously a != b but now a equals b because value and otherValue are both null.
   > 
   > This is not get caught by unit test so we need to improve our test imo.
   
   Sorry for missing that.
   I think there are no duplicated null checks in the code now, so maybe no changes could be made for that. :)
   We can close this PR and the original issue.
   Should I add a unit test for " a={1, null}, b={2, null} " or no need?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yyy1000 commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
yyy1000 commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1372151643

   R: @kennknowles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yyy1000 commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
yyy1000 commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1365225149

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1374605880

   yeah I agree to close the original issue as won't do. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1374187076

   Suppose a={1, null}, b={2, null} so they have same size, but now a equals b because value and otherValue are both null.
   
   This is not get caught by unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #24773: remove duplicated null checks in Row.Equals

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24773:
URL: https://github.com/apache/beam/pull/24773#issuecomment-1363979787

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label java.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org