You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/03 03:24:42 UTC
[GitHub] [iceberg] southernriver opened a new pull request #2667: Update context conditions
southernriver opened a new pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667
Param scanAllFiles Used to check whether all the data files should be processed, or only added files.Here we should replace scanAllFiles to !scanAllFiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] southernriver commented on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
southernriver commented on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-853540015
cc @SreeramGarlapati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-864169555
@SreeramGarlapati, FYI. Looks like there may be some issues with `MicroBatches`. I'm committing this fix but we should probably have some good testing for your Spark 3 work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] southernriver commented on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
southernriver commented on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-855842161
cc @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] southernriver commented on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
southernriver commented on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-853540015
cc @SreeramGarlapati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] southernriver removed a comment on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
southernriver removed a comment on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-853540015
cc @SreeramGarlapati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2667: Update context conditions
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2667:
URL: https://github.com/apache/iceberg/pull/2667#issuecomment-860125093
This looks correct to me, but I don't know why tests would be passing with a logic error like this. I approved running tests and we'll see if they still pass. If they do, then that indicates that this path isn't tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org