You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/06 11:38:35 UTC
[GitHub] [mynewt-nimble] fjmolinas opened a new pull request #997: porting/npl/riot: add namespaced syscfg symlink
fjmolinas opened a new pull request #997:
URL: https://github.com/apache/mynewt-nimble/pull/997
This PR symlinks the autogenerated `syscfg` so that it can be included while overriding settings in a custom `syscfg.h`, it's used when building in RIOT for multiple packages based on mynewt, see RIOT-OS/RIOT#16348 and RIOT-OS/RIOT#15528. With the namespace, the header can be included individually and not the whole include dir.
@haukepetersen might be the right person to review this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen commented on pull request #997: porting/npl/riot: add namespaced syscfg symlink
Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #997:
URL: https://github.com/apache/mynewt-nimble/pull/997#issuecomment-915998258
Does not interfere or break anything and helps a lot on the RIOT side -> ACK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] fjmolinas commented on pull request #997: porting/npl/riot: add namespaced syscfg symlink
Posted by GitBox <gi...@apache.org>.
fjmolinas commented on pull request #997:
URL: https://github.com/apache/mynewt-nimble/pull/997#issuecomment-916014865
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] haukepetersen merged pull request #997: porting/npl/riot: add namespaced syscfg symlink
Posted by GitBox <gi...@apache.org>.
haukepetersen merged pull request #997:
URL: https://github.com/apache/mynewt-nimble/pull/997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] fjmolinas commented on pull request #997: porting/npl/riot: add namespaced syscfg symlink
Posted by GitBox <gi...@apache.org>.
fjmolinas commented on pull request #997:
URL: https://github.com/apache/mynewt-nimble/pull/997#issuecomment-901784034
ping @haukepetersen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org