You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2013/11/12 21:10:21 UTC
[1/2] git commit: [flex-falcon] [refs/heads/develop_strictest] - Add
strictest possible compiler flags to the publisher.
Updated Branches:
refs/heads/develop_strictest [created] 9e10215ec
Add strictest possible compiler flags to the publisher.
Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/e88449e2
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/e88449e2
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/e88449e2
Branch: refs/heads/develop_strictest
Commit: e88449e2baa758c969df0e5b8d611e1273b5cd72
Parents: dc0c5fe
Author: Erik de Bruin <er...@ixsoftware.nl>
Authored: Tue Nov 12 21:09:18 2013 +0100
Committer: Erik de Bruin <er...@ixsoftware.nl>
Committed: Tue Nov 12 21:09:18 2013 +0100
----------------------------------------------------------------------
.../codegen/mxml/flexjs/MXMLFlexJSPublisher.java | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/e88449e2/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSPublisher.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSPublisher.java b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSPublisher.java
index 551e65a..beb9764 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSPublisher.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSPublisher.java
@@ -25,9 +25,9 @@ import org.apache.flex.compiler.internal.graph.GoogDepsWriter;
import org.apache.flex.compiler.internal.projects.FlexJSProject;
import org.apache.flex.compiler.utils.JSClosureCompilerUtil;
-//import com.google.javascript.jscomp.ErrorManager;
import com.google.javascript.jscomp.SourceFile;
import com.google.javascript.jscomp.SourceMap;
+//import com.google.javascript.jscomp.ErrorManager;
//import com.google.javascript.jscomp.deps.DepsGenerator;
//import com.google.javascript.jscomp.deps.DepsGenerator.InclusionStrategy;
@@ -223,6 +223,19 @@ public class MXMLFlexJSPublisher extends JSGoogPublisher implements
optionList.add("--js=" + file.getCanonicalPath());
}
+ // (erikdebruin) set compiler flags to 'strictest' to allow maximum
+ // code optimization
+ // start 'really strict'
+ optionList.add("--define='goog.DEBUG=false'");
+ optionList.add("--language_in=ECMASCRIPT5_STRICT");
+ optionList.add("--warning_level=VERBOSE");
+ optionList.add("--jscomp_warning=accessControls");
+ optionList.add("--jscomp_warning=const");
+ optionList.add("--jscomp_warning=constantProperty");
+ optionList.add("--jscomp_warning=strictModuleDepCheck");
+ optionList.add("--jscomp_warning=visibility");
+ // end 'really strict'
+
optionList.add("--closure_entry_point=" + projectName);
optionList.add("--only_closure_dependencies");
optionList.add("--compilation_level=ADVANCED_OPTIMIZATIONS");
[2/2] git commit: [flex-falcon] [refs/heads/develop_strictest] -
Remove some 'success' System.out calls,
to make the not so successful ones stand out.
Posted by er...@apache.org.
Remove some 'success' System.out calls, to make the not so successful ones stand out.
Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/9e10215e
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/9e10215e
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/9e10215e
Branch: refs/heads/develop_strictest
Commit: 9e10215ec891c79d719879485fd4a26ff989cadf
Parents: e88449e
Author: Erik de Bruin <er...@ixsoftware.nl>
Authored: Tue Nov 12 21:10:03 2013 +0100
Committer: Erik de Bruin <er...@ixsoftware.nl>
Committed: Tue Nov 12 21:10:03 2013 +0100
----------------------------------------------------------------------
.../compiler/internal/graph/GoogDepsWriter.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/9e10215e/compiler.jx/src/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java b/compiler.jx/src/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
index c494ad0..11cf320 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
@@ -200,7 +200,7 @@ public class GoogDepsWriter {
File destFile;
File f;
- System.out.println("Finding file for class: " + className);
+ //System.out.println("Finding file for class: " + className);
String classPath = className.replace(".", File.separator);
if (className.contains("goog."))
{
@@ -217,7 +217,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -235,7 +235,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -254,7 +254,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -273,7 +273,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -297,7 +297,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -324,7 +324,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}
@@ -350,7 +350,7 @@ public class GoogDepsWriter {
// copy source to output
try {
FileUtils.copyFile(f, destFile);
- System.out.println("Copying file for class: " + className);
+ //System.out.println("Copying file for class: " + className);
} catch (IOException e) {
System.out.println("Error copying file for class: " + className);
}