[GitHub] [hive] dengzhhu653 commented on pull request #2218: HIVE-25055: Improve the exception handling in HMSHandler

[GitBox <gi...@apache.org>]

dengzhhu653 commented on pull request #2218:
URL: https://github.com/apache/hive/pull/2218#issuecomment-847497433


   > Hello. I agree that this section of code needs a lot of help. However, I think the real issue is that we are throwing these Thrift-exceptions from deep in Hive core code. I propose that we stop doing that and instead wrap these Thrift exceptions appropriately as they bubble up from Hive-core. This is effort highlights yet another issue with working with these Thrift exceptions.
   > 
   > Take a look at https://issues.apache.org/jira/browse/HIVE-25126
   
   Hey, @belugabehr, thank you for the input. As I can see, remove the Thrift-exceptions from the Hive core is not easy.  There are some external classes that implements the RawStore, for example, the authorizing RawStore, removing the exceptions will make some incompatible, the retrying Metastore client uses the exception to make a decision on retrying the current operation, it's may not easy to transform un-checked Exceptions into Thrift exceptions appropriately(by message?)  and we should move the current throw-if-meet logic deep in hive core to the HMS Handler. What do you think?
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org