You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/05 06:32:41 UTC
[GitHub] [shardingsphere] abhinav-koppula opened a new pull request, #20788: [Issue #20385]-More unit-tests added for CreateTableStatementHandler
abhinav-koppula opened a new pull request, #20788:
URL: https://github.com/apache/shardingsphere/pull/20788
Fixes #20385 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #20788: [Issue #20385]-More unit-tests added for CreateTableStatementHandler
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #20788:
URL: https://github.com/apache/shardingsphere/pull/20788#discussion_r963158783
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateTableStatementHandlerTest.java:
##########
@@ -42,4 +50,31 @@ public void assertIfNotExists() {
assertFalse(CreateTableStatementHandler.ifNotExists(new SQLServerCreateTableStatement()));
assertFalse(CreateTableStatementHandler.ifNotExists(new SQL92CreateTableStatement()));
}
+
+ @Test
+ public void assertSelectStatement() {
Review Comment:
assertGetSelectStatement may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] abhinav-koppula commented on a diff in pull request #20788: [Issue #20385]-More unit-tests added for CreateTableStatementHandler
Posted by GitBox <gi...@apache.org>.
abhinav-koppula commented on code in PR #20788:
URL: https://github.com/apache/shardingsphere/pull/20788#discussion_r963237440
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateTableStatementHandlerTest.java:
##########
@@ -42,4 +50,31 @@ public void assertIfNotExists() {
assertFalse(CreateTableStatementHandler.ifNotExists(new SQLServerCreateTableStatement()));
assertFalse(CreateTableStatementHandler.ifNotExists(new SQL92CreateTableStatement()));
}
+
+ @Test
+ public void assertSelectStatement() {
Review Comment:
Makes sense, done - https://github.com/apache/shardingsphere/pull/20788/commits/b879baf960de092e8bcb6f7c27ad69f09b89c300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20788: [Issue #20385]-More unit-tests added for CreateTableStatementHandler
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20788:
URL: https://github.com/apache/shardingsphere/pull/20788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20788: [Issue #20385]-More unit-tests added for CreateTableStatementHandler
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20788:
URL: https://github.com/apache/shardingsphere/pull/20788#issuecomment-1237688896
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20788](https://codecov.io/gh/apache/shardingsphere/pull/20788?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b18b90) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4d32950a89816ec0a80d060b5c4a6f29869720f9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d32950) will **increase** coverage by `0.01%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #20788 +/- ##
============================================
+ Coverage 61.40% 61.41% +0.01%
- Complexity 2423 2424 +1
============================================
Files 3995 3997 +2
Lines 55348 55351 +3
Branches 9400 9401 +1
============================================
+ Hits 33984 33994 +10
+ Misses 18480 18473 -7
Partials 2884 2884
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dbc/transaction/JDBCBackendTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vSkRCQ0JhY2tlbmRUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `46.75% <ø> (ø)` | |
| [...tion/jdbc/transaction/LocalTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vTG9jYWxUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `48.00% <ø> (ø)` | |
| [...atasource/props/DataSourcePropertiesValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL0RhdGFTb3VyY2VQcm9wZXJ0aWVzVmFsaWRhdG9yLmphdmE=) | `88.00% <50.00%> (ø)` | |
| [...tion/MismatchedProtocolAndDataSourceException.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vTWlzbWF0Y2hlZFByb3RvY29sQW5kRGF0YVNvdXJjZUV4Y2VwdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...dingsphere/driver/jdbc/adapter/WrapperAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvV3JhcHBlckFkYXB0ZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...here/driver/jdbc/core/ShardingSphereSavepoint.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvU2hhcmRpbmdTcGhlcmVTYXZlcG9pbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...driver/jdbc/core/connection/ConnectionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `64.74% <0.00%> (ø)` | |
| [...jdbc/core/connection/ShardingSphereConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ1NwaGVyZUNvbm5lY3Rpb24uamF2YQ==) | `73.25% <0.00%> (ø)` | |
| [...on/executor/advanced/resultset/WrapperAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2FkdmFuY2VkL3Jlc3VsdHNldC9XcmFwcGVyQWRhcHRlci5qYXZh) | `20.00% <0.00%> (ø)` | |
| [...exception/OverallConnectionNotEnoughException.java](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2V4Y2VwdGlvbi9PdmVyYWxsQ29ubmVjdGlvbk5vdEVub3VnaEV4Y2VwdGlvbi5qYXZh) | `100.00% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/20788/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org