You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Remus Rusanu <re...@microsoft.com> on 2013/06/04 11:49:19 UTC

Re: Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11579/
-----------------------------------------------------------

(Updated June 4, 2013, 9:49 a.m.)


Review request for hive.


Changes
-------

Fixed AVG and added UT to cover each template with Double type.


Description
-------

See HIVE-4637


This addresses bug HIVE-4637.
    https://issues.apache.org/jira/browse/HIVE-4637


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFAvgDouble.java 38b14f1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFAvgLong.java 115444d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMaxDouble.java bc7f852 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMaxLong.java 6ba416e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMinDouble.java d982fc2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMinLong.java a8f5531 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFSumDouble.java a5dac79 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFSumLong.java 4d1db3d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 888f9ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFAvg.txt 7887ceb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFMinMax.txt d00d9ae 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFSum.txt aaaa6ad 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 42cdcf4 

Diff: https://reviews.apache.org/r/11579/diff/


Testing
-------

Added new UT to cover this case


Thanks,

Remus Rusanu