You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/11 22:17:19 UTC

[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #3103: [GOBBLIN-1262 Update flow execution as failed if it was skipped due to concurrently…

jack-moseley opened a new pull request #3103:
URL: https://github.com/apache/incubator-gobblin/pull/3103

… running flow

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1262

### Description
- [x] Here are some details about my PR, including screenshots (if applicable):

Previously a flow that was skipped due to another concurrently running flow would return a flow execution ID, but not update any flow status for that flow. This PR adds a flow failed event with a message in those cases so it is clear why a flow was not launched.

### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

Tested in gaas locally

### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] jack-moseley commented on pull request #3103: [GOBBLIN-1262 Update flow execution as failed if it was skipped due to concurrently…

Posted by GitBox <gi...@apache.org>.

jack-moseley commented on pull request #3103:
URL: https://github.com/apache/incubator-gobblin/pull/3103#issuecomment-692212022


   @sv2000 please review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] asfgit closed pull request #3103: [GOBBLIN-1262 Update flow execution as failed if it was skipped due to concurrently…

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #3103:
URL: https://github.com/apache/incubator-gobblin/pull/3103


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org