You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by fs...@apache.org on 2018/04/13 18:14:29 UTC
svn commit: r1829092 - in /jmeter/trunk:
src/core/org/apache/jmeter/gui/action/Duplicate.java xdocs/changes.xml
Author: fschumacher
Date: Fri Apr 13 18:14:29 2018
New Revision: 1829092
URL: http://svn.apache.org/viewvc?rev=1829092&view=rev
Log:
Correct order of elements when duplicating a selection of multiple elements.
Bugzilla Id: 62295
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java?rev=1829092&r1=1829091&r2=1829092&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java Fri Apr 13 18:14:29 2018
@@ -59,7 +59,8 @@ public class Duplicate extends AbstractA
JMeterTreeNode currentNode = treeListener.getCurrentNode();
JMeterTreeNode parentNode = (JMeterTreeNode) currentNode.getParent();
JMeterTreeModel treeModel = instance.getTreeModel();
- for (JMeterTreeNode copiedNode : copiedNodes) {
+ for (int nodeIndex = copiedNodes.length - 1; nodeIndex >= 0; nodeIndex--) {
+ JMeterTreeNode copiedNode = copiedNodes[nodeIndex];
int index = parentNode.getIndex(currentNode) + 1;
treeModel.insertNodeInto(copiedNode, parentNode, index);
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1829092&r1=1829091&r2=1829092&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Fri Apr 13 18:14:29 2018
@@ -215,6 +215,7 @@ this behaviour, set <code>httpclient.res
<li><bug>62127</bug>Store filename as String instead of File in FileEditor. This will prevent conversion of filenames from unix style path separators to Windows style when used for example in CSV Data Set Config.</li>
<li><bug>56150</bug>Keep the index right, when scrolling through the menu items.</li>
<li><bug>62240</bug>If SampleMonitor implementation is a TestBean if will not be initialized correctly</li>
+ <li><bug>62295</bug>Correct order of elements when duplicating a selection of multiple elements.</li>
</ul>
<!-- =================== Thanks =================== -->
Re: svn commit: r1829092 - in /jmeter/trunk: src/core/org/apache/jmeter/gui/action/Duplicate.java
xdocs/changes.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Nice
On Fri, Apr 13, 2018 at 8:14 PM, <fs...@apache.org> wrote:
> Author: fschumacher
> Date: Fri Apr 13 18:14:29 2018
> New Revision: 1829092
>
> URL: http://svn.apache.org/viewvc?rev=1829092&view=rev
> Log:
> Correct order of elements when duplicating a selection of multiple
> elements.
>
> Bugzilla Id: 62295
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/
> Duplicate.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/gui/action/Duplicate.java?rev=1829092&r1=
> 1829091&r2=1829092&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/Duplicate.java Fri
> Apr 13 18:14:29 2018
> @@ -59,7 +59,8 @@ public class Duplicate extends AbstractA
> JMeterTreeNode currentNode = treeListener.getCurrentNode();
> JMeterTreeNode parentNode = (JMeterTreeNode)
> currentNode.getParent();
> JMeterTreeModel treeModel = instance.getTreeModel();
> - for (JMeterTreeNode copiedNode : copiedNodes) {
> + for (int nodeIndex = copiedNodes.length - 1; nodeIndex >= 0;
> nodeIndex--) {
> + JMeterTreeNode copiedNode = copiedNodes[nodeIndex];
> int index = parentNode.getIndex(currentNode) + 1;
> treeModel.insertNodeInto(copiedNode, parentNode, index);
> }
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> xml?rev=1829092&r1=1829091&r2=1829092&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Fri Apr 13 18:14:29 2018
> @@ -215,6 +215,7 @@ this behaviour, set <code>httpclient.res
> <li><bug>62127</bug>Store filename as String instead of File in
> FileEditor. This will prevent conversion of filenames from unix style path
> separators to Windows style when used for example in CSV Data Set
> Config.</li>
> <li><bug>56150</bug>Keep the index right, when scrolling through the
> menu items.</li>
> <li><bug>62240</bug>If SampleMonitor implementation is a TestBean if
> will not be initialized correctly</li>
> + <li><bug>62295</bug>Correct order of elements when duplicating a
> selection of multiple elements.</li>
> </ul>
>
> <!-- =================== Thanks =================== -->
>
>
>
--
Cordialement.
Philippe Mouawad.