[ https://issues.apache.org/jira/browse/NIFI-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459805#comment-16459805 ]
ASF GitHub Bot commented on NIFI-5136:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2668
NIFI-5136 Ensure processor references are removed from LogRepository …
…and from ProcessScheduler
- Forcing FileSystem statistics thread to be interrupted when HDFS processors are stopped
- Stop creating temp components during import from registry, use bundle info instead
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi stop-leaking-processors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2668
----
commit 0e5b55527cd9c957f4b8015d799c526012b7c883
Author: Bryan Bende <bb...@...>
Date: 2018-04-27T18:52:58Z
NIFI-5136 Ensure processor references are removed from LogRepository and from ProcessScheduler
- Forcing FileSystem statistics thread to be interrupted when HDFS processors are stopped
- Stop creating temp components during import from registry, use bundle info instead
----
> Leaked component references preventing GC of components and class loaders
> -------------------------------------------------------------------------
>
> Key: NIFI-5136
> URL: https://issues.apache.org/jira/browse/NIFI-5136
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Major
>
> A user on the mailing list reported that after some time of creating/deleting HDFS processors, it appeared that the classes/instances were still around and eventually the NiFi instance would get out of memory and need to be restarted.
> After investigation there are multiple issues preventing garbage collection of deleted components. One issue is specific to the HDFS processors, the other issues are for all components...
> 1) The LogRepository still has a reference to a ComponentLogger which has a reference to the component
> 2) The processor scheduler has a map of scheduled states which has references to processors that have been deleted
> 3) The Hadoop processors start a thread that is never stopped when the processor is stopped/deleted, this means the class loader can't be cleaned up b/c the Runnable came from the InstanceClassLoader of the deleted processor
> 4) Importing a flow from registry will instantiate an instance of each component to ensure the incoming types are valid, but the InstanceClassLoader and ComponentLogger are not cleaned up for these temp instances
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)